From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdI1DGn (ORCPT ); Wed, 27 Sep 2017 23:06:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:11797 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbdI1DGm (ORCPT ); Wed, 27 Sep 2017 23:06:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,448,1500966000"; d="scan'208";a="1176529367" Date: Thu, 28 Sep 2017 08:40:36 +0530 From: Vinod Koul To: Chintan Patel Cc: alsa-devel@alsa-project.org, Hsin-yu Chao , harshapriya.n@intel.com, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Julia Lawall , Mark Brown , Jeeja KP , Sathya Prakash M R , naveen.m@intel.com Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution Message-ID: <20170928031036.GU30097@localhost> References: <1505749403-31346-1-git-send-email-chintan.m.patel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505749403-31346-1-git-send-email-chintan.m.patel@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 18, 2017 at 08:43:18AM -0700, Chintan Patel wrote: > Jack name is not getting formatted correctly hence resulting > in invalid name for HDMI/DP input devices. > > This was recently exposed due changes brought by MST: > commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize > in kbl machine drivers") Acked-By: Vinod Koul > > Signed-off-by: Chintan Patel > --- > sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c > index 4689991bcc86..c127b7b0ee3f 100644 > --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c > +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c > @@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card) > > list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) { > codec = pcm->codec_dai->codec; > + snprintf(jack_name, sizeof(jack_name), > + "HDMI/DP, pcm=%d Jack", pcm->device); > err = snd_soc_card_jack_new(card, jack_name, > SND_JACK_AVOUT, &ctx->kabylake_hdmi[i], > NULL, 0); > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- ~Vinod