From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbdI1HlN (ORCPT ); Thu, 28 Sep 2017 03:41:13 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:37354 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbdI1HlL (ORCPT ); Thu, 28 Sep 2017 03:41:11 -0400 X-Google-Smtp-Source: AOwi7QCzvOuqrQlqhlj10AXJ1QtniW9B7/BkEvqVD1dQ3JZYUDCZDAQJQJfoIPuy6HhU6D8ZNeSILg== Date: Thu, 28 Sep 2017 09:41:08 +0200 From: Ingo Molnar To: Jean Delvare Cc: x86@kernel.org, LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Alok Kataria Subject: Re: [PATCH] x86/setup: Clarify a comment Message-ID: <20170928074108.yvwuoso7xi7qycfb@gmail.com> References: <20170919143750.246159e4@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170919143750.246159e4@endymion> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jean Delvare wrote: > It's not obvious to everybody that BP stands for boot processor. At > least it was not for me. > > Signed-off-by: Jean Delvare > Cc: Alok Kataria > --- > arch/x86/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-4.14-rc1.orig/arch/x86/kernel/setup.c 2017-09-17 00:47:51.000000000 +0200 > +++ linux-4.14-rc1/arch/x86/kernel/setup.c 2017-09-19 14:28:30.553830299 +0200 > @@ -1045,7 +1045,7 @@ void __init setup_arch(char **cmdline_p) > > /* > * VMware detection requires dmi to be available, so this > - * needs to be done after dmi_scan_machine, for the BP. > + * needs to be done after dmi_scan_machine, for the boot processor. > */ > init_hypervisor_platform(); Ok, I agree with this change - but there's a couple of other references to 'BP' in the x86 code, if then we should change all of them over to 'boot CPU'. Also, while at it, please change 'dmi_scan_machine' to 'dmi_scan_machine()', which is the canonical way to refer to function calls. Thanks, Ingo