From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbdI1JC5 (ORCPT ); Thu, 28 Sep 2017 05:02:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:47582 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752011AbdI1JCz (ORCPT ); Thu, 28 Sep 2017 05:02:55 -0400 Date: Thu, 28 Sep 2017 11:02:42 +0200 From: Borislav Petkov To: Brijesh Singh Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski Subject: Re: [Part1 PATCH v5 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support Message-ID: <20170928090242.ber7gynwaldinafa@pd.tnic> References: <20170927151329.70011-1-brijesh.singh@amd.com> <20170927151329.70011-3-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170927151329.70011-3-brijesh.singh@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2017 at 10:13:14AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Provide support for Secure Encrypted Virtualization (SEV). This initial > support defines a flag that is used by the kernel to determine if it is > running with SEV active. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Borislav Petkov > Cc: Andy Lutomirski > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > Signed-off-by: Tom Lendacky > Signed-off-by: Brijesh Singh > --- > arch/x86/include/asm/mem_encrypt.h | 6 ++++++ > arch/x86/mm/mem_encrypt.c | 26 ++++++++++++++++++++++++++ > include/linux/mem_encrypt.h | 7 +++++-- > 3 files changed, 37 insertions(+), 2 deletions(-) Reviewed-by: Borislav Petkov > +bool sev_active(void) > +{ > + return sme_me_mask && sev_enabled; What I'm still missing is the chicken bit. I.e., to be able to boot with "mem_encrypt=smeonly" or so, which disables the SEV side but can still allow SME. For when SEV has issues and people want to disable it. You can do the patch ontop of those and send it as a reply to this thread - no need to wait to resend the whole thing again. Thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --