From: Jean Delvare <jdelvare@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] params: Fix an overflow in param_attr_show
Date: Thu, 28 Sep 2017 15:33:09 +0200 [thread overview]
Message-ID: <20170928153309.1d00b323@endymion> (raw)
In-Reply-To: <20170928083827.sqdllgt6hqvbtvh3@gmail.com>
On Thu, 28 Sep 2017 10:38:27 +0200, Ingo Molnar wrote:
> * Jean Delvare <jdelvare@suse.de> wrote:
> > Or... I could append the \n inside the STANDARD_PARAM_DEF macro, so the
> > calls are unchanged. Makes my patch smaller, and addresses your concern
> > just as well, I suppose.
>
> Yeah, that would be even better:
>
> Acked-by: Ingo Molnar <mingo@kernel.org>
>
> Note that the vertical alignment makes things easier to read regardless of the \n.
Agreed, but now I'll make it a separate patch.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-09-28 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 8:10 [PATCH] params: Fix an overflow in param_attr_show Jean Delvare
2017-09-27 8:26 ` Ingo Molnar
2017-09-27 9:40 ` Jean Delvare
2017-09-27 13:31 ` Ingo Molnar
2017-09-28 8:02 ` Jean Delvare
2017-09-28 8:11 ` Jean Delvare
2017-09-28 8:38 ` Ingo Molnar
2017-09-28 13:33 ` Jean Delvare [this message]
2017-09-28 8:48 ` Ingo Molnar
2017-09-28 8:49 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928153309.1d00b323@endymion \
--to=jdelvare@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox