From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751822AbdI1QB3 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 12:01:29 -0400
Received: from mx2.suse.de ([195.135.220.15]:58761 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751587AbdI1QB2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 12:01:28 -0400
Date: Thu, 28 Sep 2017 15:33:09 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, Baoquan He <bhe@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] params: Fix an overflow in param_attr_show
Message-ID: <20170928153309.1d00b323@endymion>
In-Reply-To: <20170928083827.sqdllgt6hqvbtvh3@gmail.com>
References: <20170927101031.7a3b2398@endymion>
        <20170927082642.slh2gk3zuw5j7gmh@gmail.com>
        <1506505230.14970.22.camel@suse.de>
        <20170927133104.s6meugnrysccwrde@gmail.com>
        <20170928100223.2be62f88@endymion>
        <20170928101108.5a3c270b@endymion>
        <20170928083827.sqdllgt6hqvbtvh3@gmail.com>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Sep 2017 10:38:27 +0200, Ingo Molnar wrote:
> * Jean Delvare <jdelvare@suse.de> wrote:
> > Or... I could append the \n inside the STANDARD_PARAM_DEF macro, so the
> > calls are unchanged. Makes my patch smaller, and addresses your concern
> > just as well, I suppose.  
> 
> Yeah, that would be even better:
> 
>   Acked-by: Ingo Molnar <mingo@kernel.org>
> 
> Note that the vertical alignment makes things easier to read regardless of the \n.

Agreed, but now I'll make it a separate patch.

-- 
Jean Delvare
SUSE L3 Support