From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] mm: kill kmemcheck again
Date: Sat, 30 Sep 2017 05:48:15 -0400 [thread overview]
Message-ID: <20170930054815.0e2c182f@vmware.local.home> (raw)
In-Reply-To: <20170927150207.swmcarc4lqlklohr@dhcp22.suse.cz>
On Wed, 27 Sep 2017 17:02:07 +0200
Michal Hocko <mhocko@kernel.org> wrote:
> > Now that 2 years have passed, and all distros provide gcc that supports
> > KASAN, kill kmemcheck again for the very same reasons.
>
> This is just too large to review manually. How have you generated the
> patch?
I agree. This needs to be taken out piece by piece, not in one go,
where there could be unexpected fallout.
>
> My compile test batery failed for i386 allyesconfig for some reason
> which is not entirely clear to me (see attached). I have applied on top
> of dc972a67cc54585bd83ad811c4e9b6ab3dcd427e and that one compiles fine.
>
> > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
>
> Anyway I fully support this removal. It is a lot of rarely used code and
> KASAN is much more usable.
Now that my default compilers support KASAN, I'm fine with this removal.
-- Steve
next prev parent reply other threads:[~2017-09-30 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:27 [PATCH] mm: kill kmemcheck again Levin, Alexander (Sasha Levin)
2017-09-27 11:32 ` Levin, Alexander (Sasha Levin)
2017-09-27 15:02 ` Michal Hocko
2017-09-27 15:24 ` Levin, Alexander (Sasha Levin)
2017-09-27 17:36 ` Eric W. Biederman
2017-09-27 22:01 ` Levin, Alexander (Sasha Levin)
2017-09-30 9:48 ` Steven Rostedt [this message]
2017-09-30 13:57 ` Vegard Nossum
2017-09-30 20:02 ` Levin, Alexander (Sasha Levin)
2017-10-02 7:29 ` Michal Hocko
2017-10-03 21:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930054815.0e2c182f@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox