* [PATCH] VFS: Handle lazytime in do_mount() [not found] ` <20170919083506.GA233@x4> @ 2017-09-19 10:18 ` Markus Trippelsdorf 2017-09-19 10:37 ` [PATCH v2] " Markus Trippelsdorf 0 siblings, 1 reply; 4+ messages in thread From: Markus Trippelsdorf @ 2017-09-19 10:18 UTC (permalink / raw) To: Theodore Ts'o Cc: Andreas Dilger, linux-ext4, Alexander Viro, linux-fsdevel, linux-kernel The lazytime option didn't get passed on when using current util-linux, which passes MS_LAZYTIME in the mountflags directly. Fix the issue by handling the option in do_mount(). Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> --- fs/namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/namespace.c b/fs/namespace.c index 54059b142d6b..b633838b8f02 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, SB_MANDLOCK | SB_DIRSYNC | SB_SILENT | - SB_POSIXACL); + SB_POSIXACL | + MS_LAZYTIME); if (flags & MS_REMOUNT) retval = do_remount(&path, flags, sb_flags, mnt_flags, -- Markus ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] VFS: Handle lazytime in do_mount() 2017-09-19 10:18 ` [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf @ 2017-09-19 10:37 ` Markus Trippelsdorf 2017-09-19 15:25 ` Lukas Czerner 0 siblings, 1 reply; 4+ messages in thread From: Markus Trippelsdorf @ 2017-09-19 10:37 UTC (permalink / raw) To: Theodore Ts'o Cc: Andreas Dilger, linux-ext4, Alexander Viro, linux-fsdevel, linux-kernel, David Howells Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from internal superblock flags") the lazytime mount option didn't get passed on anymore. Fix the issue by handling the option in do_mount(). Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> --- fs/namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/namespace.c b/fs/namespace.c index 54059b142d6b..b633838b8f02 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, SB_MANDLOCK | SB_DIRSYNC | SB_SILENT | - SB_POSIXACL); + SB_POSIXACL | + SB_LAZYTIME); if (flags & MS_REMOUNT) retval = do_remount(&path, flags, sb_flags, mnt_flags, -- Markus ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] VFS: Handle lazytime in do_mount() 2017-09-19 10:37 ` [PATCH v2] " Markus Trippelsdorf @ 2017-09-19 15:25 ` Lukas Czerner 2017-09-30 7:10 ` Markus Trippelsdorf 0 siblings, 1 reply; 4+ messages in thread From: Lukas Czerner @ 2017-09-19 15:25 UTC (permalink / raw) To: Markus Trippelsdorf Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, Alexander Viro, linux-fsdevel, linux-kernel, David Howells On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") the lazytime mount option didn't get passed > on anymore. > > Fix the issue by handling the option in do_mount(). > > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> > --- > fs/namespace.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/namespace.c b/fs/namespace.c > index 54059b142d6b..b633838b8f02 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, > SB_MANDLOCK | > SB_DIRSYNC | > SB_SILENT | > - SB_POSIXACL); > + SB_POSIXACL | > + SB_LAZYTIME); Looks good. Although I still think that this can be per mountpoint options. Regardless of that, you can add Reviewed-by: Lukas Czerner <lczerner@redhat.com> > > if (flags & MS_REMOUNT) > retval = do_remount(&path, flags, sb_flags, mnt_flags, > -- > Markus ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] VFS: Handle lazytime in do_mount() 2017-09-19 15:25 ` Lukas Czerner @ 2017-09-30 7:10 ` Markus Trippelsdorf 0 siblings, 0 replies; 4+ messages in thread From: Markus Trippelsdorf @ 2017-09-30 7:10 UTC (permalink / raw) To: Lukas Czerner Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, Alexander Viro, linux-fsdevel, linux-kernel, David Howells On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote: > On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > > internal superblock flags") the lazytime mount option didn't get passed > > on anymore. > > > > Fix the issue by handling the option in do_mount(). > > > > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> > > --- > > fs/namespace.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index 54059b142d6b..b633838b8f02 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, > > SB_MANDLOCK | > > SB_DIRSYNC | > > SB_SILENT | > > - SB_POSIXACL); > > + SB_POSIXACL | > > + SB_LAZYTIME); > > Looks good. Although I still think that this can be per mountpoint options. > > Regardless of that, you can add > Reviewed-by: Lukas Czerner <lczerner@redhat.com> Ping? Al could you please take look? Thanks. -- Markus ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-30 7:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170918192644.GA232@x4>
[not found] ` <20170919083506.GA233@x4>
2017-09-19 10:18 ` [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf
2017-09-19 10:37 ` [PATCH v2] " Markus Trippelsdorf
2017-09-19 15:25 ` Lukas Czerner
2017-09-30 7:10 ` Markus Trippelsdorf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox