From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751052AbdJAIAG (ORCPT <rfc822;w@1wt.eu>);
        Sun, 1 Oct 2017 04:00:06 -0400
Received: from verein.lst.de ([213.95.11.211]:59444 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750999AbdJAIAF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 1 Oct 2017 04:00:05 -0400
Date: Sun, 1 Oct 2017 10:00:03 +0200
From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Johannes Thumshirn <jthumshirn@suse.de>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
        linux-nvme@lists.infradead.org, Martin Wilck <mwilck@suse.de>
Subject: Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups
Message-ID: <20171001080003.GD11554@lst.de>
References: <20170928193637.24707-1-mwilck@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170928193637.24707-1-mwilck@suse.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

While this looks okay-ish to me I really don't want people confused
with three variants of add_disk, we really need to consolidate
our helpers there a bit..