From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdJASDx (ORCPT ); Sun, 1 Oct 2017 14:03:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35014 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdJASDv (ORCPT ); Sun, 1 Oct 2017 14:03:51 -0400 Date: Sun, 1 Oct 2017 20:03:59 +0200 From: Greg KH To: Mario.Limonciello@dell.com Cc: dvhart@infradead.org, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, pali.rohar@gmail.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de Subject: Re: [PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers Message-ID: <20171001180359.GA14845@kroah.com> References: <17fcf9748e83ede2751a00d8248cb32cbdc610d6.1506571188.git.mario.limonciello@dell.com> <20170930015228.GC13307@fury> <20170930081205.GA22980@kroah.com> <81ddaac76f15420b800db365d694e156@ausx13mpc120.AMER.DELL.COM> <20171001132336.GA26295@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 01, 2017 at 02:25:00PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Sunday, October 1, 2017 8:24 AM > > To: Limonciello, Mario > > Cc: dvhart@infradead.org; andy.shevchenko@gmail.com; linux- > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; luto@kernel.org; > > quasisec@google.com; pali.rohar@gmail.com; rjw@rjwysocki.net; > > mjg59@google.com; hch@lst.de > > Subject: Re: [PATCH v3 4/8] platform/x86: wmi: create character devices when > > requested by drivers > > > > On Sat, Sep 30, 2017 at 07:26:57PM +0000, Mario.Limonciello@dell.com wrote: > > > I think what's Darren's most interested in is the that conceptually this is > > > an approach you can agree with. > > > > > > "A WMI vendor driver binds to the WMI bus and requests the WMI bus to > > create > > > a character device. The WMI bus creates a character device /dev/wmi/$driver > > > which the WMI vendor driver will process all various file operations." > > > > We've been over this before, let's see that actual implementation which > > defines the "will process all..." implementation to see if that is > > actually an acceptable thing. > > > > thanks, > > > > greg k-h > > I'm working on changes still (that you'll be CC on), but I don't expect this specific > concept to change in the future changes: > > Bus creating character device: > https://patchwork.kernel.org/patch/9975283/ A bit hard to comment on web pages, and I would like to point out your obvious memory leak, but it's hard to do that this way :( > Driver requesting character device: > https://patchwork.kernel.org/patch/9975263/ There's other issues with this patch as well, I'll wait for a real one in my inbox to be able to actually review it :( thanks, greg k-h