From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbdJBEjA (ORCPT ); Mon, 2 Oct 2017 00:39:00 -0400 Received: from mail-eopbgr10046.outbound.protection.outlook.com ([40.107.1.46]:46496 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751027AbdJBEi5 (ORCPT ); Mon, 2 Oct 2017 00:38:57 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Date: Mon, 2 Oct 2017 07:38:48 +0300 From: Leon Romanovsky To: =?iso-8859-1?B?Suly6W15?= Lefaure Cc: Matan Barak , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Message-ID: <20171002043848.GH2031@mtr-leonro.local> References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-5-jeremy.lefaure@lse.epita.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X+8siUETKMkW99st" Content-Disposition: inline In-Reply-To: <20171001193101.8898-5-jeremy.lefaure@lse.epita.fr> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [213.57.247.46] X-ClientProxiedBy: DB6P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::19) To HE1PR0501MB1929.eurprd05.prod.outlook.com (2a01:111:e400:7b74::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cb02580-e9ce-49b3-9b6c-08d5094f7c85 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:HE1PR0501MB1929; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB1929;3:H79EVFHIbdTZuIk6xql948TUM9U8HJsoKPC2KYwtSQl0UIekR4to7l3Rvxmw1vUKQWZXj2cCSMYPJ2XEPdz+n9jDE0K/wXXCxT31fItnwxx0C+49gurCVgB5v66PsU/a53ix64Eu3N36jz/UEfxXzp/SgS7e7f3vcrUSWVc3vzCB0aPcJIqUET5yZymwWGgtX8vXKYJx9eQMHTASE8UpkHMdqpnUNYHRwIzrJ5pKlAXOk7pXyA/VTTHNan66qmGN;25:CWPz/vGXmDNZeTXmV6KnqxbRiX2Ra7rdHGVE5o7OGWEDtCgIko3CUhvwe08uYJZSTXeJhJiEfcrFdKzyXTyoz6IqkZU8uIlPC7IUBkBx7llm2qGqT6tm3FKCqcTiqaE6ctaQHu7Qhaczr7cF08vF0pw197SzovkYBWAFEWgoMnVJbMj9r3mplDRa71mURrQ2AesOWdMcIWQOOmjv7BmB/GZ8BWQhD2H3gR2D5+DzLvjukOenenpNf4fm3dyuRfu1EGOuAcO8fnbSS/AeOLag+IPVVz3YtE7iBQ20CUGQ2jL1PWULdFl2BPqN5bSFVgGHnZ2tl9OXGkPA/dTfqjzrHQ==;31:ujY9tX/UzGKeBbl2xrSdrZSHCSozYVXq/rCZNcn+0w2/ciZUhAUW/C2UnalLm/dnnUQfs9XUoNzD2ULbe/2+/AD0yZmsSUMwkwxfE9Z/8LiMSlXpBOqk15zXxX3dXzqa6kq5ctax2H0YN3hxXXd/0jTg7Ia5lbqlRJVH1zAPN5XdWgud3QJmKnv5z2LaHdtMXD0WfzMzvTl6ffLBYuV+Xg== X-MS-TrafficTypeDiagnostic: HE1PR0501MB1929: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB1929;20:mUqEIqbFBf+U6Bjaib0l/ICoL5UcYy77XNBNyQTxl8RQpuWS17B2BdjueAn7D0A6bOu3lXnUh/xcHMnuwJL+aJq/BvyBuBs0gK7CinEqZf5sSQoOlhI8AGgvMiC81DmzKw3DMzYxq64Gpe6zVRXFyQ5HzRiM68DMQP/zx4ikKS9zKYzQJ6xRNgWpOhTuEqjX00cxnW9jqzETmltoL4TvdUxm3XYAa0re2K/pqIBCkaR2GiujoTwd17CSPNQ8/8pVYM+EzUXa/7xwjnh2H3dwCKAFGchmhjgkxupUstN8i/7OSASz8X6S8KqaN2LYBzF9RGozh5xUtfPqWRIX0Ahs7pO7yP/BFxcQ+Ap2jSCfBKmumbi05vRhT2zi+qCDUDMVaKly0WTfETzi4qzaBZiVq0GJUH+czCXYisYfQhbGSUEhnHjkB9R7tzQbccfT63iUcS2ZeU1Pe2YKMtgDkm1BakO4hr5kPel2jmi7xzh73Xm4PQcMOOW/YdNIMxlWfdDL;4:d0/PDevdDfQ9g6bjSdpqbxDZ227bBJLd9zbPPdcgKRhd8w1YXLCU3XUaiGfJ0s4PNAZCOmPGT3y7njEjLkaxG46hSKNCu1hx7rEA8Z/qFBFgB1u/C2Hz1BWs8K0Ltdg+Ec4weBZNzWycgPcHu++5fcd43qtbvkouoKlKIMCy9wKEI/XCFm7vX2lcx7L4GEdCVbmFSMmn+ASAI9DKOLPO/07Z0dt109OWCXLgWq/i21oseYok/cFfGBiRxaLbYR7k X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0501MB1929;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0501MB1929; X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(39860400002)(376002)(346002)(199003)(24454002)(189002)(5000100001)(2906002)(229853002)(98436002)(7736002)(305945005)(83506001)(54356999)(76176999)(9686003)(50986999)(106356001)(189998001)(8676002)(6116002)(86362001)(5660300001)(478600001)(3846002)(33656002)(21480400003)(84326002)(8936002)(1076002)(2950100002)(76506005)(81166006)(6916009)(66066001)(6486002)(39060400002)(81156014)(316002)(16526017)(97736004)(16586007)(68736007)(105586002)(58126008)(6666003)(54906003)(4326008)(25786009)(101416001)(6246003)(6496005)(53936002)(18370500001)(2700100001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0501MB1929;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;HE1PR0501MB1929;23:S6ItvLDDQ3GFOXQkLd9RkKWR9YnYbiqoyP1Ct?= =?iso-8859-1?Q?om2xcjOd1E9I2jNqFApNBsm3s7Nu6zt2jPjmRboCvft8x1X9xJNcE/TYKy?= =?iso-8859-1?Q?pdjRxFERewEkn8BgnQuZs/2MvFcoOFWo2Ic3nGazbstfvcLiim+ExNcGUG?= =?iso-8859-1?Q?YC/du0QSu5A8UqIPw8vPmpmtf38Spwk2Cr5AYuEFKk5lJm4xz9qxTOtxnN?= =?iso-8859-1?Q?kb2COVg/DQwNekZkIElED0vw5IiPneEpeX4hIMGyGBdEjh0A4fN2riZvXM?= =?iso-8859-1?Q?kO2ohY8yBantf5m90cXUkf6Arei3A7JW2N05mLC3FA6/Gl8sS34uM6KL0P?= =?iso-8859-1?Q?9hFZbZY1GRm+GAhWYIjau6mo0FgHEd8t0hHYfHBBx9ZDv6ac0rIx0djuZl?= =?iso-8859-1?Q?v9kDHNdO/Sgc6pd0CWfluO3ouCM6kiLDGpt6h3U6uNLEL61+HMM2YOPWf5?= =?iso-8859-1?Q?uozmu1TFIPsjt6IpRUIZLpJ7UEyg5UngGHQgHGl1LCWQmBZOCJ9QTokkTl?= =?iso-8859-1?Q?wcfc2x8AOs9dq43ys+nOV4b+WyJseuek+hH0SYSEGJfmt/ikH4bgjDgGgD?= =?iso-8859-1?Q?Ck6+0tj53tPCgFfpKX/MBGSPNHBejrWUzat6YcM706cH22WJLRbbNIDhNX?= =?iso-8859-1?Q?nCZdPTdohcv8l+D7xrE2/RBFVOGI6reYy+Q37DtUi5C5KBxpk6WOugtLNJ?= =?iso-8859-1?Q?UNBzswyRjcXq/Nesk287GA1NvE0zT+w7q9V8rYb7bXoKNgbcNj/Z/iSgkL?= =?iso-8859-1?Q?D7eJ0XtOVcmMMMMclabk8GoejsSRj1j1lPKS/ppXKul1PMc4HteCmSHIuD?= =?iso-8859-1?Q?w7qzAYJBuOyN2eX9HbGUkTI8e5pQUtxng7f8Ibc2Y6d5luzRpfVzM0D8Vo?= =?iso-8859-1?Q?Ufo+A5LBnG6Q62IXVYxSvPZoMILXfNhW8CsmSarie4zP+deCMXPwrzQ0ZX?= =?iso-8859-1?Q?yMeMiHQ0JXdOpv5FhJjt+LEP0fyglrUQ4NBzxFRxO6C8Bd1jRYYFi+ipGm?= =?iso-8859-1?Q?fa0FAB8EpLlWRvuU8lXj/mmrKoYbea7EY89Lq4yI7cQwaziWZdn6TrF9g6?= =?iso-8859-1?Q?7MT0mQPD7QRizhhcLSmAnmZlN1ODmDY7hRKUzJ1TqUOKYa87wPF25MRl4f?= =?iso-8859-1?Q?0/6m8pO0dFsj1MhbHfWXbMVZ0goo1f9ZFtcviegJvI3KCu9olfEq1I9pf2?= =?iso-8859-1?Q?7Lw1pnAXoA9ao6auMRbqT6onkYg4HXfcGtBH6WxXVNvbL1ZSj/rui6xZIR?= =?iso-8859-1?Q?lADO1WocGAfkdJrpK7NqHDTj/pCcsYOKcalp4vhFkbKfTwaBuT8YNt25RJ?= =?iso-8859-1?Q?5L7f4a5COTdKBDHFSxyMSMBhYs6B1dylojWn+VIRvW7nbTWKNVNWxlT2ba?= =?iso-8859-1?Q?7ZZ58JsUe943Bnk3b/+19i0QBssG3eO?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB1929;6:7ZrcRB14nT8Q+dECQpstOVNoKxBEsO961EWO7FHHQqgifL8fFttaKX7KwNnH/TEzTeKBIUhZB1d7ZdD+zdZWqCtpgf0LfInJ3cPby7GGsll7hXXWY6bHNxA/y3JaDYW3KP5dxdlVxF7XprpyryP7Rhm4/P/97m+b1JJ8btaapUCoxrdGrC9W6bFOloa1K6MDu4x8QnRUDquT/Vtn6NbuFDK3lY6XnYFAk9XuQUH4BjWkjg7GubP7+Idfd34K53lu2h2N+CWhgz5F0JKlFndrVSudFxxp0sJJKP+DUrPBVl53h7r66yvM7Y34W+oP1Ycx;5:b8BxPeuduShRU/X5UymWZUI87BNKDXTwbG2TAN44BhOoX/89tT+c8xfCeeoSDuCVmK3RnkmpS1PL6NyZC5IqvwsnZxENqq2xZ0AtAIltLaPZLVLu0gzH4n2ySt8XtueQ2Qm4P3T3RYurCab3IeRfrA==;24:WHQFGmiIdBYocBEIMyxRt0cRpmwHJMrI7S52gvsP2Abzxrb+zNDjOYtAQPthTlXNV7iEJpgMgg6oQQqc3At+X+mIwh6U3suspPsXjUVVGeQ=;7:sft3veuYHHNgug+/bjZXac+w3b3ykwK+CW7oCyNFNs/EMerLItjwhjww8hf/f6TbSrfb6Y2pvtKilv8v5BB6vchZBDUlCRsHPyQg2Uw2XhdP9z26AmZy7vYOMtMJbX7UI4rxG2KpdU7KHVgPTSa1obDzE9GMp4i9Bpvl/KKEVyw9CsHWHSZJ4Fq9yO6JueaHRYZn/wpnaCnAKXjEMEOy3ZFzJF7zBr6hcSDPT4Uo/Cs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 04:38:53.5396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB1929 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --X+8siUETKMkW99st Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 01, 2017 at 03:30:42PM -0400, J=E9r=E9my Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: J=E9r=E9my Lefaure > --- > drivers/infiniband/hw/mlx5/odp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Thanks J=E9r=E9my, I took this into my tree and will forward it to Doug L. during this cycle. --X+8siUETKMkW99st Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnRwtgACgkQ5GN7iDZy WKc+tQ/+KtPpL6Dj0TaoRD1f4TDbV4OpVrhSkPX45R4zcWHWe/Z0Y4yYyYC2YLdQ nlYPfONpJjwRBLenm/J9UE+6s7GQmR+TW+NY1m6CXdcc7xyC4wBk9+sF6TPIEwaQ fI6WQSiRTAJke1Rz49BFQ9/SIv6AJXW8xJMILiR61TUgomOQC9zthRN+mRronRlc cA9PxYNfquOZ85kHSU1qiM9NDz1zqhvhYGSPy1YfnatWmjhQ/Iq0Jz8Xe9ZD5hFd y3I4ePg7S7XOJuUoqh7gE/zZPSLmOm/KV0CJEdlCqpU3EfWmJpTE3NYpjCAw0G91 erdG5EW1zq2wFsTLo3BZww5hJZ7hOOFbdO1hBhCNcOYlN87n04rhLHIPMykXlowf WJC9HVPYnzEHYLVlXf3r/3JpGBc8HBqu3iLfQ890rM4qDXd3wYp1oQeefRixoBoj uABauGtowXTxgRt4gMg0gC/hkeW3ZVUiRs+LBwi19rvSKaqGhvAtMR8Ge2TX30cV ddJaoW1oXUa5FuWr9OdZ0czbBr76JHkwBxuKq9isQK7jaFFdFNc/jE4dq7A7brzG LklQWs9qlhSN6D3S0VQi7zCnY/5VjRXNh+RwMLGdadl/xB1Z5A+EnJTz9sswvzfc VcY2nIXUyJScCQ1knWgaX4heRbrLD2UqOQt68X/oGOj3E6nDVsU= =Tp+2 -----END PGP SIGNATURE----- --X+8siUETKMkW99st--