* [PATCH 00/18] use ARRAY_SIZE macro
@ 2017-10-01 19:30 Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure
` (18 more replies)
0 siblings, 19 replies; 51+ messages in thread
From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw)
Cc: alsa-devel, amd-gfx, brcm80211-dev-list, brcm80211-dev-list.pdl,
devel, devel, dm-devel, dri-devel, ecryptfs, intel-gfx,
intel-gvt-dev, intel-wired-lan, Jason Gunthorpe, linux-acpi,
linux-integrity, linux-kernel, linux-media, linux-nfs, linux-raid,
linux-rdma, linux-scsi, linux-usb, linux-video, linux-wireless,
netdev, nouveau, openipmi-developer
Hi everyone,
Using ARRAY_SIZE improves the code readability. I used coccinelle (I
made a change to the array_size.cocci file [1]) to find several places
where ARRAY_SIZE could be used instead of other macros or sizeof
division.
I tried to divide the changes into a patch per subsystem (excepted for
staging). If one of the patch should be split into several patches, let
me know.
In order to reduce the size of the To: and Cc: lines, each patch of the
series is sent only to the maintainers and lists concerned by the patch.
This cover letter is sent to every list concerned by this series.
This series is based on linux-next next-20170929. Each patch has been
tested by building the relevant files with W=1.
This series contains the following patches:
[PATCH 01/18] sound: use ARRAY_SIZE
[PATCH 02/18] tracing/filter: use ARRAY_SIZE
[PATCH 03/18] media: use ARRAY_SIZE
[PATCH 04/18] IB/mlx5: Use ARRAY_SIZE
[PATCH 05/18] net: use ARRAY_SIZE
[PATCH 06/18] drm: use ARRAY_SIZE
[PATCH 07/18] scsi: bfa: use ARRAY_SIZE
[PATCH 08/18] ecryptfs: use ARRAY_SIZE
[PATCH 09/18] nfsd: use ARRAY_SIZE
[PATCH 10/18] orangefs: use ARRAY_SIZE
[PATCH 11/18] dm space map metadata: use ARRAY_SIZE
[PATCH 12/18] x86: use ARRAY_SIZE
[PATCH 13/18] tpm: use ARRAY_SIZE
[PATCH 14/18] ipmi: use ARRAY_SIZE
[PATCH 15/18] acpi: use ARRAY_SIZE
[PATCH 16/18] media: staging: atomisp: use ARRAY_SIZE
[PATCH 17/18] staging: rtl8723bs: use ARRAY_SIZE
[PATCH 18/18] staging: rtlwifi: use ARRAY_SIZE
[1]: https://lkml.org/lkml/2017/9/13/689
^ permalink raw reply [flat|nested] 51+ messages in thread* [PATCH 01/18] sound: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 4:16 ` Joe Perches 2017-10-03 7:03 ` Takashi Iwai 2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure ` (17 subsequent siblings) 18 siblings, 2 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai Cc: Jérémy Lefaure, alsa-devel, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- sound/oss/ad1848.c | 7 ++++--- sound/pci/hda/patch_ca0132.c | 8 +++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c index 2421f59cf279..7e495054b51c 100644 --- a/sound/oss/ad1848.c +++ b/sound/oss/ad1848.c @@ -49,6 +49,7 @@ #include <linux/isapnp.h> #include <linux/pnp.h> #include <linux/spinlock.h> +#include <linux/kernel.h> #include "sound_config.h" @@ -797,7 +798,7 @@ static int ad1848_set_speed(int dev, int arg) int i, n, selected = -1; - n = sizeof(speed_table) / sizeof(speed_struct); + n = ARRAY_SIZE(speed_table); if (arg <= 0) return portc->speed; @@ -908,7 +909,7 @@ static unsigned int ad1848_set_bits(int dev, unsigned int arg) AFMT_U16_BE, 0 } }; - int i, n = sizeof(format2bits) / sizeof(struct format_tbl); + int i; if (arg == 0) return portc->audio_format; @@ -918,7 +919,7 @@ static unsigned int ad1848_set_bits(int dev, unsigned int arg) portc->audio_format = arg; - for (i = 0; i < n; i++) + for (i = 0; i < ARRAY_SIZE(format2bits); i++) if (format2bits[i].format == arg) { if ((portc->format_bits = format2bits[i].bits) == 0) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 3e73d5c6ccfc..768ea8651993 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -27,6 +27,7 @@ #include <linux/mutex.h> #include <linux/module.h> #include <linux/firmware.h> +#include <linux/kernel.h> #include <sound/core.h> #include "hda_codec.h" #include "hda_local.h" @@ -3605,8 +3606,7 @@ static int ca0132_vnode_switch_set(struct snd_kcontrol *kcontrol, static int ca0132_voicefx_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo) { - unsigned int items = sizeof(ca0132_voicefx_presets) - / sizeof(struct ct_voicefx_preset); + unsigned int items = ARRAY_SIZE(ca0132_voicefx_presets); uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED; uinfo->count = 1; @@ -3635,10 +3635,8 @@ static int ca0132_voicefx_put(struct snd_kcontrol *kcontrol, struct ca0132_spec *spec = codec->spec; int i, err = 0; int sel = ucontrol->value.enumerated.item[0]; - unsigned int items = sizeof(ca0132_voicefx_presets) - / sizeof(struct ct_voicefx_preset); - if (sel >= items) + if (sel >= ARRAY_SIZE(ca0132_voicefx_presets)) return 0; codec_dbg(codec, "ca0132_voicefx_put: sel=%d, preset=%s\n", -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 01/18] sound: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-02 4:16 ` Joe Perches 2017-10-03 1:12 ` Jérémy Lefaure 2017-10-03 7:03 ` Takashi Iwai 1 sibling, 1 reply; 51+ messages in thread From: Joe Perches @ 2017-10-02 4:16 UTC (permalink / raw) To: Jérémy Lefaure, Jaroslav Kysela, Takashi Iwai Cc: alsa-devel, linux-kernel On Sun, 2017-10-01 at 15:30 -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > > > > (sizeof(E)@p /sizeof(E[...])) > > > > (sizeof(E)@p /sizeof(T)) > ) [] > diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c [] > @@ -797,7 +798,7 @@ static int ad1848_set_speed(int dev, int arg) > > int i, n, selected = -1; > > - n = sizeof(speed_table) / sizeof(speed_struct); > + n = ARRAY_SIZE(speed_table); These sorts of changes are OK, but for many uses, it's more readable to use ARRAY_SIZE(foo) in each location rather than using a temporary. ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 01/18] sound: use ARRAY_SIZE 2017-10-02 4:16 ` Joe Perches @ 2017-10-03 1:12 ` Jérémy Lefaure 0 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-03 1:12 UTC (permalink / raw) To: Joe Perches; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel On Sun, 01 Oct 2017 21:16:19 -0700 Joe Perches <joe@perches.com> wrote: > These sorts of changes are OK, but for many > uses, it's more readable to use ARRAY_SIZE(foo) > in each location rather than using a temporary. You're right, I missed that one. I will send a v2. Thank you for your review, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 01/18] sound: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure 2017-10-02 4:16 ` Joe Perches @ 2017-10-03 7:03 ` Takashi Iwai 1 sibling, 0 replies; 51+ messages in thread From: Takashi Iwai @ 2017-10-03 7:03 UTC (permalink / raw) To: Jérémy Lefaure; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel On Sun, 01 Oct 2017 21:30:39 +0200, Jérémy Lefaure wrote: > > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > sound/oss/ad1848.c | 7 ++++--- > sound/pci/hda/patch_ca0132.c | 8 +++----- > 2 files changed, 7 insertions(+), 8 deletions(-) sound/oss is already dead and will be removed likely in the next release. So just keep it untouched. thanks, Takashi ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 02/18] tracing/filter: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-04 1:05 ` Steven Rostedt 2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure ` (16 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Steven Rostedt, Ingo Molnar; +Cc: Jérémy Lefaure, linux-kernel It is useless to re-invent the ARRAY_SIZE macro so let's use it instead of DATA_CNT. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- kernel/trace/trace_events_filter.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 61e7f0678d33..02d0f378dc5c 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -23,6 +23,7 @@ #include <linux/mutex.h> #include <linux/perf_event.h> #include <linux/slab.h> +#include <linux/kernel.h> #include "trace.h" #include "trace_output.h" @@ -2376,8 +2377,6 @@ static struct test_filter_data_t { #undef YES #undef NO -#define DATA_CNT (sizeof(test_filter_data)/sizeof(struct test_filter_data_t)) - static int test_pred_visited; static int test_pred_visited_fn(struct filter_pred *pred, void *event) @@ -2417,7 +2416,7 @@ static __init int ftrace_test_event_filter(void) printk(KERN_INFO "Testing ftrace filter: "); - for (i = 0; i < DATA_CNT; i++) { + for (i = 0; i < ARRAY_SIZE(test_filter_data); i++) { struct event_filter *filter = NULL; struct test_filter_data_t *d = &test_filter_data[i]; int err; @@ -2463,7 +2462,7 @@ static __init int ftrace_test_event_filter(void) } } - if (i == DATA_CNT) + if (i == ARRAY_SIZE(test_filter_data)) printk(KERN_CONT "OK\n"); return 0; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 02/18] tracing/filter: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure @ 2017-10-04 1:05 ` Steven Rostedt 0 siblings, 0 replies; 51+ messages in thread From: Steven Rostedt @ 2017-10-04 1:05 UTC (permalink / raw) To: Jérémy Lefaure; +Cc: Ingo Molnar, linux-kernel On Sun, 1 Oct 2017 15:30:40 -0400 Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > It is useless to re-invent the ARRAY_SIZE macro so let's use it instead > of DATA_CNT. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > kernel/trace/trace_events_filter.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 61e7f0678d33..02d0f378dc5c 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -23,6 +23,7 @@ > #include <linux/mutex.h> > #include <linux/perf_event.h> > #include <linux/slab.h> > +#include <linux/kernel.h> > > #include "trace.h" > #include "trace_output.h" > @@ -2376,8 +2377,6 @@ static struct test_filter_data_t { > #undef YES > #undef NO > > -#define DATA_CNT (sizeof(test_filter_data)/sizeof(struct test_filter_data_t)) Just change DATA_CNT to be: #define DATA_CNT ARRAY_SIZE(test_filter_data) and don't change the rest. -- Steve > - > static int test_pred_visited; > > static int test_pred_visited_fn(struct filter_pred *pred, void *event) > @@ -2417,7 +2416,7 @@ static __init int ftrace_test_event_filter(void) > > printk(KERN_INFO "Testing ftrace filter: "); > > - for (i = 0; i < DATA_CNT; i++) { > + for (i = 0; i < ARRAY_SIZE(test_filter_data); i++) { > struct event_filter *filter = NULL; > struct test_filter_data_t *d = &test_filter_data[i]; > int err; > @@ -2463,7 +2462,7 @@ static __init int ftrace_test_event_filter(void) > } > } > > - if (i == DATA_CNT) > + if (i == ARRAY_SIZE(test_filter_data)) > printk(KERN_CONT "OK\n"); > > return 0; ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 03/18] media: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 10:34 ` Michael Ira Krufky 2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure ` (15 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Hans Verkuil, Mauro Carvalho Chehab, Sergey Kozlov, Abylay Ospan, Michael Krufky Cc: Jérémy Lefaure, linux-media, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/media/common/saa7146/saa7146_video.c | 9 ++++----- drivers/media/dvb-frontends/cxd2841er.c | 7 +++---- drivers/media/pci/saa7146/hexium_gemini.c | 3 ++- drivers/media/pci/saa7146/hexium_orion.c | 3 ++- drivers/media/pci/saa7146/mxb.c | 3 ++- drivers/media/usb/dvb-usb/cxusb.c | 3 ++- drivers/media/usb/dvb-usb/friio-fe.c | 5 ++--- 7 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/media/common/saa7146/saa7146_video.c b/drivers/media/common/saa7146/saa7146_video.c index 37b4654dc21c..612aefd804f0 100644 --- a/drivers/media/common/saa7146/saa7146_video.c +++ b/drivers/media/common/saa7146/saa7146_video.c @@ -4,6 +4,7 @@ #include <media/v4l2-event.h> #include <media/v4l2-ctrls.h> #include <linux/module.h> +#include <linux/kernel.h> static int max_memory = 32; @@ -86,13 +87,11 @@ static struct saa7146_format formats[] = { due to this, it's impossible to provide additional *packed* formats, which are simply byte swapped (like V4L2_PIX_FMT_YUYV) ... 8-( */ -static int NUM_FORMATS = sizeof(formats)/sizeof(struct saa7146_format); - struct saa7146_format* saa7146_format_by_fourcc(struct saa7146_dev *dev, int fourcc) { - int i, j = NUM_FORMATS; + int i; - for (i = 0; i < j; i++) { + for (i = 0; i < ARRAY_SIZE(formats); i++) { if (formats[i].pixelformat == fourcc) { return formats+i; } @@ -524,7 +523,7 @@ static int vidioc_s_fbuf(struct file *file, void *fh, const struct v4l2_framebuf static int vidioc_enum_fmt_vid_cap(struct file *file, void *fh, struct v4l2_fmtdesc *f) { - if (f->index >= NUM_FORMATS) + if (f->index >= ARRAY_SIZE(formats)) return -EINVAL; strlcpy((char *)f->description, formats[f->index].name, sizeof(f->description)); diff --git a/drivers/media/dvb-frontends/cxd2841er.c b/drivers/media/dvb-frontends/cxd2841er.c index 48ee9bc00c06..2cb97a3130be 100644 --- a/drivers/media/dvb-frontends/cxd2841er.c +++ b/drivers/media/dvb-frontends/cxd2841er.c @@ -29,6 +29,7 @@ #include <linux/math64.h> #include <linux/log2.h> #include <linux/dynamic_debug.h> +#include <linux/kernel.h> #include "dvb_math.h" #include "dvb_frontend.h" @@ -1696,12 +1697,10 @@ static u32 cxd2841er_dvbs_read_snr(struct cxd2841er_priv *priv, min_index = 0; if (delsys == SYS_DVBS) { cn_data = s_cn_data; - max_index = sizeof(s_cn_data) / - sizeof(s_cn_data[0]) - 1; + max_index = ARRAY_SIZE(s_cn_data) - 1; } else { cn_data = s2_cn_data; - max_index = sizeof(s2_cn_data) / - sizeof(s2_cn_data[0]) - 1; + max_index = ARRAY_SIZE(s2_cn_data) - 1; } if (value >= cn_data[min_index].value) { res = cn_data[min_index].cnr_x1000; diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c index d31a2d4494d1..39357eddee32 100644 --- a/drivers/media/pci/saa7146/hexium_gemini.c +++ b/drivers/media/pci/saa7146/hexium_gemini.c @@ -27,6 +27,7 @@ #include <media/drv-intf/saa7146_vv.h> #include <linux/module.h> +#include <linux/kernel.h> static int debug; module_param(debug, int, 0); @@ -388,7 +389,7 @@ static struct saa7146_ext_vv vv_data = { .inputs = HEXIUM_INPUTS, .capabilities = 0, .stds = &hexium_standards[0], - .num_stds = sizeof(hexium_standards) / sizeof(struct saa7146_standard), + .num_stds = ARRAY_SIZE(hexium_standards), .std_callback = &std_callback, }; diff --git a/drivers/media/pci/saa7146/hexium_orion.c b/drivers/media/pci/saa7146/hexium_orion.c index 043318aa19e2..461e421080f3 100644 --- a/drivers/media/pci/saa7146/hexium_orion.c +++ b/drivers/media/pci/saa7146/hexium_orion.c @@ -27,6 +27,7 @@ #include <media/drv-intf/saa7146_vv.h> #include <linux/module.h> +#include <linux/kernel.h> static int debug; module_param(debug, int, 0); @@ -460,7 +461,7 @@ static struct saa7146_ext_vv vv_data = { .inputs = HEXIUM_INPUTS, .capabilities = 0, .stds = &hexium_standards[0], - .num_stds = sizeof(hexium_standards) / sizeof(struct saa7146_standard), + .num_stds = ARRAY_SIZE(hexium_standards), .std_callback = &std_callback, }; diff --git a/drivers/media/pci/saa7146/mxb.c b/drivers/media/pci/saa7146/mxb.c index 930218cc2de1..0144f305ea24 100644 --- a/drivers/media/pci/saa7146/mxb.c +++ b/drivers/media/pci/saa7146/mxb.c @@ -30,6 +30,7 @@ #include <media/v4l2-common.h> #include <media/i2c/saa7115.h> #include <linux/module.h> +#include <linux/kernel.h> #include "tea6415c.h" #include "tea6420.h" @@ -837,7 +838,7 @@ static struct saa7146_ext_vv vv_data = { .inputs = MXB_INPUTS, .capabilities = V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE | V4L2_CAP_AUDIO, .stds = &standard[0], - .num_stds = sizeof(standard)/sizeof(struct saa7146_standard), + .num_stds = ARRAY_SIZE(standard), .std_callback = &std_callback, }; diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index 37dea0adc695..9b486bb5004d 100644 --- a/drivers/media/usb/dvb-usb/cxusb.c +++ b/drivers/media/usb/dvb-usb/cxusb.c @@ -26,6 +26,7 @@ #include <media/tuner.h> #include <linux/vmalloc.h> #include <linux/slab.h> +#include <linux/kernel.h> #include "cxusb.h" @@ -303,7 +304,7 @@ static int cxusb_aver_power_ctrl(struct dvb_usb_device *d, int onoff) 0x0e, 0x2, 0x47, 0x88, }; msleep(20); - for (i = 0; i < sizeof(bufs)/sizeof(u8); i += 4/sizeof(u8)) { + for (i = 0; i < ARRAY_SIZE(bufs); i += 4 / sizeof(u8)) { ret = cxusb_ctrl_msg(d, CMD_I2C_WRITE, bufs+i, 4, &buf, 1); if (ret) diff --git a/drivers/media/usb/dvb-usb/friio-fe.c b/drivers/media/usb/dvb-usb/friio-fe.c index 0251a4e91d47..a6c84a4390d1 100644 --- a/drivers/media/usb/dvb-usb/friio-fe.c +++ b/drivers/media/usb/dvb-usb/friio-fe.c @@ -13,6 +13,7 @@ #include <linux/init.h> #include <linux/string.h> #include <linux/slab.h> +#include <linux/kernel.h> #include "friio.h" @@ -362,8 +363,6 @@ static u8 init_code[][2] = { {0x76, 0x0C}, }; -static const int init_code_len = sizeof(init_code) / sizeof(u8[2]); - static int jdvbt90502_init(struct dvb_frontend *fe) { int i = -1; @@ -377,7 +376,7 @@ static int jdvbt90502_init(struct dvb_frontend *fe) msg.addr = state->config.demod_address; msg.flags = 0; msg.len = 2; - for (i = 0; i < init_code_len; i++) { + for (i = 0; i < ARRAY_SIZE(init_code); i++) { msg.buf = init_code[i]; ret = i2c_transfer(state->i2c, &msg, 1); if (ret != 1) -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 03/18] media: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure @ 2017-10-02 10:34 ` Michael Ira Krufky 0 siblings, 0 replies; 51+ messages in thread From: Michael Ira Krufky @ 2017-10-02 10:34 UTC (permalink / raw) To: Jérémy Lefaure Cc: Hans Verkuil, Mauro Carvalho Chehab, Sergey Kozlov, Abylay Ospan, linux-media, LKML On Sun, Oct 1, 2017 at 3:30 PM, Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Reviewed-by: Michael Ira Krufky <mkrufky@linuxtv.org> > --- > drivers/media/common/saa7146/saa7146_video.c | 9 ++++----- > drivers/media/dvb-frontends/cxd2841er.c | 7 +++---- > drivers/media/pci/saa7146/hexium_gemini.c | 3 ++- > drivers/media/pci/saa7146/hexium_orion.c | 3 ++- > drivers/media/pci/saa7146/mxb.c | 3 ++- > drivers/media/usb/dvb-usb/cxusb.c | 3 ++- > drivers/media/usb/dvb-usb/friio-fe.c | 5 ++--- > 7 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/common/saa7146/saa7146_video.c b/drivers/media/common/saa7146/saa7146_video.c > index 37b4654dc21c..612aefd804f0 100644 > --- a/drivers/media/common/saa7146/saa7146_video.c > +++ b/drivers/media/common/saa7146/saa7146_video.c > @@ -4,6 +4,7 @@ > #include <media/v4l2-event.h> > #include <media/v4l2-ctrls.h> > #include <linux/module.h> > +#include <linux/kernel.h> > > static int max_memory = 32; > > @@ -86,13 +87,11 @@ static struct saa7146_format formats[] = { > due to this, it's impossible to provide additional *packed* formats, which are simply byte swapped > (like V4L2_PIX_FMT_YUYV) ... 8-( */ > > -static int NUM_FORMATS = sizeof(formats)/sizeof(struct saa7146_format); > - > struct saa7146_format* saa7146_format_by_fourcc(struct saa7146_dev *dev, int fourcc) > { > - int i, j = NUM_FORMATS; > + int i; > > - for (i = 0; i < j; i++) { > + for (i = 0; i < ARRAY_SIZE(formats); i++) { > if (formats[i].pixelformat == fourcc) { > return formats+i; > } > @@ -524,7 +523,7 @@ static int vidioc_s_fbuf(struct file *file, void *fh, const struct v4l2_framebuf > > static int vidioc_enum_fmt_vid_cap(struct file *file, void *fh, struct v4l2_fmtdesc *f) > { > - if (f->index >= NUM_FORMATS) > + if (f->index >= ARRAY_SIZE(formats)) > return -EINVAL; > strlcpy((char *)f->description, formats[f->index].name, > sizeof(f->description)); > diff --git a/drivers/media/dvb-frontends/cxd2841er.c b/drivers/media/dvb-frontends/cxd2841er.c > index 48ee9bc00c06..2cb97a3130be 100644 > --- a/drivers/media/dvb-frontends/cxd2841er.c > +++ b/drivers/media/dvb-frontends/cxd2841er.c > @@ -29,6 +29,7 @@ > #include <linux/math64.h> > #include <linux/log2.h> > #include <linux/dynamic_debug.h> > +#include <linux/kernel.h> > > #include "dvb_math.h" > #include "dvb_frontend.h" > @@ -1696,12 +1697,10 @@ static u32 cxd2841er_dvbs_read_snr(struct cxd2841er_priv *priv, > min_index = 0; > if (delsys == SYS_DVBS) { > cn_data = s_cn_data; > - max_index = sizeof(s_cn_data) / > - sizeof(s_cn_data[0]) - 1; > + max_index = ARRAY_SIZE(s_cn_data) - 1; > } else { > cn_data = s2_cn_data; > - max_index = sizeof(s2_cn_data) / > - sizeof(s2_cn_data[0]) - 1; > + max_index = ARRAY_SIZE(s2_cn_data) - 1; > } > if (value >= cn_data[min_index].value) { > res = cn_data[min_index].cnr_x1000; > diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c > index d31a2d4494d1..39357eddee32 100644 > --- a/drivers/media/pci/saa7146/hexium_gemini.c > +++ b/drivers/media/pci/saa7146/hexium_gemini.c > @@ -27,6 +27,7 @@ > > #include <media/drv-intf/saa7146_vv.h> > #include <linux/module.h> > +#include <linux/kernel.h> > > static int debug; > module_param(debug, int, 0); > @@ -388,7 +389,7 @@ static struct saa7146_ext_vv vv_data = { > .inputs = HEXIUM_INPUTS, > .capabilities = 0, > .stds = &hexium_standards[0], > - .num_stds = sizeof(hexium_standards) / sizeof(struct saa7146_standard), > + .num_stds = ARRAY_SIZE(hexium_standards), > .std_callback = &std_callback, > }; > > diff --git a/drivers/media/pci/saa7146/hexium_orion.c b/drivers/media/pci/saa7146/hexium_orion.c > index 043318aa19e2..461e421080f3 100644 > --- a/drivers/media/pci/saa7146/hexium_orion.c > +++ b/drivers/media/pci/saa7146/hexium_orion.c > @@ -27,6 +27,7 @@ > > #include <media/drv-intf/saa7146_vv.h> > #include <linux/module.h> > +#include <linux/kernel.h> > > static int debug; > module_param(debug, int, 0); > @@ -460,7 +461,7 @@ static struct saa7146_ext_vv vv_data = { > .inputs = HEXIUM_INPUTS, > .capabilities = 0, > .stds = &hexium_standards[0], > - .num_stds = sizeof(hexium_standards) / sizeof(struct saa7146_standard), > + .num_stds = ARRAY_SIZE(hexium_standards), > .std_callback = &std_callback, > }; > > diff --git a/drivers/media/pci/saa7146/mxb.c b/drivers/media/pci/saa7146/mxb.c > index 930218cc2de1..0144f305ea24 100644 > --- a/drivers/media/pci/saa7146/mxb.c > +++ b/drivers/media/pci/saa7146/mxb.c > @@ -30,6 +30,7 @@ > #include <media/v4l2-common.h> > #include <media/i2c/saa7115.h> > #include <linux/module.h> > +#include <linux/kernel.h> > > #include "tea6415c.h" > #include "tea6420.h" > @@ -837,7 +838,7 @@ static struct saa7146_ext_vv vv_data = { > .inputs = MXB_INPUTS, > .capabilities = V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE | V4L2_CAP_AUDIO, > .stds = &standard[0], > - .num_stds = sizeof(standard)/sizeof(struct saa7146_standard), > + .num_stds = ARRAY_SIZE(standard), > .std_callback = &std_callback, > }; > > diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c > index 37dea0adc695..9b486bb5004d 100644 > --- a/drivers/media/usb/dvb-usb/cxusb.c > +++ b/drivers/media/usb/dvb-usb/cxusb.c > @@ -26,6 +26,7 @@ > #include <media/tuner.h> > #include <linux/vmalloc.h> > #include <linux/slab.h> > +#include <linux/kernel.h> > > #include "cxusb.h" > > @@ -303,7 +304,7 @@ static int cxusb_aver_power_ctrl(struct dvb_usb_device *d, int onoff) > 0x0e, 0x2, 0x47, 0x88, > }; > msleep(20); > - for (i = 0; i < sizeof(bufs)/sizeof(u8); i += 4/sizeof(u8)) { > + for (i = 0; i < ARRAY_SIZE(bufs); i += 4 / sizeof(u8)) { > ret = cxusb_ctrl_msg(d, CMD_I2C_WRITE, > bufs+i, 4, &buf, 1); > if (ret) > diff --git a/drivers/media/usb/dvb-usb/friio-fe.c b/drivers/media/usb/dvb-usb/friio-fe.c > index 0251a4e91d47..a6c84a4390d1 100644 > --- a/drivers/media/usb/dvb-usb/friio-fe.c > +++ b/drivers/media/usb/dvb-usb/friio-fe.c > @@ -13,6 +13,7 @@ > #include <linux/init.h> > #include <linux/string.h> > #include <linux/slab.h> > +#include <linux/kernel.h> > > #include "friio.h" > > @@ -362,8 +363,6 @@ static u8 init_code[][2] = { > {0x76, 0x0C}, > }; > > -static const int init_code_len = sizeof(init_code) / sizeof(u8[2]); > - > static int jdvbt90502_init(struct dvb_frontend *fe) > { > int i = -1; > @@ -377,7 +376,7 @@ static int jdvbt90502_init(struct dvb_frontend *fe) > msg.addr = state->config.demod_address; > msg.flags = 0; > msg.len = 2; > - for (i = 0; i < init_code_len; i++) { > + for (i = 0; i < ARRAY_SIZE(init_code); i++) { > msg.buf = init_code[i]; > ret = i2c_transfer(state->i2c, &msg, 1); > if (ret != 1) > -- > 2.14.1 > ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (2 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 4:38 ` Leon Romanovsky 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure ` (14 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Matan Barak, Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock Cc: Jérémy Lefaure, linux-rdma, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/infiniband/hw/mlx5/odp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c index 3d701c7a4c91..e2197bdda89c 100644 --- a/drivers/infiniband/hw/mlx5/odp.c +++ b/drivers/infiniband/hw/mlx5/odp.c @@ -32,6 +32,7 @@ #include <rdma/ib_umem.h> #include <rdma/ib_umem_odp.h> +#include <linux/kernel.h> #include "mlx5_ib.h" #include "cmd.h" @@ -929,9 +930,8 @@ static int mlx5_ib_mr_initiator_pfault_handler( return -EFAULT; } - if (unlikely(opcode >= sizeof(mlx5_ib_odp_opcode_cap) / - sizeof(mlx5_ib_odp_opcode_cap[0]) || - !(transport_caps & mlx5_ib_odp_opcode_cap[opcode]))) { + if (unlikely(opcode >= ARRAY_SIZE(mlx5_ib_odp_opcode_cap) || + !(transport_caps & mlx5_ib_odp_opcode_cap[opcode]))) { mlx5_ib_err(dev, "ODP fault on QP of an unsupported opcode 0x%x\n", opcode); return -EFAULT; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure @ 2017-10-02 4:38 ` Leon Romanovsky 0 siblings, 0 replies; 51+ messages in thread From: Leon Romanovsky @ 2017-10-02 4:38 UTC (permalink / raw) To: Jérémy Lefaure Cc: Matan Barak, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, linux-kernel [-- Attachment #1: Type: text/plain, Size: 656 bytes --] On Sun, Oct 01, 2017 at 03:30:42PM -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > drivers/infiniband/hw/mlx5/odp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Thanks Jérémy, I took this into my tree and will forward it to Doug L. during this cycle. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 05/18] net: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (3 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 13:07 ` Andy Shevchenko 2017-10-02 13:46 ` Kalle Valo 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure ` (13 subsequent siblings) 18 siblings, 2 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Kalle Valo, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI Cc: Jérémy Lefaure, netdev, linux-kernel, intel-wired-lan, linux-usb, linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/net/ethernet/emulex/benet/be_cmds.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 3 +- drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 3 +- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +- drivers/net/ethernet/intel/ixgbevf/vf.c | 17 +- drivers/net/usb/kalmia.c | 9 +- .../broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 473 ++++++--------------- .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 9 +- .../net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 12 +- .../net/wireless/realtek/rtlwifi/rtl8723be/table.c | 14 +- .../net/wireless/realtek/rtlwifi/rtl8821ae/table.c | 34 +- include/net/bond_3ad.h | 3 +- net/ipv6/seg6_local.c | 6 +- 13 files changed, 177 insertions(+), 413 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index 02dd5246dfae..ec39363afd5f 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.c +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c @@ -15,6 +15,7 @@ * Costa Mesa, CA 92626 */ +#include <linux/kernel.h> #include <linux/module.h> #include "be.h" #include "be_cmds.h" @@ -103,10 +104,9 @@ static struct be_cmd_priv_map cmd_priv_map[] = { static bool be_cmd_allowed(struct be_adapter *adapter, u8 opcode, u8 subsystem) { int i; - int num_entries = sizeof(cmd_priv_map)/sizeof(struct be_cmd_priv_map); u32 cmd_privileges = adapter->cmd_privileges; - for (i = 0; i < num_entries; i++) + for (i = 0; i < ARRAY_SIZE(cmd_priv_map); i++) if (opcode == cmd_priv_map[i].opcode && subsystem == cmd_priv_map[i].subsystem) if (!(cmd_privileges & cmd_priv_map[i].priv_mask)) diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h b/drivers/net/ethernet/intel/i40e/i40e_adminq.h index 2349fbe04bd2..892083b65b91 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h @@ -27,6 +27,7 @@ #ifndef _I40E_ADMINQ_H_ #define _I40E_ADMINQ_H_ +#include <linux/kernel.h> #include "i40e_osdep.h" #include "i40e_status.h" #include "i40e_adminq_cmd.h" @@ -143,7 +144,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) if (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT) return -EAGAIN; - if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) + if (!((u32)aq_rc < ARRAY_SIZE(aq_to_posix))) return -ERANGE; return aq_to_posix[aq_rc]; diff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h index e0bfaa3d4a21..5622a24cc74d 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h +++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h @@ -27,6 +27,7 @@ #ifndef _I40E_ADMINQ_H_ #define _I40E_ADMINQ_H_ +#include <linux/kernel.h> #include "i40e_osdep.h" #include "i40e_status.h" #include "i40e_adminq_cmd.h" @@ -143,7 +144,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) if (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT) return -EAGAIN; - if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) + if (!((u32)aq_rc < ARRAY_SIZE(aq_to_posix))) return -ERANGE; return aq_to_posix[aq_rc]; diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c index 19fbb2f28ea4..9cfc8601fb54 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c @@ -21,6 +21,7 @@ * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 * ******************************************************************************/ +#include <linux/kernel.h> #include "ixgbe_x540.h" #include "ixgbe_type.h" #include "ixgbe_common.h" @@ -947,7 +948,7 @@ static s32 ixgbe_checksum_ptr_x550(struct ixgbe_hw *hw, u16 ptr, u16 length, bufsz, i, start; u16 *local_buffer; - bufsz = sizeof(buf) / sizeof(buf[0]); + bufsz = ARRAY_SIZE(buf); /* Read a chunk at the pointer location */ if (!buffer) { diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c index 0c25006ce9af..96bfef92fb4c 100644 --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -24,6 +24,7 @@ *******************************************************************************/ +#include <linux/kernel.h> #include "vf.h" #include "ixgbevf.h" @@ -285,7 +286,7 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr) ether_addr_copy(msg_addr, addr); ret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, - sizeof(msgbuf) / sizeof(u32)); + ARRAY_SIZE(msgbuf)); if (!ret_val) { msgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS; @@ -455,7 +456,7 @@ static s32 ixgbevf_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr, ether_addr_copy(msg_addr, addr); ret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, - sizeof(msgbuf) / sizeof(u32)); + ARRAY_SIZE(msgbuf)); msgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS; @@ -571,7 +572,7 @@ static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode) msgbuf[1] = xcast_mode; err = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, - sizeof(msgbuf) / sizeof(u32)); + ARRAY_SIZE(msgbuf)); if (err) return err; @@ -609,7 +610,7 @@ static s32 ixgbevf_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind, msgbuf[0] |= vlan_on << IXGBE_VT_MSGINFO_SHIFT; err = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, - sizeof(msgbuf) / sizeof(u32)); + ARRAY_SIZE(msgbuf)); if (err) goto mbx_err; @@ -813,7 +814,7 @@ static s32 ixgbevf_set_rlpml_vf(struct ixgbe_hw *hw, u16 max_size) msgbuf[1] = max_size; ret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, - sizeof(msgbuf) / sizeof(u32)); + ARRAY_SIZE(msgbuf)); if (ret_val) return ret_val; if ((msgbuf[0] & IXGBE_VF_SET_LPE) && @@ -859,8 +860,7 @@ static int ixgbevf_negotiate_api_version_vf(struct ixgbe_hw *hw, int api) msg[1] = api; msg[2] = 0; - err = ixgbevf_write_msg_read_ack(hw, msg, msg, - sizeof(msg) / sizeof(u32)); + err = ixgbevf_write_msg_read_ack(hw, msg, msg, ARRAY_SIZE(msg)); if (!err) { msg[0] &= ~IXGBE_VT_MSGTYPE_CTS; @@ -911,8 +911,7 @@ int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs, msg[0] = IXGBE_VF_GET_QUEUE; msg[1] = msg[2] = msg[3] = msg[4] = 0; - err = ixgbevf_write_msg_read_ack(hw, msg, msg, - sizeof(msg) / sizeof(u32)); + err = ixgbevf_write_msg_read_ack(hw, msg, msg, ARRAY_SIZE(msg)); if (!err) { msg[0] &= ~IXGBE_VT_MSGTYPE_CTS; diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c index ce0b0b4e3a57..6976003d64db 100644 --- a/drivers/net/usb/kalmia.c +++ b/drivers/net/usb/kalmia.c @@ -26,6 +26,7 @@ #include <linux/usb/cdc.h> #include <linux/usb/usbnet.h> #include <linux/gfp.h> +#include <linux/kernel.h> /* * The Samsung Kalmia based LTE USB modems have a CDC ACM port for modem control @@ -114,14 +115,14 @@ kalmia_init_and_get_ethernet_addr(struct usbnet *dev, u8 *ethernet_addr) return -ENOMEM; memcpy(usb_buf, init_msg_1, 12); - status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_1) - / sizeof(init_msg_1[0]), usb_buf, 24); + status = kalmia_send_init_packet(dev, usb_buf, ARRAY_SIZE(init_msg_1), + usb_buf, 24); if (status != 0) return status; memcpy(usb_buf, init_msg_2, 12); - status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_2) - / sizeof(init_msg_2[0]), usb_buf, 28); + status = kalmia_send_init_packet(dev, usb_buf, ARRAY_SIZE(init_msg_2), + usb_buf, 28); if (status != 0) return status; diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c index dbf50ef6cd75..84af04495622 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c @@ -14,6 +14,7 @@ * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ +#include <linux/kernel.h> #include <types.h> #include "phytbl_n.h" @@ -4437,109 +4438,44 @@ static const u16 loft_lut_core1_rev0[] = { }; const struct phytbl_info mimophytbl_info_rev0_volatile[] = { - {&bdi_tbl_rev0, sizeof(bdi_tbl_rev0) / sizeof(bdi_tbl_rev0[0]), 21, 0, - 16} - , - {&pltlut_tbl_rev0, sizeof(pltlut_tbl_rev0) / sizeof(pltlut_tbl_rev0[0]), - 20, 0, 32} - , - {&gainctrl_lut_core0_rev0, - sizeof(gainctrl_lut_core0_rev0) / sizeof(gainctrl_lut_core0_rev0[0]), - 26, 192, 32} - , - {&gainctrl_lut_core1_rev0, - sizeof(gainctrl_lut_core1_rev0) / sizeof(gainctrl_lut_core1_rev0[0]), - 27, 192, 32} - , - - {&est_pwr_lut_core0_rev0, - sizeof(est_pwr_lut_core0_rev0) / sizeof(est_pwr_lut_core0_rev0[0]), 26, - 0, 8} - , - {&est_pwr_lut_core1_rev0, - sizeof(est_pwr_lut_core1_rev0) / sizeof(est_pwr_lut_core1_rev0[0]), 27, - 0, 8} - , - {&adj_pwr_lut_core0_rev0, - sizeof(adj_pwr_lut_core0_rev0) / sizeof(adj_pwr_lut_core0_rev0[0]), 26, - 64, 8} - , - {&adj_pwr_lut_core1_rev0, - sizeof(adj_pwr_lut_core1_rev0) / sizeof(adj_pwr_lut_core1_rev0[0]), 27, - 64, 8} - , - {&iq_lut_core0_rev0, - sizeof(iq_lut_core0_rev0) / sizeof(iq_lut_core0_rev0[0]), 26, 320, 32} - , - {&iq_lut_core1_rev0, - sizeof(iq_lut_core1_rev0) / sizeof(iq_lut_core1_rev0[0]), 27, 320, 32} - , - {&loft_lut_core0_rev0, - sizeof(loft_lut_core0_rev0) / sizeof(loft_lut_core0_rev0[0]), 26, 448, - 16} - , - {&loft_lut_core1_rev0, - sizeof(loft_lut_core1_rev0) / sizeof(loft_lut_core1_rev0[0]), 27, 448, - 16} - , + {&bdi_tbl_rev0, ARRAY_SIZE(bdi_tbl_rev0), 21, 0, 16}, + {&pltlut_tbl_rev0, ARRAY_SIZE(pltlut_tbl_rev0), 20, 0, 32}, + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192, + 32}, + {&gainctrl_lut_core1_rev0, ARRAY_SIZE(gainctrl_lut_core1_rev0), 27, 192, + 32}, + {&est_pwr_lut_core0_rev0, ARRAY_SIZE(est_pwr_lut_core0_rev0), 26, 0, 8}, + {&est_pwr_lut_core1_rev0, ARRAY_SIZE(est_pwr_lut_core1_rev0), 27, 0, 8}, + {&adj_pwr_lut_core0_rev0, ARRAY_SIZE(adj_pwr_lut_core0_rev0), 26, 64, + 8}, + {&adj_pwr_lut_core1_rev0, ARRAY_SIZE(adj_pwr_lut_core1_rev0), 27, 64, + 8}, + {&iq_lut_core0_rev0, ARRAY_SIZE(iq_lut_core0_rev0), 26, 320, 32}, + {&iq_lut_core1_rev0, ARRAY_SIZE(iq_lut_core1_rev0), 27, 320, 32}, + {&loft_lut_core0_rev0, ARRAY_SIZE(loft_lut_core0_rev0), 26, 448, 16}, + {&loft_lut_core1_rev0, ARRAY_SIZE(loft_lut_core1_rev0), 27, 448, 16}, }; const struct phytbl_info mimophytbl_info_rev0[] = { - {&frame_struct_rev0, - sizeof(frame_struct_rev0) / sizeof(frame_struct_rev0[0]), 10, 0, 32} - , - {&frame_lut_rev0, sizeof(frame_lut_rev0) / sizeof(frame_lut_rev0[0]), - 24, 0, 8} - , - {&tmap_tbl_rev0, sizeof(tmap_tbl_rev0) / sizeof(tmap_tbl_rev0[0]), 12, - 0, 32} - , - {&tdtrn_tbl_rev0, sizeof(tdtrn_tbl_rev0) / sizeof(tdtrn_tbl_rev0[0]), - 14, 0, 32} - , - {&intlv_tbl_rev0, sizeof(intlv_tbl_rev0) / sizeof(intlv_tbl_rev0[0]), - 13, 0, 32} - , - {&pilot_tbl_rev0, sizeof(pilot_tbl_rev0) / sizeof(pilot_tbl_rev0[0]), - 11, 0, 16} - , - {&tdi_tbl20_ant0_rev0, - sizeof(tdi_tbl20_ant0_rev0) / sizeof(tdi_tbl20_ant0_rev0[0]), 19, 128, - 32} - , - {&tdi_tbl20_ant1_rev0, - sizeof(tdi_tbl20_ant1_rev0) / sizeof(tdi_tbl20_ant1_rev0[0]), 19, 256, - 32} - , - {&tdi_tbl40_ant0_rev0, - sizeof(tdi_tbl40_ant0_rev0) / sizeof(tdi_tbl40_ant0_rev0[0]), 19, 640, - 32} - , - {&tdi_tbl40_ant1_rev0, - sizeof(tdi_tbl40_ant1_rev0) / sizeof(tdi_tbl40_ant1_rev0[0]), 19, 768, - 32} - , - {&chanest_tbl_rev0, - sizeof(chanest_tbl_rev0) / sizeof(chanest_tbl_rev0[0]), 22, 0, 32} - , - {&mcs_tbl_rev0, sizeof(mcs_tbl_rev0) / sizeof(mcs_tbl_rev0[0]), 18, 0, - 8} - , - {&noise_var_tbl0_rev0, - sizeof(noise_var_tbl0_rev0) / sizeof(noise_var_tbl0_rev0[0]), 16, 0, - 32} - , - {&noise_var_tbl1_rev0, - sizeof(noise_var_tbl1_rev0) / sizeof(noise_var_tbl1_rev0[0]), 16, 128, - 32} - , + {&frame_struct_rev0, ARRAY_SIZE(frame_struct_rev0), 10, 0, 32}, + {&frame_lut_rev0, ARRAY_SIZE(frame_lut_rev0), 24, 0, 8}, + {&tmap_tbl_rev0, ARRAY_SIZE(tmap_tbl_rev0), 12, 0, 32}, + {&tdtrn_tbl_rev0, ARRAY_SIZE(tdtrn_tbl_rev0), 14, 0, 32}, + {&intlv_tbl_rev0, ARRAY_SIZE(intlv_tbl_rev0), 13, 0, 32}, + {&pilot_tbl_rev0, ARRAY_SIZE(pilot_tbl_rev0), 11, 0, 16}, + {&tdi_tbl20_ant0_rev0, ARRAY_SIZE(tdi_tbl20_ant0_rev0), 19, 128, 32}, + {&tdi_tbl20_ant1_rev0, ARRAY_SIZE(tdi_tbl20_ant1_rev0), 19, 256, 32}, + {&tdi_tbl40_ant0_rev0, ARRAY_SIZE(tdi_tbl40_ant0_rev0), 19, 640, 32}, + {&tdi_tbl40_ant1_rev0, ARRAY_SIZE(tdi_tbl40_ant1_rev0), 19, 768, 32}, + {&chanest_tbl_rev0, ARRAY_SIZE(chanest_tbl_rev0), 22, 0, 32}, + {&mcs_tbl_rev0, ARRAY_SIZE(mcs_tbl_rev0), 18, 0, 8}, + {&noise_var_tbl0_rev0, ARRAY_SIZE(noise_var_tbl0_rev0), 16, 0, 32}, + {&noise_var_tbl1_rev0, ARRAY_SIZE(noise_var_tbl1_rev0), 16, 128, 32}, }; -const u32 mimophytbl_info_sz_rev0 = - sizeof(mimophytbl_info_rev0) / sizeof(mimophytbl_info_rev0[0]); +const u32 mimophytbl_info_sz_rev0 = ARRAY_SIZE(mimophytbl_info_rev0); const u32 mimophytbl_info_sz_rev0_volatile = - sizeof(mimophytbl_info_rev0_volatile) / - sizeof(mimophytbl_info_rev0_volatile[0]); + ARRAY_SIZE(mimophytbl_info_rev0_volatile); static const u16 ant_swctrl_tbl_rev3[] = { 0x0082, @@ -9363,132 +9299,61 @@ static const u32 papd_cal_scalars_tbl_core1_rev3[] = { }; const struct phytbl_info mimophytbl_info_rev3_volatile[] = { - {&ant_swctrl_tbl_rev3, - sizeof(ant_swctrl_tbl_rev3) / sizeof(ant_swctrl_tbl_rev3[0]), 9, 0, 16} - , + {&ant_swctrl_tbl_rev3, ARRAY_SIZE(ant_swctrl_tbl_rev3), 9, 0, 16}, }; const struct phytbl_info mimophytbl_info_rev3_volatile1[] = { - {&ant_swctrl_tbl_rev3_1, - sizeof(ant_swctrl_tbl_rev3_1) / sizeof(ant_swctrl_tbl_rev3_1[0]), 9, 0, - 16} - , + {&ant_swctrl_tbl_rev3_1, ARRAY_SIZE(ant_swctrl_tbl_rev3_1), 9, 0, 16}, }; const struct phytbl_info mimophytbl_info_rev3_volatile2[] = { - {&ant_swctrl_tbl_rev3_2, - sizeof(ant_swctrl_tbl_rev3_2) / sizeof(ant_swctrl_tbl_rev3_2[0]), 9, 0, - 16} - , + {&ant_swctrl_tbl_rev3_2, ARRAY_SIZE(ant_swctrl_tbl_rev3_2), 9, 0, 16}, }; const struct phytbl_info mimophytbl_info_rev3_volatile3[] = { - {&ant_swctrl_tbl_rev3_3, - sizeof(ant_swctrl_tbl_rev3_3) / sizeof(ant_swctrl_tbl_rev3_3[0]), 9, 0, - 16} - , + {&ant_swctrl_tbl_rev3_3, ARRAY_SIZE(ant_swctrl_tbl_rev3_3), 9, 0, 16}, }; const struct phytbl_info mimophytbl_info_rev3[] = { - {&frame_struct_rev3, - sizeof(frame_struct_rev3) / sizeof(frame_struct_rev3[0]), 10, 0, 32} - , - {&pilot_tbl_rev3, sizeof(pilot_tbl_rev3) / sizeof(pilot_tbl_rev3[0]), - 11, 0, 16} - , - {&tmap_tbl_rev3, sizeof(tmap_tbl_rev3) / sizeof(tmap_tbl_rev3[0]), 12, - 0, 32} - , - {&intlv_tbl_rev3, sizeof(intlv_tbl_rev3) / sizeof(intlv_tbl_rev3[0]), - 13, 0, 32} - , - {&tdtrn_tbl_rev3, sizeof(tdtrn_tbl_rev3) / sizeof(tdtrn_tbl_rev3[0]), - 14, 0, 32} - , - {&noise_var_tbl_rev3, - sizeof(noise_var_tbl_rev3) / sizeof(noise_var_tbl_rev3[0]), 16, 0, 32} - , - {&mcs_tbl_rev3, sizeof(mcs_tbl_rev3) / sizeof(mcs_tbl_rev3[0]), 18, 0, - 16} - , - {&tdi_tbl20_ant0_rev3, - sizeof(tdi_tbl20_ant0_rev3) / sizeof(tdi_tbl20_ant0_rev3[0]), 19, 128, - 32} - , - {&tdi_tbl20_ant1_rev3, - sizeof(tdi_tbl20_ant1_rev3) / sizeof(tdi_tbl20_ant1_rev3[0]), 19, 256, - 32} - , - {&tdi_tbl40_ant0_rev3, - sizeof(tdi_tbl40_ant0_rev3) / sizeof(tdi_tbl40_ant0_rev3[0]), 19, 640, - 32} - , - {&tdi_tbl40_ant1_rev3, - sizeof(tdi_tbl40_ant1_rev3) / sizeof(tdi_tbl40_ant1_rev3[0]), 19, 768, - 32} - , - {&pltlut_tbl_rev3, sizeof(pltlut_tbl_rev3) / sizeof(pltlut_tbl_rev3[0]), - 20, 0, 32} - , - {&chanest_tbl_rev3, - sizeof(chanest_tbl_rev3) / sizeof(chanest_tbl_rev3[0]), 22, 0, 32} - , - {&frame_lut_rev3, sizeof(frame_lut_rev3) / sizeof(frame_lut_rev3[0]), - 24, 0, 8} - , - {&est_pwr_lut_core0_rev3, - sizeof(est_pwr_lut_core0_rev3) / sizeof(est_pwr_lut_core0_rev3[0]), 26, - 0, 8} - , - {&est_pwr_lut_core1_rev3, - sizeof(est_pwr_lut_core1_rev3) / sizeof(est_pwr_lut_core1_rev3[0]), 27, - 0, 8} - , - {&adj_pwr_lut_core0_rev3, - sizeof(adj_pwr_lut_core0_rev3) / sizeof(adj_pwr_lut_core0_rev3[0]), 26, - 64, 8} - , - {&adj_pwr_lut_core1_rev3, - sizeof(adj_pwr_lut_core1_rev3) / sizeof(adj_pwr_lut_core1_rev3[0]), 27, - 64, 8} - , - {&gainctrl_lut_core0_rev3, - sizeof(gainctrl_lut_core0_rev3) / sizeof(gainctrl_lut_core0_rev3[0]), - 26, 192, 32} - , - {&gainctrl_lut_core1_rev3, - sizeof(gainctrl_lut_core1_rev3) / sizeof(gainctrl_lut_core1_rev3[0]), - 27, 192, 32} - , - {&iq_lut_core0_rev3, - sizeof(iq_lut_core0_rev3) / sizeof(iq_lut_core0_rev3[0]), 26, 320, 32} - , - {&iq_lut_core1_rev3, - sizeof(iq_lut_core1_rev3) / sizeof(iq_lut_core1_rev3[0]), 27, 320, 32} - , - {&loft_lut_core0_rev3, - sizeof(loft_lut_core0_rev3) / sizeof(loft_lut_core0_rev3[0]), 26, 448, - 16} - , - {&loft_lut_core1_rev3, - sizeof(loft_lut_core1_rev3) / sizeof(loft_lut_core1_rev3[0]), 27, 448, - 16} + {&frame_struct_rev3, ARRAY_SIZE(frame_struct_rev3), 10, 0, 32}, + {&pilot_tbl_rev3, ARRAY_SIZE(pilot_tbl_rev3), 11, 0, 16}, + {&tmap_tbl_rev3, ARRAY_SIZE(tmap_tbl_rev3), 12, 0, 32}, + {&intlv_tbl_rev3, ARRAY_SIZE(intlv_tbl_rev3), 13, 0, 32}, + {&tdtrn_tbl_rev3, ARRAY_SIZE(tdtrn_tbl_rev3), 14, 0, 32}, + {&noise_var_tbl_rev3, ARRAY_SIZE(noise_var_tbl_rev3), 16, 0, 32}, + {&mcs_tbl_rev3, ARRAY_SIZE(mcs_tbl_rev3), 18, 0, 16}, + {&tdi_tbl20_ant0_rev3, ARRAY_SIZE(tdi_tbl20_ant0_rev3), 19, 128, 32}, + {&tdi_tbl20_ant1_rev3, ARRAY_SIZE(tdi_tbl20_ant1_rev3), 19, 256, 32}, + {&tdi_tbl40_ant0_rev3, ARRAY_SIZE(tdi_tbl40_ant0_rev3), 19, 640, 32}, + {&tdi_tbl40_ant1_rev3, ARRAY_SIZE(tdi_tbl40_ant1_rev3), 19, 768, 32}, + {&pltlut_tbl_rev3, ARRAY_SIZE(pltlut_tbl_rev3), 20, 0, 32}, + {&chanest_tbl_rev3, ARRAY_SIZE(chanest_tbl_rev3), 22, 0, 32}, + {&frame_lut_rev3, ARRAY_SIZE(frame_lut_rev3), 24, 0, 8}, + {&est_pwr_lut_core0_rev3, ARRAY_SIZE(est_pwr_lut_core0_rev3), 26, 0, 8}, + {&est_pwr_lut_core1_rev3, ARRAY_SIZE(est_pwr_lut_core1_rev3), 27, 0, 8}, + {&adj_pwr_lut_core0_rev3, ARRAY_SIZE(adj_pwr_lut_core0_rev3), 26, 64, + 8}, + {&adj_pwr_lut_core1_rev3, ARRAY_SIZE(adj_pwr_lut_core1_rev3), 27, 64, + 8}, + {&gainctrl_lut_core0_rev3, ARRAY_SIZE(gainctrl_lut_core0_rev3), 26, 192, + 32}, + {&gainctrl_lut_core1_rev3, ARRAY_SIZE(gainctrl_lut_core1_rev3), 27, 192, + 32}, + {&iq_lut_core0_rev3, ARRAY_SIZE(iq_lut_core0_rev3), 26, 320, 32}, + {&iq_lut_core1_rev3, ARRAY_SIZE(iq_lut_core1_rev3), 27, 320, 32}, + {&loft_lut_core0_rev3, ARRAY_SIZE(loft_lut_core0_rev3), 26, 448, 16}, + {&loft_lut_core1_rev3, ARRAY_SIZE(loft_lut_core1_rev3), 27, 448, 16} }; -const u32 mimophytbl_info_sz_rev3 = - sizeof(mimophytbl_info_rev3) / sizeof(mimophytbl_info_rev3[0]); +const u32 mimophytbl_info_sz_rev3 = ARRAY_SIZE(mimophytbl_info_rev3); const u32 mimophytbl_info_sz_rev3_volatile = - sizeof(mimophytbl_info_rev3_volatile) / - sizeof(mimophytbl_info_rev3_volatile[0]); + ARRAY_SIZE(mimophytbl_info_rev3_volatile); const u32 mimophytbl_info_sz_rev3_volatile1 = - sizeof(mimophytbl_info_rev3_volatile1) / - sizeof(mimophytbl_info_rev3_volatile1[0]); + ARRAY_SIZE(mimophytbl_info_rev3_volatile1); const u32 mimophytbl_info_sz_rev3_volatile2 = - sizeof(mimophytbl_info_rev3_volatile2) / - sizeof(mimophytbl_info_rev3_volatile2[0]); + ARRAY_SIZE(mimophytbl_info_rev3_volatile2); const u32 mimophytbl_info_sz_rev3_volatile3 = - sizeof(mimophytbl_info_rev3_volatile3) / - sizeof(mimophytbl_info_rev3_volatile3[0]); + ARRAY_SIZE(mimophytbl_info_rev3_volatile3); static const u32 tmap_tbl_rev7[] = { 0x8a88aa80, @@ -10469,162 +10334,66 @@ static const u32 papd_cal_scalars_tbl_core1_rev7[] = { }; const struct phytbl_info mimophytbl_info_rev7[] = { - {&frame_struct_rev3, - sizeof(frame_struct_rev3) / sizeof(frame_struct_rev3[0]), 10, 0, 32} - , - {&pilot_tbl_rev3, sizeof(pilot_tbl_rev3) / sizeof(pilot_tbl_rev3[0]), - 11, 0, 16} - , - {&tmap_tbl_rev7, sizeof(tmap_tbl_rev7) / sizeof(tmap_tbl_rev7[0]), 12, - 0, 32} - , - {&intlv_tbl_rev3, sizeof(intlv_tbl_rev3) / sizeof(intlv_tbl_rev3[0]), - 13, 0, 32} - , - {&tdtrn_tbl_rev3, sizeof(tdtrn_tbl_rev3) / sizeof(tdtrn_tbl_rev3[0]), - 14, 0, 32} - , - {&noise_var_tbl_rev7, - sizeof(noise_var_tbl_rev7) / sizeof(noise_var_tbl_rev7[0]), 16, 0, 32} - , - {&mcs_tbl_rev3, sizeof(mcs_tbl_rev3) / sizeof(mcs_tbl_rev3[0]), 18, 0, - 16} - , - {&tdi_tbl20_ant0_rev3, - sizeof(tdi_tbl20_ant0_rev3) / sizeof(tdi_tbl20_ant0_rev3[0]), 19, 128, - 32} - , - {&tdi_tbl20_ant1_rev3, - sizeof(tdi_tbl20_ant1_rev3) / sizeof(tdi_tbl20_ant1_rev3[0]), 19, 256, - 32} - , - {&tdi_tbl40_ant0_rev3, - sizeof(tdi_tbl40_ant0_rev3) / sizeof(tdi_tbl40_ant0_rev3[0]), 19, 640, - 32} - , - {&tdi_tbl40_ant1_rev3, - sizeof(tdi_tbl40_ant1_rev3) / sizeof(tdi_tbl40_ant1_rev3[0]), 19, 768, - 32} - , - {&pltlut_tbl_rev3, sizeof(pltlut_tbl_rev3) / sizeof(pltlut_tbl_rev3[0]), - 20, 0, 32} - , - {&chanest_tbl_rev3, - sizeof(chanest_tbl_rev3) / sizeof(chanest_tbl_rev3[0]), 22, 0, 32} - , - {&frame_lut_rev3, sizeof(frame_lut_rev3) / sizeof(frame_lut_rev3[0]), - 24, 0, 8} - , - {&est_pwr_lut_core0_rev3, - sizeof(est_pwr_lut_core0_rev3) / sizeof(est_pwr_lut_core0_rev3[0]), 26, - 0, 8} - , - {&est_pwr_lut_core1_rev3, - sizeof(est_pwr_lut_core1_rev3) / sizeof(est_pwr_lut_core1_rev3[0]), 27, - 0, 8} - , - {&adj_pwr_lut_core0_rev3, - sizeof(adj_pwr_lut_core0_rev3) / sizeof(adj_pwr_lut_core0_rev3[0]), 26, - 64, 8} - , - {&adj_pwr_lut_core1_rev3, - sizeof(adj_pwr_lut_core1_rev3) / sizeof(adj_pwr_lut_core1_rev3[0]), 27, - 64, 8} - , - {&gainctrl_lut_core0_rev3, - sizeof(gainctrl_lut_core0_rev3) / sizeof(gainctrl_lut_core0_rev3[0]), - 26, 192, 32} - , - {&gainctrl_lut_core1_rev3, - sizeof(gainctrl_lut_core1_rev3) / sizeof(gainctrl_lut_core1_rev3[0]), - 27, 192, 32} - , - {&iq_lut_core0_rev3, - sizeof(iq_lut_core0_rev3) / sizeof(iq_lut_core0_rev3[0]), 26, 320, 32} - , - {&iq_lut_core1_rev3, - sizeof(iq_lut_core1_rev3) / sizeof(iq_lut_core1_rev3[0]), 27, 320, 32} - , - {&loft_lut_core0_rev3, - sizeof(loft_lut_core0_rev3) / sizeof(loft_lut_core0_rev3[0]), 26, 448, - 16} - , - {&loft_lut_core1_rev3, - sizeof(loft_lut_core1_rev3) / sizeof(loft_lut_core1_rev3[0]), 27, 448, - 16} - , + {&frame_struct_rev3, ARRAY_SIZE(frame_struct_rev3), 10, 0, 32}, + {&pilot_tbl_rev3, ARRAY_SIZE(pilot_tbl_rev3), 11, 0, 16}, + {&tmap_tbl_rev7, ARRAY_SIZE(tmap_tbl_rev7), 12, 0, 32}, + {&intlv_tbl_rev3, ARRAY_SIZE(intlv_tbl_rev3), 13, 0, 32}, + {&tdtrn_tbl_rev3, ARRAY_SIZE(tdtrn_tbl_rev3), 14, 0, 32}, + {&noise_var_tbl_rev7, ARRAY_SIZE(noise_var_tbl_rev7), 16, 0, 32}, + {&mcs_tbl_rev3, ARRAY_SIZE(mcs_tbl_rev3), 18, 0, 16}, + {&tdi_tbl20_ant0_rev3, ARRAY_SIZE(tdi_tbl20_ant0_rev3), 19, 128, 32}, + {&tdi_tbl20_ant1_rev3, ARRAY_SIZE(tdi_tbl20_ant1_rev3), 19, 256, 32}, + {&tdi_tbl40_ant0_rev3, ARRAY_SIZE(tdi_tbl40_ant0_rev3), 19, 640, 32}, + {&tdi_tbl40_ant1_rev3, ARRAY_SIZE(tdi_tbl40_ant1_rev3), 19, 768, 32}, + {&pltlut_tbl_rev3, ARRAY_SIZE(pltlut_tbl_rev3), 20, 0, 32}, + {&chanest_tbl_rev3, ARRAY_SIZE(chanest_tbl_rev3), 22, 0, 32}, + {&frame_lut_rev3, ARRAY_SIZE(frame_lut_rev3), 24, 0, 8}, + {&est_pwr_lut_core0_rev3, ARRAY_SIZE(est_pwr_lut_core0_rev3), 26, 0, 8}, + {&est_pwr_lut_core1_rev3, ARRAY_SIZE(est_pwr_lut_core1_rev3), 27, 0, 8}, + {&adj_pwr_lut_core0_rev3, ARRAY_SIZE(adj_pwr_lut_core0_rev3), 26, 64, + 8}, + {&adj_pwr_lut_core1_rev3, ARRAY_SIZE(adj_pwr_lut_core1_rev3), 27, 64, + 8}, + {&gainctrl_lut_core0_rev3, ARRAY_SIZE(gainctrl_lut_core0_rev3), 26, 192, + 32}, + {&gainctrl_lut_core1_rev3, ARRAY_SIZE(gainctrl_lut_core1_rev3), 27, 192, + 32}, + {&iq_lut_core0_rev3, ARRAY_SIZE(iq_lut_core0_rev3), 26, 320, 32}, + {&iq_lut_core1_rev3, ARRAY_SIZE(iq_lut_core1_rev3), 27, 320, 32}, + {&loft_lut_core0_rev3, ARRAY_SIZE(loft_lut_core0_rev3), 26, 448, 16}, + {&loft_lut_core1_rev3, ARRAY_SIZE(loft_lut_core1_rev3), 27, 448, 16}, {&papd_comp_rfpwr_tbl_core0_rev3, - sizeof(papd_comp_rfpwr_tbl_core0_rev3) / - sizeof(papd_comp_rfpwr_tbl_core0_rev3[0]), 26, 576, 16} - , + ARRAY_SIZE(papd_comp_rfpwr_tbl_core0_rev3), 26, 576, 16}, {&papd_comp_rfpwr_tbl_core1_rev3, - sizeof(papd_comp_rfpwr_tbl_core1_rev3) / - sizeof(papd_comp_rfpwr_tbl_core1_rev3[0]), 27, 576, 16} - , + ARRAY_SIZE(papd_comp_rfpwr_tbl_core1_rev3), 27, 576, 16}, {&papd_comp_epsilon_tbl_core0_rev7, - sizeof(papd_comp_epsilon_tbl_core0_rev7) / - sizeof(papd_comp_epsilon_tbl_core0_rev7[0]), 31, 0, 32} - , + ARRAY_SIZE(papd_comp_epsilon_tbl_core0_rev7), 31, 0, 32}, {&papd_cal_scalars_tbl_core0_rev7, - sizeof(papd_cal_scalars_tbl_core0_rev7) / - sizeof(papd_cal_scalars_tbl_core0_rev7[0]), 32, 0, 32} - , + ARRAY_SIZE(papd_cal_scalars_tbl_core0_rev7), 32, 0, 32}, {&papd_comp_epsilon_tbl_core1_rev7, - sizeof(papd_comp_epsilon_tbl_core1_rev7) / - sizeof(papd_comp_epsilon_tbl_core1_rev7[0]), 33, 0, 32} - , + ARRAY_SIZE(papd_comp_epsilon_tbl_core1_rev7), 33, 0, 32}, {&papd_cal_scalars_tbl_core1_rev7, - sizeof(papd_cal_scalars_tbl_core1_rev7) / - sizeof(papd_cal_scalars_tbl_core1_rev7[0]), 34, 0, 32} - , + ARRAY_SIZE(papd_cal_scalars_tbl_core1_rev7), 34, 0, 32}, }; -const u32 mimophytbl_info_sz_rev7 = - sizeof(mimophytbl_info_rev7) / sizeof(mimophytbl_info_rev7[0]); +const u32 mimophytbl_info_sz_rev7 = ARRAY_SIZE(mimophytbl_info_rev7); const struct phytbl_info mimophytbl_info_rev16[] = { - {&noise_var_tbl_rev7, - sizeof(noise_var_tbl_rev7) / sizeof(noise_var_tbl_rev7[0]), 16, 0, 32} - , - {&est_pwr_lut_core0_rev3, - sizeof(est_pwr_lut_core0_rev3) / sizeof(est_pwr_lut_core0_rev3[0]), 26, - 0, 8} - , - {&est_pwr_lut_core1_rev3, - sizeof(est_pwr_lut_core1_rev3) / sizeof(est_pwr_lut_core1_rev3[0]), 27, - 0, 8} - , - {&adj_pwr_lut_core0_rev3, - sizeof(adj_pwr_lut_core0_rev3) / sizeof(adj_pwr_lut_core0_rev3[0]), 26, - 64, 8} - , - {&adj_pwr_lut_core1_rev3, - sizeof(adj_pwr_lut_core1_rev3) / sizeof(adj_pwr_lut_core1_rev3[0]), 27, - 64, 8} - , - {&gainctrl_lut_core0_rev3, - sizeof(gainctrl_lut_core0_rev3) / sizeof(gainctrl_lut_core0_rev3[0]), - 26, 192, 32} - , - {&gainctrl_lut_core1_rev3, - sizeof(gainctrl_lut_core1_rev3) / sizeof(gainctrl_lut_core1_rev3[0]), - 27, 192, 32} - , - {&iq_lut_core0_rev3, - sizeof(iq_lut_core0_rev3) / sizeof(iq_lut_core0_rev3[0]), 26, 320, 32} - , - {&iq_lut_core1_rev3, - sizeof(iq_lut_core1_rev3) / sizeof(iq_lut_core1_rev3[0]), 27, 320, 32} - , - {&loft_lut_core0_rev3, - sizeof(loft_lut_core0_rev3) / sizeof(loft_lut_core0_rev3[0]), 26, 448, - 16} - , - {&loft_lut_core1_rev3, - sizeof(loft_lut_core1_rev3) / sizeof(loft_lut_core1_rev3[0]), 27, 448, - 16} - , + {&noise_var_tbl_rev7, ARRAY_SIZE(noise_var_tbl_rev7), 16, 0, 32}, + {&est_pwr_lut_core0_rev3, ARRAY_SIZE(est_pwr_lut_core0_rev3), 26, 0, 8}, + {&est_pwr_lut_core1_rev3, ARRAY_SIZE(est_pwr_lut_core1_rev3), 27, 0, 8}, + {&adj_pwr_lut_core0_rev3, ARRAY_SIZE(adj_pwr_lut_core0_rev3), 26, 64, + 8}, + {&adj_pwr_lut_core1_rev3, ARRAY_SIZE(adj_pwr_lut_core1_rev3), 27, 64, + 8}, + {&gainctrl_lut_core0_rev3, ARRAY_SIZE(gainctrl_lut_core0_rev3), 26, 192, + 32}, + {&gainctrl_lut_core1_rev3, ARRAY_SIZE(gainctrl_lut_core1_rev3), 27, 192, + 32}, + {&iq_lut_core0_rev3, ARRAY_SIZE(iq_lut_core0_rev3), 26, 320, 32}, + {&iq_lut_core1_rev3, ARRAY_SIZE(iq_lut_core1_rev3), 27, 320, 32}, + {&loft_lut_core0_rev3, ARRAY_SIZE(loft_lut_core0_rev3), 26, 448, 16}, + {&loft_lut_core1_rev3, ARRAY_SIZE(loft_lut_core1_rev3), 27, 448, 16}, }; -const u32 mimophytbl_info_sz_rev16 = - sizeof(mimophytbl_info_rev16) / sizeof(mimophytbl_info_rev16[0]); +const u32 mimophytbl_info_sz_rev16 = ARRAY_SIZE(mimophytbl_info_rev16); diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c index 4d47b97adfed..fb035ea13553 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c @@ -43,6 +43,7 @@ #include "../pwrseqcmd.h" #include "pwrseq.h" #include "../btcoexist/rtl_btc.h" +#include <linux/kernel.h> #define LLT_CONFIG 5 @@ -2125,28 +2126,28 @@ static void _rtl8723be_read_adapter_info(struct ieee80211_hw *hw, if (rtlhal->oem_id == RT_CID_DEFAULT) { /* Does this one have a Toshiba SMID from group 1? */ - for (i = 0; i < sizeof(toshiba_smid1) / sizeof(u16); i++) { + for (i = 0; i < ARRAY_SIZE(toshiba_smid1); i++) { if (rtlefuse->eeprom_smid == toshiba_smid1[i]) { is_toshiba_smid1 = true; break; } } /* Does this one have a Toshiba SMID from group 2? */ - for (i = 0; i < sizeof(toshiba_smid2) / sizeof(u16); i++) { + for (i = 0; i < ARRAY_SIZE(toshiba_smid2); i++) { if (rtlefuse->eeprom_smid == toshiba_smid2[i]) { is_toshiba_smid2 = true; break; } } /* Does this one have a Samsung SMID? */ - for (i = 0; i < sizeof(samsung_smid) / sizeof(u16); i++) { + for (i = 0; i < ARRAY_SIZE(samsung_smid); i++) { if (rtlefuse->eeprom_smid == samsung_smid[i]) { is_samsung_smid = true; break; } } /* Does this one have a Lenovo SMID? */ - for (i = 0; i < sizeof(lenovo_smid) / sizeof(u16); i++) { + for (i = 0; i < ARRAY_SIZE(lenovo_smid); i++) { if (rtlefuse->eeprom_smid == lenovo_smid[i]) { is_lenovo_smid = true; break; diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c index 9606641519e7..1263b12db5dc 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c @@ -35,6 +35,7 @@ #include "../rtl8723com/dm_common.h" #include "table.h" #include "trx.h" +#include <linux/kernel.h> static bool _rtl8723be_phy_bb8723b_config_parafile(struct ieee80211_hw *hw); static bool _rtl8723be_phy_config_mac_with_headerfile(struct ieee80211_hw *hw); @@ -1143,14 +1144,13 @@ void rtl8723be_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel) DESC92C_RATEMCS2, DESC92C_RATEMCS3, DESC92C_RATEMCS4, DESC92C_RATEMCS5, DESC92C_RATEMCS6, DESC92C_RATEMCS7}; - u8 i, size; + u8 i; u8 power_index; if (!rtlefuse->txpwr_fromeprom) return; - size = sizeof(cck_rates) / sizeof(u8); - for (i = 0; i < size; i++) { + for (i = 0; i < ARRAY_SIZE(cck_rates); i++) { power_index = _rtl8723be_get_txpower_index(hw, RF90_PATH_A, cck_rates[i], rtl_priv(hw)->phy.current_chan_bw, @@ -1158,8 +1158,7 @@ void rtl8723be_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel) _rtl8723be_phy_set_txpower_index(hw, power_index, RF90_PATH_A, cck_rates[i]); } - size = sizeof(ofdm_rates) / sizeof(u8); - for (i = 0; i < size; i++) { + for (i = 0; i < ARRAY_SIZE(ofdm_rates); i++) { power_index = _rtl8723be_get_txpower_index(hw, RF90_PATH_A, ofdm_rates[i], rtl_priv(hw)->phy.current_chan_bw, @@ -1167,8 +1166,7 @@ void rtl8723be_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel) _rtl8723be_phy_set_txpower_index(hw, power_index, RF90_PATH_A, ofdm_rates[i]); } - size = sizeof(ht_rates_1t) / sizeof(u8); - for (i = 0; i < size; i++) { + for (i = 0; i < ARRAY_SIZE(ht_rates_1t); i++) { power_index = _rtl8723be_get_txpower_index(hw, RF90_PATH_A, ht_rates_1t[i], rtl_priv(hw)->phy.current_chan_bw, diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/table.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/table.c index 381c16b9b3a9..160fee8333ae 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/table.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/table.c @@ -25,6 +25,7 @@ * *****************************************************************************/ +#include <linux/kernel.h> #include "table.h" u32 RTL8723BEPHY_REG_1TARRAY[] = { @@ -224,8 +225,7 @@ u32 RTL8723BEPHY_REG_1TARRAY[] = { }; -u32 RTL8723BEPHY_REG_1TARRAYLEN = - sizeof(RTL8723BEPHY_REG_1TARRAY) / sizeof(u32); +u32 RTL8723BEPHY_REG_1TARRAYLEN = ARRAY_SIZE(RTL8723BEPHY_REG_1TARRAY); u32 RTL8723BEPHY_REG_ARRAY_PG[] = { 0, 0, 0, 0x00000e08, 0x0000ff00, 0x00003800, @@ -236,8 +236,7 @@ u32 RTL8723BEPHY_REG_ARRAY_PG[] = { 0, 0, 0, 0x00000e14, 0xffffffff, 0x26303436 }; -u32 RTL8723BEPHY_REG_ARRAY_PGLEN = - sizeof(RTL8723BEPHY_REG_ARRAY_PG) / sizeof(u32); +u32 RTL8723BEPHY_REG_ARRAY_PGLEN = ARRAY_SIZE(RTL8723BEPHY_REG_ARRAY_PG); u32 RTL8723BE_RADIOA_1TARRAY[] = { 0x000, 0x00010000, @@ -373,8 +372,7 @@ u32 RTL8723BE_RADIOA_1TARRAY[] = { }; -u32 RTL8723BE_RADIOA_1TARRAYLEN = - sizeof(RTL8723BE_RADIOA_1TARRAY) / sizeof(u32); +u32 RTL8723BE_RADIOA_1TARRAYLEN = ARRAY_SIZE(RTL8723BE_RADIOA_1TARRAY); u32 RTL8723BEMAC_1T_ARRAY[] = { 0x02F, 0x00000030, @@ -483,7 +481,7 @@ u32 RTL8723BEMAC_1T_ARRAY[] = { }; -u32 RTL8723BEMAC_1T_ARRAYLEN = sizeof(RTL8723BEMAC_1T_ARRAY) / sizeof(u32); +u32 RTL8723BEMAC_1T_ARRAYLEN = ARRAY_SIZE(RTL8723BEMAC_1T_ARRAY); u32 RTL8723BEAGCTAB_1TARRAY[] = { 0xC78, 0xFD000001, @@ -620,4 +618,4 @@ u32 RTL8723BEAGCTAB_1TARRAY[] = { }; -u32 RTL8723BEAGCTAB_1TARRAYLEN = sizeof(RTL8723BEAGCTAB_1TARRAY) / sizeof(u32); +u32 RTL8723BEAGCTAB_1TARRAYLEN = ARRAY_SIZE(RTL8723BEAGCTAB_1TARRAY); diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c index 408c4611e5de..f87f9d03b9fa 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c @@ -24,7 +24,7 @@ * Larry Finger <Larry.Finger@lwfinger.net> * *****************************************************************************/ - +#include <linux/kernel.h> #include "table.h" u32 RTL8812AE_PHY_REG_ARRAY[] = { 0x800, 0x8020D010, @@ -258,8 +258,7 @@ u32 RTL8812AE_PHY_REG_ARRAY[] = { 0xEB8, 0x00508242, }; -u32 RTL8812AE_PHY_REG_1TARRAYLEN = - sizeof(RTL8812AE_PHY_REG_ARRAY) / sizeof(u32); +u32 RTL8812AE_PHY_REG_1TARRAYLEN = ARRAY_SIZE(RTL8812AE_PHY_REG_ARRAY); u32 RTL8821AE_PHY_REG_ARRAY[] = { 0x800, 0x0020D090, @@ -436,8 +435,7 @@ u32 RTL8821AE_PHY_REG_ARRAY[] = { 0xCB8, 0x00508240, }; -u32 RTL8821AE_PHY_REG_1TARRAYLEN = - sizeof(RTL8821AE_PHY_REG_ARRAY) / sizeof(u32); +u32 RTL8821AE_PHY_REG_1TARRAYLEN = ARRAY_SIZE(RTL8821AE_PHY_REG_ARRAY); u32 RTL8812AE_PHY_REG_ARRAY_PG[] = { 0, 0, 0, 0x00000c20, 0xffffffff, 0x34363840, @@ -488,8 +486,7 @@ u32 RTL8812AE_PHY_REG_ARRAY_PG[] = { 1, 1, 1, 0x00000e4c, 0xffffffff, 0x22242628 }; -u32 RTL8812AE_PHY_REG_ARRAY_PGLEN = - sizeof(RTL8812AE_PHY_REG_ARRAY_PG) / sizeof(u32); +u32 RTL8812AE_PHY_REG_ARRAY_PGLEN = ARRAY_SIZE(RTL8812AE_PHY_REG_ARRAY_PG); u32 RTL8821AE_PHY_REG_ARRAY_PG[] = { 0, 0, 0, 0x00000c20, 0xffffffff, 0x32343638, @@ -509,8 +506,7 @@ u32 RTL8821AE_PHY_REG_ARRAY_PG[] = { 1, 0, 0, 0x00000c44, 0x0000ffff, 0x00002022 }; -u32 RTL8821AE_PHY_REG_ARRAY_PGLEN = - sizeof(RTL8821AE_PHY_REG_ARRAY_PG) / sizeof(u32); +u32 RTL8821AE_PHY_REG_ARRAY_PGLEN = ARRAY_SIZE(RTL8821AE_PHY_REG_ARRAY_PG); u32 RTL8812AE_RADIOA_ARRAY[] = { 0x000, 0x00010000, @@ -927,7 +923,7 @@ u32 RTL8812AE_RADIOA_ARRAY[] = { 0x018, 0x0001712A, }; -u32 RTL8812AE_RADIOA_1TARRAYLEN = sizeof(RTL8812AE_RADIOA_ARRAY) / sizeof(u32); +u32 RTL8812AE_RADIOA_1TARRAYLEN = ARRAY_SIZE(RTL8812AE_RADIOA_ARRAY); u32 RTL8812AE_RADIOB_ARRAY[] = { 0x056, 0x00051CF2, @@ -1335,7 +1331,7 @@ u32 RTL8812AE_RADIOB_ARRAY[] = { 0x008, 0x00008400, }; -u32 RTL8812AE_RADIOB_1TARRAYLEN = sizeof(RTL8812AE_RADIOB_ARRAY) / sizeof(u32); +u32 RTL8812AE_RADIOB_1TARRAYLEN = ARRAY_SIZE(RTL8812AE_RADIOB_ARRAY); u32 RTL8821AE_RADIOA_ARRAY[] = { 0x018, 0x0001712A, @@ -1929,7 +1925,7 @@ u32 RTL8821AE_RADIOA_ARRAY[] = { }; -u32 RTL8821AE_RADIOA_1TARRAYLEN = sizeof(RTL8821AE_RADIOA_ARRAY) / sizeof(u32); +u32 RTL8821AE_RADIOA_1TARRAYLEN = ARRAY_SIZE(RTL8821AE_RADIOA_ARRAY); u32 RTL8812AE_MAC_REG_ARRAY[] = { 0x010, 0x0000000C, @@ -2041,7 +2037,7 @@ u32 RTL8812AE_MAC_REG_ARRAY[] = { 0x718, 0x00000040, }; -u32 RTL8812AE_MAC_1T_ARRAYLEN = sizeof(RTL8812AE_MAC_REG_ARRAY) / sizeof(u32); +u32 RTL8812AE_MAC_1T_ARRAYLEN = ARRAY_SIZE(RTL8812AE_MAC_REG_ARRAY); u32 RTL8821AE_MAC_REG_ARRAY[] = { 0x428, 0x0000000A, @@ -2143,7 +2139,7 @@ u32 RTL8821AE_MAC_REG_ARRAY[] = { 0x718, 0x00000040, }; -u32 RTL8821AE_MAC_1T_ARRAYLEN = sizeof(RTL8821AE_MAC_REG_ARRAY) / sizeof(u32); +u32 RTL8821AE_MAC_1T_ARRAYLEN = ARRAY_SIZE(RTL8821AE_MAC_REG_ARRAY); u32 RTL8812AE_AGC_TAB_ARRAY[] = { 0x80000001, 0x00000000, 0x40000000, 0x00000000, @@ -2479,8 +2475,7 @@ u32 RTL8812AE_AGC_TAB_ARRAY[] = { 0xE50, 0x00000020, }; -u32 RTL8812AE_AGC_TAB_1TARRAYLEN = - sizeof(RTL8812AE_AGC_TAB_ARRAY) / sizeof(u32); +u32 RTL8812AE_AGC_TAB_1TARRAYLEN = ARRAY_SIZE(RTL8812AE_AGC_TAB_ARRAY); u32 RTL8821AE_AGC_TAB_ARRAY[] = { 0x81C, 0xBF000001, @@ -2676,8 +2671,7 @@ u32 RTL8821AE_AGC_TAB_ARRAY[] = { 0xC50, 0x00000020, }; -u32 RTL8821AE_AGC_TAB_1TARRAYLEN = - sizeof(RTL8821AE_AGC_TAB_ARRAY) / sizeof(u32); +u32 RTL8821AE_AGC_TAB_1TARRAYLEN = ARRAY_SIZE(RTL8821AE_AGC_TAB_ARRAY); /****************************************************************************** * TXPWR_LMT.TXT @@ -3250,7 +3244,7 @@ u8 *RTL8812AE_TXPWR_LMT[] = { "MKK", "5G", "80M", "VHT", "2T", "155", "63" }; -u32 RTL8812AE_TXPWR_LMT_ARRAY_LEN = sizeof(RTL8812AE_TXPWR_LMT) / sizeof(u8 *); +u32 RTL8812AE_TXPWR_LMT_ARRAY_LEN = ARRAY_SIZE(RTL8812AE_TXPWR_LMT); u8 *RTL8821AE_TXPWR_LMT[] = { "FCC", "2.4G", "20M", "CCK", "1T", "01", "32", @@ -3819,4 +3813,4 @@ u8 *RTL8821AE_TXPWR_LMT[] = { "MKK", "5G", "80M", "VHT", "2T", "155", "63" }; -u32 RTL8821AE_TXPWR_LMT_ARRAY_LEN = sizeof(RTL8821AE_TXPWR_LMT) / sizeof(u8 *); +u32 RTL8821AE_TXPWR_LMT_ARRAY_LEN = ARRAY_SIZE(RTL8821AE_TXPWR_LMT); diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h index f358ad5e4214..7a06fa295814 100644 --- a/include/net/bond_3ad.h +++ b/include/net/bond_3ad.h @@ -27,6 +27,7 @@ #include <linux/skbuff.h> #include <linux/netdevice.h> #include <linux/if_ether.h> +#include <linux/kernel.h> /* General definitions */ #define PKT_TYPE_LACPDU cpu_to_be16(ETH_P_SLOW) @@ -283,7 +284,7 @@ static inline const char *bond_3ad_churn_desc(churn_state_t state) "none", "unknown" }; - int max_size = sizeof(churn_description) / sizeof(churn_description[0]); + int max_size = ARRAY_SIZE(churn_description); if (state >= max_size) state = max_size - 1; diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c index 825b8e01f947..9e4e1dc89e29 100644 --- a/net/ipv6/seg6_local.c +++ b/net/ipv6/seg6_local.c @@ -31,6 +31,7 @@ #include <net/seg6_hmac.h> #endif #include <linux/etherdevice.h> +#include <linux/kernel.h> struct seg6_local_lwt; @@ -499,10 +500,9 @@ static struct seg6_action_desc seg6_action_table[] = { static struct seg6_action_desc *__get_action_desc(int action) { struct seg6_action_desc *desc; - int i, count; + int i; - count = sizeof(seg6_action_table) / sizeof(struct seg6_action_desc); - for (i = 0; i < count; i++) { + for (i = 0; i < ARRAY_SIZE(seg6_action_table); i++) { desc = &seg6_action_table[i]; if (desc->action == action) return desc; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 05/18] net: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-02 13:07 ` Andy Shevchenko 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-02 13:46 ` Kalle Valo 1 sibling, 1 reply; 51+ messages in thread From: Andy Shevchenko @ 2017-10-02 13:07 UTC (permalink / raw) To: Jérémy Lefaure Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Kalle Valo, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev, linux-kernel@vger.kernel.org, intel-wired-lan, USB, open list:TI WILINK WIRELES..., open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, brcm80211-dev-list On Sun, Oct 1, 2017 at 10:30 PM, Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time. > > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192, > + 32}, For all such cases I would rather put on one line disregard checkpatch warning for better readability. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 05/18] net: use ARRAY_SIZE 2017-10-02 13:07 ` Andy Shevchenko @ 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-03 8:09 ` Andy Shevchenko 0 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-03 1:22 UTC (permalink / raw) To: Andy Shevchenko Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Kalle Valo, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev, linux-kernel@vger.kernel.org, intel-wired-lan, USB, open list:TI WILINK WIRELES..., open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, brcm80211-dev-list On Mon, 2 Oct 2017 16:07:36 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192, > > + 32}, > > For all such cases I would rather put on one line disregard checkpatch > warning for better readability. I agree that it would be better. I didn't know that it was possible to not follow this rule for anything else than a string. I am waiting for more comments and I will send a v2. Thank you, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 05/18] net: use ARRAY_SIZE 2017-10-03 1:22 ` Jérémy Lefaure @ 2017-10-03 8:09 ` Andy Shevchenko 0 siblings, 0 replies; 51+ messages in thread From: Andy Shevchenko @ 2017-10-03 8:09 UTC (permalink / raw) To: Jérémy Lefaure Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Kalle Valo, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev, linux-kernel@vger.kernel.org, intel-wired-lan, USB, open list:TI WILINK WIRELES..., open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, brcm80211-dev-list On Tue, Oct 3, 2017 at 4:22 AM, Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > On Mon, 2 Oct 2017 16:07:36 +0300 > Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > >> > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192, >> > + 32}, >> >> For all such cases I would rather put on one line disregard checkpatch >> warning for better readability. > I agree that it would be better. I didn't know that it was possible to > not follow this rule for anything else than a string. IMO, it increases readability quite enough to overrule checkpatch recomendation. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 05/18] net: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure 2017-10-02 13:07 ` Andy Shevchenko @ 2017-10-02 13:46 ` Kalle Valo 2017-10-03 1:23 ` Jérémy Lefaure 1 sibling, 1 reply; 51+ messages in thread From: Kalle Valo @ 2017-10-02 13:46 UTC (permalink / raw) To: Jérémy Lefaure Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev, linux-kernel, intel-wired-lan, linux-usb, linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> writes: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > drivers/net/ethernet/emulex/benet/be_cmds.c | 4 +- > drivers/net/ethernet/intel/i40e/i40e_adminq.h | 3 +- > drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 3 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +- > drivers/net/ethernet/intel/ixgbevf/vf.c | 17 +- > drivers/net/usb/kalmia.c | 9 +- > .../broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 473 ++++++--------------- > .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 9 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 12 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/table.c | 14 +- > .../net/wireless/realtek/rtlwifi/rtl8821ae/table.c | 34 +- > include/net/bond_3ad.h | 3 +- > net/ipv6/seg6_local.c | 6 +- > 13 files changed, 177 insertions(+), 413 deletions(-) We have a tree for wireless so usually it's better to submit wireless changes on their own but here I assume Dave will apply this to his tree. If not, please resubmit the wireless part in a separate patch. -- Kalle Valo ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 05/18] net: use ARRAY_SIZE 2017-10-02 13:46 ` Kalle Valo @ 2017-10-03 1:23 ` Jérémy Lefaure 0 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-03 1:23 UTC (permalink / raw) To: Kalle Valo Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna, Somnath Kotur, Jeff Kirsher, Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng, Larry Finger, Chaoming Li, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev, linux-kernel, intel-wired-lan, linux-usb, linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list On Mon, 02 Oct 2017 16:46:29 +0300 Kalle Valo <kvalo@codeaurora.org> wrote: > We have a tree for wireless so usually it's better to submit wireless > changes on their own but here I assume Dave will apply this to his tree. > If not, please resubmit the wireless part in a separate patch. Ok, I note that. I'll wait Dave's answer and I'll split this patch if needed. Thank you, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 06/18] drm: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (4 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 7:43 ` Jani Nikula 2017-10-02 8:27 ` Thierry Reding 2017-10-01 19:30 ` [PATCH 07/18] scsi: bfa: " Jérémy Lefaure ` (12 subsequent siblings) 18 siblings, 2 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Alex Deucher, Christian König, David Airlie, Patrik Jakobsson, Zhenyu Wang, Zhi Wang, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Ben Skeggs Cc: Jérémy Lefaure, amd-gfx, dri-devel, linux-kernel, intel-gvt-dev, intel-gfx, nouveau Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time nor to re-invent the ARRAY_SIZE macro. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 9 +++++---- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 9 +++++---- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 9 ++++----- drivers/gpu/drm/i915/gvt/vgpu.c | 3 ++- drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 7 ++++--- drivers/gpu/drm/via/via_verifier.c | 10 ++++------ 6 files changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index dfc10b1baea0..304862e2a8a6 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -20,6 +20,7 @@ * OTHER DEALINGS IN THE SOFTWARE. * */ +#include <linux/kernel.h> #include <linux/firmware.h> #include <drm/drmP.h> #include "amdgpu.h" @@ -3952,10 +3953,10 @@ static int gfx_v8_0_init_save_restore_list(struct amdgpu_device *adev) adev->gfx.rlc.reg_list_format_size_bytes >> 2, unique_indices, &indices_count, - sizeof(unique_indices) / sizeof(int), + ARRAY_SIZE(unique_indices), indirect_start_offsets, &offset_count, - sizeof(indirect_start_offsets)/sizeof(int)); + ARRAY_SIZE(indirect_start_offsets)); /* save and restore list */ WREG32_FIELD(RLC_SRM_CNTL, AUTO_INCR_ADDR, 1); @@ -3977,14 +3978,14 @@ static int gfx_v8_0_init_save_restore_list(struct amdgpu_device *adev) /* starting offsets starts */ WREG32(mmRLC_GPM_SCRATCH_ADDR, adev->gfx.rlc.starting_offsets_start); - for (i = 0; i < sizeof(indirect_start_offsets)/sizeof(int); i++) + for (i = 0; i < ARRAY_SIZE(indirect_start_offsets); i++) WREG32(mmRLC_GPM_SCRATCH_DATA, indirect_start_offsets[i]); /* unique indices */ temp = mmRLC_SRM_INDEX_CNTL_ADDR_0; data = mmRLC_SRM_INDEX_CNTL_DATA_0; - for (i = 0; i < sizeof(unique_indices) / sizeof(int); i++) { + for (i = 0; i < ARRAY_SIZE(unique_indices); i++) { if (unique_indices[i] != 0) { WREG32(temp + i, unique_indices[i] & 0x3FFFF); WREG32(data + i, unique_indices[i] >> 20); diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index deeaee1457ef..180726f4f34e 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -20,6 +20,7 @@ * OTHER DEALINGS IN THE SOFTWARE. * */ +#include <linux/kernel.h> #include <linux/firmware.h> #include <drm/drmP.h> #include "amdgpu.h" @@ -1730,10 +1731,10 @@ static int gfx_v9_0_init_rlc_save_restore_list(struct amdgpu_device *adev) adev->gfx.rlc.reg_list_format_size_bytes >> 2, unique_indirect_regs, &unique_indirect_reg_count, - sizeof(unique_indirect_regs)/sizeof(int), + ARRAY_SIZE(unique_indirect_regs), indirect_start_offsets, &indirect_start_offsets_count, - sizeof(indirect_start_offsets)/sizeof(int)); + ARRAY_SIZE(indirect_start_offsets)); /* enable auto inc in case it is disabled */ tmp = RREG32(SOC15_REG_OFFSET(GC, 0, mmRLC_SRM_CNTL)); @@ -1770,12 +1771,12 @@ static int gfx_v9_0_init_rlc_save_restore_list(struct amdgpu_device *adev) /* write the starting offsets to RLC scratch ram */ WREG32(SOC15_REG_OFFSET(GC, 0, mmRLC_GPM_SCRATCH_ADDR), adev->gfx.rlc.starting_offsets_start); - for (i = 0; i < sizeof(indirect_start_offsets)/sizeof(int); i++) + for (i = 0; i < ARRAY_SIZE(indirect_start_offsets); i++) WREG32(SOC15_REG_OFFSET(GC, 0, mmRLC_GPM_SCRATCH_DATA), indirect_start_offsets[i]); /* load unique indirect regs*/ - for (i = 0; i < sizeof(unique_indirect_regs)/sizeof(int); i++) { + for (i = 0; i < ARRAY_SIZE(unique_indirect_regs); i++) { WREG32(SOC15_REG_OFFSET(GC, 0, mmRLC_SRM_INDEX_CNTL_ADDR_0) + i, unique_indirect_regs[i] & 0x3FFFF); WREG32(SOC15_REG_OFFSET(GC, 0, mmRLC_SRM_INDEX_CNTL_DATA_0) + i, diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index e787d376ba67..84507912be84 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -37,6 +37,7 @@ #include "psb_drv.h" #include "psb_intel_sdvo_regs.h" #include "psb_intel_reg.h" +#include <linux/kernel.h> #define SDVO_TMDS_MASK (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_TMDS1) #define SDVO_RGB_MASK (SDVO_OUTPUT_RGB0 | SDVO_OUTPUT_RGB1) @@ -62,8 +63,6 @@ static const char *tv_format_names[] = { "SECAM_60" }; -#define TV_FORMAT_NUM (sizeof(tv_format_names) / sizeof(*tv_format_names)) - struct psb_intel_sdvo { struct gma_encoder base; @@ -148,7 +147,7 @@ struct psb_intel_sdvo_connector { int force_audio; /* This contains all current supported TV format */ - u8 tv_format_supported[TV_FORMAT_NUM]; + u8 tv_format_supported[ARRAY_SIZE(tv_format_names)]; int format_supported_num; struct drm_property *tv_format; @@ -1709,7 +1708,7 @@ psb_intel_sdvo_set_property(struct drm_connector *connector, } if (property == psb_intel_sdvo_connector->tv_format) { - if (val >= TV_FORMAT_NUM) + if (val >= ARRAY_SIZE(tv_format_names)) return -EINVAL; if (psb_intel_sdvo->tv_format_index == @@ -2269,7 +2268,7 @@ static bool psb_intel_sdvo_tv_create_property(struct psb_intel_sdvo *psb_intel_s return false; psb_intel_sdvo_connector->format_supported_num = 0; - for (i = 0 ; i < TV_FORMAT_NUM; i++) + for (i = 0 ; i < ARRAY_SIZE(tv_format_names); i++) if (format_map & (1 << i)) psb_intel_sdvo_connector->tv_format_supported[psb_intel_sdvo_connector->format_supported_num++] = i; diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index 02c61a1ad56a..9c6d2849c5b7 100644 --- a/drivers/gpu/drm/i915/gvt/vgpu.c +++ b/drivers/gpu/drm/i915/gvt/vgpu.c @@ -31,6 +31,7 @@ * */ +#include <linux/kernel.h> #include "i915_drv.h" #include "gvt.h" #include "i915_pvinfo.h" @@ -116,7 +117,7 @@ int intel_gvt_init_vgpu_types(struct intel_gvt *gvt) */ low_avail = gvt_aperture_sz(gvt) - HOST_LOW_GM_SIZE; high_avail = gvt_hidden_sz(gvt) - HOST_HIGH_GM_SIZE; - num_types = sizeof(vgpu_types) / sizeof(vgpu_types[0]); + num_types = ARRAY_SIZE(vgpu_types); gvt->types = kzalloc(num_types * sizeof(struct intel_vgpu_type), GFP_KERNEL); diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c index b58ee99f7bfc..9cc10e438b3d 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c @@ -36,6 +36,8 @@ #include <subdev/i2c.h> #include <subdev/vga.h> +#include <linux/kernel.h> + #define bioslog(lvl, fmt, args...) do { \ nvkm_printk(init->subdev, lvl, info, "0x%08x[%c]: "fmt, \ init->offset, init_exec(init) ? \ @@ -2271,8 +2273,6 @@ static struct nvbios_init_opcode { [0xaa] = { init_reserved }, }; -#define init_opcode_nr (sizeof(init_opcode) / sizeof(init_opcode[0])) - int nvbios_exec(struct nvbios_init *init) { @@ -2281,7 +2281,8 @@ nvbios_exec(struct nvbios_init *init) init->nested++; while (init->offset) { u8 opcode = nvbios_rd08(bios, init->offset); - if (opcode >= init_opcode_nr || !init_opcode[opcode].exec) { + if (opcode >= ARRAY_SIZE(init_opcode) || + !init_opcode[opcode].exec) { error("unknown opcode 0x%02x\n", opcode); return -EINVAL; } diff --git a/drivers/gpu/drm/via/via_verifier.c b/drivers/gpu/drm/via/via_verifier.c index 0677bbf4ec7e..fb2609434df7 100644 --- a/drivers/gpu/drm/via/via_verifier.c +++ b/drivers/gpu/drm/via/via_verifier.c @@ -34,6 +34,7 @@ #include <drm/drm_legacy.h> #include "via_verifier.h" #include "via_drv.h" +#include <linux/kernel.h> typedef enum { state_command, @@ -1102,10 +1103,7 @@ setup_hazard_table(hz_init_t init_table[], hazard_t table[], int size) void via_init_command_verifier(void) { - setup_hazard_table(init_table1, table1, - sizeof(init_table1) / sizeof(hz_init_t)); - setup_hazard_table(init_table2, table2, - sizeof(init_table2) / sizeof(hz_init_t)); - setup_hazard_table(init_table3, table3, - sizeof(init_table3) / sizeof(hz_init_t)); + setup_hazard_table(init_table1, table1, ARRAY_SIZE(init_table1)); + setup_hazard_table(init_table2, table2, ARRAY_SIZE(init_table2)); + setup_hazard_table(init_table3, table3, ARRAY_SIZE(init_table3)); } -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 06/18] drm: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure @ 2017-10-02 7:43 ` Jani Nikula 2017-10-02 8:27 ` Thierry Reding 1 sibling, 0 replies; 51+ messages in thread From: Jani Nikula @ 2017-10-02 7:43 UTC (permalink / raw) To: Jérémy Lefaure, Alex Deucher, Christian König, David Airlie, Patrik Jakobsson, Zhenyu Wang, Zhi Wang, Joonas Lahtinen, Rodrigo Vivi, Ben Skeggs Cc: Jérémy Lefaure, amd-gfx, dri-devel, linux-kernel, intel-gvt-dev, intel-gfx, nouveau On Sun, 01 Oct 2017, Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time nor to re-invent the ARRAY_SIZE macro. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Please split this up. Patch 1: > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 9 +++++---- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 9 +++++---- Patch 2: > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 9 ++++----- Patch 3: > drivers/gpu/drm/i915/gvt/vgpu.c | 3 ++- Patch 4: > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 7 ++++--- Patch 5: > drivers/gpu/drm/via/via_verifier.c | 10 ++++------ BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 06/18] drm: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure 2017-10-02 7:43 ` Jani Nikula @ 2017-10-02 8:27 ` Thierry Reding 1 sibling, 0 replies; 51+ messages in thread From: Thierry Reding @ 2017-10-02 8:27 UTC (permalink / raw) To: Jérémy Lefaure Cc: Alex Deucher, Christian König, David Airlie, Patrik Jakobsson, Zhenyu Wang, Zhi Wang, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Ben Skeggs, amd-gfx, dri-devel, linux-kernel, intel-gvt-dev, intel-gfx, nouveau [-- Attachment #1: Type: text/plain, Size: 1109 bytes --] On Sun, Oct 01, 2017 at 03:30:44PM -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time nor to re-invent the ARRAY_SIZE macro. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 9 +++++---- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 9 +++++---- > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 9 ++++----- > drivers/gpu/drm/i915/gvt/vgpu.c | 3 ++- > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 7 ++++--- > drivers/gpu/drm/via/via_verifier.c | 10 ++++------ > 6 files changed, 24 insertions(+), 23 deletions(-) Reviewed-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 07/18] scsi: bfa: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (5 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure ` (11 subsequent siblings) 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Anil Gurumurthy, Sudarsana Kalluru, James E.J. Bottomley, Martin K. Petersen Cc: Jérémy Lefaure, linux-scsi, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/scsi/bfa/bfa_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfa_core.c b/drivers/scsi/bfa/bfa_core.c index 3e1caec82554..4a03cd9fa63f 100644 --- a/drivers/scsi/bfa/bfa_core.c +++ b/drivers/scsi/bfa/bfa_core.c @@ -16,6 +16,7 @@ * General Public License for more details. */ +#include <linux/kernel.h> #include "bfad_drv.h" #include "bfa_modules.h" #include "bfi_reg.h" @@ -1957,7 +1958,7 @@ bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids) {BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT_FC}, }; - *npciids = sizeof(__pciids) / sizeof(__pciids[0]); + *npciids = ARRAY_SIZE(__pciids); *pciids = __pciids; } -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 08/18] ecryptfs: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (6 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 07/18] scsi: bfa: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-14 1:31 ` Tyler Hicks 2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure ` (10 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Tyler Hicks; +Cc: Jérémy Lefaure, ecryptfs, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- fs/ecryptfs/crypto.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 7acd57da4f14..2e78e851788e 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -36,6 +36,7 @@ #include <linux/scatterlist.h> #include <linux/slab.h> #include <asm/unaligned.h> +#include <linux/kernel.h> #include "ecryptfs_kernel.h" #define DECRYPT 0 @@ -884,8 +885,7 @@ static int ecryptfs_process_flags(struct ecryptfs_crypt_stat *crypt_stat, u32 flags; flags = get_unaligned_be32(page_virt); - for (i = 0; i < ((sizeof(ecryptfs_flag_map) - / sizeof(struct ecryptfs_flag_map_elem))); i++) + for (i = 0; i < ARRAY_SIZE(ecryptfs_flag_map); i++) if (flags & ecryptfs_flag_map[i].file_flag) { crypt_stat->flags |= ecryptfs_flag_map[i].local_flag; } else @@ -922,8 +922,7 @@ void ecryptfs_write_crypt_stat_flags(char *page_virt, u32 flags = 0; int i; - for (i = 0; i < ((sizeof(ecryptfs_flag_map) - / sizeof(struct ecryptfs_flag_map_elem))); i++) + for (i = 0; i < ARRAY_SIZE(ecryptfs_flag_map); i++) if (crypt_stat->flags & ecryptfs_flag_map[i].local_flag) flags |= ecryptfs_flag_map[i].file_flag; /* Version is in top 8 bits of the 32-bit flag vector */ -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 08/18] ecryptfs: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure @ 2017-10-14 1:31 ` Tyler Hicks 0 siblings, 0 replies; 51+ messages in thread From: Tyler Hicks @ 2017-10-14 1:31 UTC (permalink / raw) To: Jérémy Lefaure; +Cc: ecryptfs, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1898 bytes --] On 10/01/2017 03:30 PM, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Hey Jérémy - Thanks for the nice cleanup. I'll get it into 4.15. Tyler > --- > fs/ecryptfs/crypto.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c > index 7acd57da4f14..2e78e851788e 100644 > --- a/fs/ecryptfs/crypto.c > +++ b/fs/ecryptfs/crypto.c > @@ -36,6 +36,7 @@ > #include <linux/scatterlist.h> > #include <linux/slab.h> > #include <asm/unaligned.h> > +#include <linux/kernel.h> > #include "ecryptfs_kernel.h" > > #define DECRYPT 0 > @@ -884,8 +885,7 @@ static int ecryptfs_process_flags(struct ecryptfs_crypt_stat *crypt_stat, > u32 flags; > > flags = get_unaligned_be32(page_virt); > - for (i = 0; i < ((sizeof(ecryptfs_flag_map) > - / sizeof(struct ecryptfs_flag_map_elem))); i++) > + for (i = 0; i < ARRAY_SIZE(ecryptfs_flag_map); i++) > if (flags & ecryptfs_flag_map[i].file_flag) { > crypt_stat->flags |= ecryptfs_flag_map[i].local_flag; > } else > @@ -922,8 +922,7 @@ void ecryptfs_write_crypt_stat_flags(char *page_virt, > u32 flags = 0; > int i; > > - for (i = 0; i < ((sizeof(ecryptfs_flag_map) > - / sizeof(struct ecryptfs_flag_map_elem))); i++) > + for (i = 0; i < ARRAY_SIZE(ecryptfs_flag_map); i++) > if (crypt_stat->flags & ecryptfs_flag_map[i].local_flag) > flags |= ecryptfs_flag_map[i].file_flag; > /* Version is in top 8 bits of the 32-bit flag vector */ > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 09/18] nfsd: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (7 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 11:03 ` Jeff Layton 2017-10-01 19:30 ` [PATCH 10/18] orangefs: " Jérémy Lefaure ` (9 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: J. Bruce Fields, Jeff Layton Cc: Jérémy Lefaure, linux-nfs, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- fs/nfsd/fault_inject.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c index 34c1c449fddf..3ec72c931ac5 100644 --- a/fs/nfsd/fault_inject.c +++ b/fs/nfsd/fault_inject.c @@ -11,6 +11,7 @@ #include <linux/nsproxy.h> #include <linux/sunrpc/addr.h> #include <linux/uaccess.h> +#include <linux/kernel.h> #include "state.h" #include "netns.h" @@ -125,8 +126,6 @@ static struct nfsd_fault_inject_op inject_ops[] = { }, }; -#define NUM_INJECT_OPS (sizeof(inject_ops)/sizeof(struct nfsd_fault_inject_op)) - int nfsd_fault_inject_init(void) { unsigned int i; @@ -137,7 +136,7 @@ int nfsd_fault_inject_init(void) if (!debug_dir) goto fail; - for (i = 0; i < NUM_INJECT_OPS; i++) { + for (i = 0; i < ARRAY_SIZE(inject_ops); i++) { op = &inject_ops[i]; if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) goto fail; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 09/18] nfsd: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure @ 2017-10-02 11:03 ` Jeff Layton 0 siblings, 0 replies; 51+ messages in thread From: Jeff Layton @ 2017-10-02 11:03 UTC (permalink / raw) To: Jérémy Lefaure, J. Bruce Fields; +Cc: linux-nfs, linux-kernel On Sun, 2017-10-01 at 15:30 -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > > > > (sizeof(E)@p /sizeof(E[...])) > > > > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > --- > fs/nfsd/fault_inject.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c > index 34c1c449fddf..3ec72c931ac5 100644 > --- a/fs/nfsd/fault_inject.c > +++ b/fs/nfsd/fault_inject.c > @@ -11,6 +11,7 @@ > #include <linux/nsproxy.h> > #include <linux/sunrpc/addr.h> > #include <linux/uaccess.h> > +#include <linux/kernel.h> > > #include "state.h" > #include "netns.h" > @@ -125,8 +126,6 @@ static struct nfsd_fault_inject_op inject_ops[] = > { > }, > }; > > -#define NUM_INJECT_OPS (sizeof(inject_ops)/sizeof(struct > nfsd_fault_inject_op)) > - > int nfsd_fault_inject_init(void) > { > unsigned int i; > @@ -137,7 +136,7 @@ int nfsd_fault_inject_init(void) > if (!debug_dir) > goto fail; > > - for (i = 0; i < NUM_INJECT_OPS; i++) { > + for (i = 0; i < ARRAY_SIZE(inject_ops); i++) { > op = &inject_ops[i]; > if (!debugfs_create_file(op->file, mode, debug_dir, > op, &fops_nfsd)) > goto fail; Reviewed-by: Jeff Layton <jlayton@redhat.com> ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 10/18] orangefs: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (8 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 11/18] dm space map metadata: " Jérémy Lefaure ` (8 subsequent siblings) 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Mike Marshall; +Cc: Jérémy Lefaure, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- fs/orangefs/orangefs-debug.h | 4 +++- fs/orangefs/orangefs-utils.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/orangefs/orangefs-debug.h b/fs/orangefs/orangefs-debug.h index 387db17cde2b..af1ec4e809e2 100644 --- a/fs/orangefs/orangefs-debug.h +++ b/fs/orangefs/orangefs-debug.h @@ -14,8 +14,10 @@ #ifdef __KERNEL__ #include <linux/types.h> +#include <linux/kernel.h> #else #include <stdint.h> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) #endif #define GOSSIP_NO_DEBUG (__u64)0 @@ -87,6 +89,6 @@ static struct __keyword_mask_s s_kmod_keyword_mask_map[] = { }; static const int num_kmod_keyword_mask_map = (int) - (sizeof(s_kmod_keyword_mask_map) / sizeof(struct __keyword_mask_s)); + (ARRAY_SIZE(s_kmod_keyword_mask_map)); #endif /* __ORANGEFS_DEBUG_H */ diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c index aab6f1842963..d1fe32e4ffb3 100644 --- a/fs/orangefs/orangefs-utils.c +++ b/fs/orangefs/orangefs-utils.c @@ -3,6 +3,7 @@ * * See COPYING in top-level directory. */ +#include <linux/kernel.h> #include "protocol.h" #include "orangefs-kernel.h" #include "orangefs-dev-proto.h" @@ -605,7 +606,7 @@ int orangefs_normalize_to_errno(__s32 error_code) /* Convert ORANGEFS encoded errno values into regular errno values. */ } else if ((-error_code) & ORANGEFS_ERROR_BIT) { i = (-error_code) & ~(ORANGEFS_ERROR_BIT|ORANGEFS_ERROR_CLASS_BITS); - if (i < sizeof(PINT_errno_mapping)/sizeof(*PINT_errno_mapping)) + if (i < ARRAY_SIZE(PINT_errno_mapping)) error_code = -PINT_errno_mapping[i]; else error_code = -EINVAL; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 11/18] dm space map metadata: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (9 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 10/18] orangefs: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure ` (7 subsequent siblings) 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Alasdair Kergon, Mike Snitzer, dm-devel, Shaohua Li Cc: Jérémy Lefaure, linux-raid, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/md/persistent-data/dm-space-map-metadata.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/persistent-data/dm-space-map-metadata.c b/drivers/md/persistent-data/dm-space-map-metadata.c index 4aed69d9dd17..aec449243966 100644 --- a/drivers/md/persistent-data/dm-space-map-metadata.c +++ b/drivers/md/persistent-data/dm-space-map-metadata.c @@ -11,6 +11,7 @@ #include <linux/list.h> #include <linux/slab.h> #include <linux/device-mapper.h> +#include <linux/kernel.h> #define DM_MSG_PREFIX "space map metadata" @@ -111,7 +112,7 @@ static bool brb_empty(struct bop_ring_buffer *brb) static unsigned brb_next(struct bop_ring_buffer *brb, unsigned old) { unsigned r = old + 1; - return (r >= (sizeof(brb->bops) / sizeof(*brb->bops))) ? 0 : r; + return r >= ARRAY_SIZE(brb->bops) ? 0 : r; } static int brb_push(struct bop_ring_buffer *brb, -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 12/18] x86: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (10 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 11/18] dm space map metadata: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-19 14:18 ` [tip:x86/cleanups] x86: Use ARRAY_SIZE tip-bot for Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure ` (6 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Martin Mares, H. Peter Anvin, Thomas Gleixner, Ingo Molnar, x86, Andy Lutomirski Cc: Jérémy Lefaure, linux-video, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- arch/x86/boot/video-vga.c | 6 +++--- arch/x86/entry/vdso/vdso2c.c | 3 ++- arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c | 5 ++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/boot/video-vga.c b/arch/x86/boot/video-vga.c index 45bc9402aa49..a14c5178d4ba 100644 --- a/arch/x86/boot/video-vga.c +++ b/arch/x86/boot/video-vga.c @@ -241,9 +241,9 @@ static int vga_probe(void) vga_modes, }; static int mode_count[] = { - sizeof(cga_modes)/sizeof(struct mode_info), - sizeof(ega_modes)/sizeof(struct mode_info), - sizeof(vga_modes)/sizeof(struct mode_info), + ARRAY_SIZE(cga_modes), + ARRAY_SIZE(ega_modes), + ARRAY_SIZE(vga_modes), }; struct biosregs ireg, oreg; diff --git a/arch/x86/entry/vdso/vdso2c.c b/arch/x86/entry/vdso/vdso2c.c index 0780a443a53b..4674f58581a1 100644 --- a/arch/x86/entry/vdso/vdso2c.c +++ b/arch/x86/entry/vdso/vdso2c.c @@ -65,6 +65,7 @@ #include <linux/elf.h> #include <linux/types.h> +#include <linux/kernel.h> const char *outfilename; @@ -151,7 +152,7 @@ extern void bad_put_le(void); PLE(x, val, 64, PLE(x, val, 32, PLE(x, val, 16, LAST_PLE(x, val)))) -#define NSYMS (sizeof(required_syms) / sizeof(required_syms[0])) +#define NSYMS ARRAY_SIZE(required_syms) #define BITSFUNC3(name, bits, suffix) name##bits##suffix #define BITSFUNC2(name, bits, suffix) BITSFUNC3(name, bits, suffix) diff --git a/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c b/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c index 74283875c7e8..e639e3116acf 100644 --- a/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c +++ b/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c @@ -62,10 +62,9 @@ static struct platform_device pb_device = { static int __init pb_keys_init(void) { struct gpio_keys_button *gb = gpio_button; - int i, num, good = 0; + int i, good = 0; - num = sizeof(gpio_button) / sizeof(struct gpio_keys_button); - for (i = 0; i < num; i++) { + for (i = 0; i < ARRAY_SIZE(gpio_button); i++) { gb[i].gpio = get_gpio_by_name(gb[i].desc); pr_debug("info[%2d]: name = %s, gpio = %d\n", i, gb[i].desc, gb[i].gpio); -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [tip:x86/cleanups] x86: Use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure @ 2017-10-19 14:18 ` tip-bot for Jérémy Lefaure 0 siblings, 0 replies; 51+ messages in thread From: tip-bot for Jérémy Lefaure @ 2017-10-19 14:18 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, jeremy.lefaure, tglx, hpa, mj, luto, mingo Commit-ID: 0cfe5b5fc0277463fa795dea312a3a2fd5e8bac2 Gitweb: https://git.kernel.org/tip/0cfe5b5fc0277463fa795dea312a3a2fd5e8bac2 Author: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> AuthorDate: Sun, 1 Oct 2017 15:30:50 -0400 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 19 Oct 2017 16:15:47 +0200 x86: Use ARRAY_SIZE Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: linux-video@atrey.karlin.mff.cuni.cz Cc: Martin Mares <mj@ucw.cz> Cc: Andy Lutomirski <luto@amacapital.net> Link: https://lkml.kernel.org/r/20171001193101.8898-13-jeremy.lefaure@lse.epita.fr --- arch/x86/boot/video-vga.c | 6 +++--- arch/x86/entry/vdso/vdso2c.c | 3 ++- arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c | 5 ++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/boot/video-vga.c b/arch/x86/boot/video-vga.c index 45bc940..a14c517 100644 --- a/arch/x86/boot/video-vga.c +++ b/arch/x86/boot/video-vga.c @@ -241,9 +241,9 @@ static int vga_probe(void) vga_modes, }; static int mode_count[] = { - sizeof(cga_modes)/sizeof(struct mode_info), - sizeof(ega_modes)/sizeof(struct mode_info), - sizeof(vga_modes)/sizeof(struct mode_info), + ARRAY_SIZE(cga_modes), + ARRAY_SIZE(ega_modes), + ARRAY_SIZE(vga_modes), }; struct biosregs ireg, oreg; diff --git a/arch/x86/entry/vdso/vdso2c.c b/arch/x86/entry/vdso/vdso2c.c index 0780a44..4674f58 100644 --- a/arch/x86/entry/vdso/vdso2c.c +++ b/arch/x86/entry/vdso/vdso2c.c @@ -65,6 +65,7 @@ #include <linux/elf.h> #include <linux/types.h> +#include <linux/kernel.h> const char *outfilename; @@ -151,7 +152,7 @@ extern void bad_put_le(void); PLE(x, val, 64, PLE(x, val, 32, PLE(x, val, 16, LAST_PLE(x, val)))) -#define NSYMS (sizeof(required_syms) / sizeof(required_syms[0])) +#define NSYMS ARRAY_SIZE(required_syms) #define BITSFUNC3(name, bits, suffix) name##bits##suffix #define BITSFUNC2(name, bits, suffix) BITSFUNC3(name, bits, suffix) diff --git a/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c b/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c index 7428387..e639e31 100644 --- a/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c +++ b/arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c @@ -62,10 +62,9 @@ static struct platform_device pb_device = { static int __init pb_keys_init(void) { struct gpio_keys_button *gb = gpio_button; - int i, num, good = 0; + int i, good = 0; - num = sizeof(gpio_button) / sizeof(struct gpio_keys_button); - for (i = 0; i < num; i++) { + for (i = 0; i < ARRAY_SIZE(gpio_button); i++) { gb[i].gpio = get_gpio_by_name(gb[i].desc); pr_debug("info[%2d]: name = %s, gpio = %d\n", i, gb[i].desc, gb[i].gpio); ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 13/18] tpm: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (11 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-04 12:14 ` Jarkko Sakkinen 2017-10-01 19:30 ` [PATCH 14/18] ipmi: " Jérémy Lefaure ` (5 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe Cc: Jérémy Lefaure, linux-integrity, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/char/tpm/tpm_tis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index ebd0e75a3e4d..e2d1055fb814 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -30,6 +30,7 @@ #include <linux/freezer.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/kernel.h> #include "tpm.h" #include "tpm_tis_core.h" @@ -365,7 +366,7 @@ static struct pnp_driver tis_pnp_driver = { }, }; -#define TIS_HID_USR_IDX sizeof(tpm_pnp_tbl)/sizeof(struct pnp_device_id) -2 +#define TIS_HID_USR_IDX (ARRAY_SIZE(tpm_pnp_tbl) - 2) module_param_string(hid, tpm_pnp_tbl[TIS_HID_USR_IDX].id, sizeof(tpm_pnp_tbl[TIS_HID_USR_IDX].id), 0444); MODULE_PARM_DESC(hid, "Set additional specific HID for this driver to probe"); -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 13/18] tpm: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-04 12:14 ` Jarkko Sakkinen 2017-10-10 20:30 ` Jérémy Lefaure 0 siblings, 1 reply; 51+ messages in thread From: Jarkko Sakkinen @ 2017-10-04 12:14 UTC (permalink / raw) To: Jérémy Lefaure Cc: Peter Huewe, Jason Gunthorpe, linux-integrity, linux-kernel On Sun, Oct 01, 2017 at 03:30:51PM -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko > --- > drivers/char/tpm/tpm_tis.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index ebd0e75a3e4d..e2d1055fb814 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -30,6 +30,7 @@ > #include <linux/freezer.h> > #include <linux/of.h> > #include <linux/of_device.h> > +#include <linux/kernel.h> > #include "tpm.h" > #include "tpm_tis_core.h" > > @@ -365,7 +366,7 @@ static struct pnp_driver tis_pnp_driver = { > }, > }; > > -#define TIS_HID_USR_IDX sizeof(tpm_pnp_tbl)/sizeof(struct pnp_device_id) -2 > +#define TIS_HID_USR_IDX (ARRAY_SIZE(tpm_pnp_tbl) - 2) > module_param_string(hid, tpm_pnp_tbl[TIS_HID_USR_IDX].id, > sizeof(tpm_pnp_tbl[TIS_HID_USR_IDX].id), 0444); > MODULE_PARM_DESC(hid, "Set additional specific HID for this driver to probe"); > -- > 2.14.1 > ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 13/18] tpm: use ARRAY_SIZE 2017-10-04 12:14 ` Jarkko Sakkinen @ 2017-10-10 20:30 ` Jérémy Lefaure 2017-10-11 11:48 ` Jarkko Sakkinen 0 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-10 20:30 UTC (permalink / raw) To: Jarkko Sakkinen Cc: Peter Huewe, Jason Gunthorpe, linux-integrity, linux-kernel On Wed, 4 Oct 2017 15:14:49 +0300 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > On Sun, Oct 01, 2017 at 03:30:51PM -0400, Jérémy Lefaure wrote: > > Using the ARRAY_SIZE macro improves the readability of the code. > > > > Found with Coccinelle with the following semantic patch: > > @r depends on (org || report)@ > > type T; > > T[] E; > > position p; > > @@ > > ( > > (sizeof(E)@p /sizeof(*E)) > > | > > (sizeof(E)@p /sizeof(E[...])) > > | > > (sizeof(E)@p /sizeof(T)) > > ) > > > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Hi Jarkko, This patch is an individual patch, it's not really part of a series (my fault, sorry). Could you apply this patch to your tree ? Thank you, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 13/18] tpm: use ARRAY_SIZE 2017-10-10 20:30 ` Jérémy Lefaure @ 2017-10-11 11:48 ` Jarkko Sakkinen 0 siblings, 0 replies; 51+ messages in thread From: Jarkko Sakkinen @ 2017-10-11 11:48 UTC (permalink / raw) To: Jérémy Lefaure Cc: Peter Huewe, Jason Gunthorpe, linux-integrity, linux-kernel On Tue, Oct 10, 2017 at 04:30:11PM -0400, Jérémy Lefaure wrote: > On Wed, 4 Oct 2017 15:14:49 +0300 > Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > > On Sun, Oct 01, 2017 at 03:30:51PM -0400, Jérémy Lefaure wrote: > > > Using the ARRAY_SIZE macro improves the readability of the code. > > > > > > Found with Coccinelle with the following semantic patch: > > > @r depends on (org || report)@ > > > type T; > > > T[] E; > > > position p; > > > @@ > > > ( > > > (sizeof(E)@p /sizeof(*E)) > > > | > > > (sizeof(E)@p /sizeof(E[...])) > > > | > > > (sizeof(E)@p /sizeof(T)) > > > ) > > > > > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > Hi Jarkko, > This patch is an individual patch, it's not really part of a series > (my fault, sorry). > > Could you apply this patch to your tree ? > > Thank you, > Jérémy It is already applied :-) I'll take it as part of my next pull request. Thank you. /JarkkO ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 14/18] ipmi: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (12 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure ` (4 subsequent siblings) 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Corey Minyard; +Cc: Jérémy Lefaure, openipmi-developer, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. In this case, it's useless to define the macro NUM_PO_FUNCS so let's use ARRAY_SIZE instead. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/char/ipmi/ipmi_poweroff.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c index cd0f41fd4a51..7b36d7550840 100644 --- a/drivers/char/ipmi/ipmi_poweroff.c +++ b/drivers/char/ipmi/ipmi_poweroff.c @@ -40,6 +40,7 @@ #include <linux/kdev_t.h> #include <linux/ipmi.h> #include <linux/ipmi_smi.h> +#include <linux/kernel.h> #define PFX "IPMI poweroff: " @@ -539,8 +540,6 @@ static struct poweroff_function poweroff_functions[] = { .detect = ipmi_chassis_detect, .poweroff_func = ipmi_poweroff_chassis }, }; -#define NUM_PO_FUNCS (sizeof(poweroff_functions) \ - / sizeof(struct poweroff_function)) /* Called on a powerdown request. */ @@ -616,7 +615,7 @@ static void ipmi_po_new_smi(int if_num, struct device *device) /* Scan for a poweroff method */ - for (i = 0; i < NUM_PO_FUNCS; i++) { + for (i = 0; i < ARRAY_SIZE(poweroff_functions); i++) { if (poweroff_functions[i].detect(ipmi_user)) goto found; } -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (13 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 14/18] ipmi: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-02 12:27 ` Rafael J. Wysocki 2017-10-01 19:30 ` [PATCH 16/18] media: staging: atomisp: " Jérémy Lefaure ` (3 subsequent siblings) 18 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Robert Moore, Lv Zheng, Rafael J. Wysocki, Len Brown Cc: Jérémy Lefaure, linux-acpi, devel, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. It is useless to re-invent the ARRAY_SIZE macro so let's use it. It is useless to re-invent the ARRAY_SIZE macro so let's use it. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/acpi/acpica/rsdumpinfo.c | 66 ++++++++++++++++++++-------------------- drivers/acpi/acpica/tbfadt.c | 13 +++----- 2 files changed, 37 insertions(+), 42 deletions(-) diff --git a/drivers/acpi/acpica/rsdumpinfo.c b/drivers/acpi/acpica/rsdumpinfo.c index da150e17795b..2cc52720b705 100644 --- a/drivers/acpi/acpica/rsdumpinfo.c +++ b/drivers/acpi/acpica/rsdumpinfo.c @@ -41,6 +41,7 @@ * POSSIBILITY OF SUCH DAMAGES. */ +#include <linux/kernel.h> #include <acpi/acpi.h> #include "accommon.h" #include "acresrc.h" @@ -51,7 +52,6 @@ ACPI_MODULE_NAME("rsdumpinfo") #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DISASSEMBLER) || defined(ACPI_DEBUGGER) #define ACPI_RSD_OFFSET(f) (u8) ACPI_OFFSET (union acpi_resource_data,f) #define ACPI_PRT_OFFSET(f) (u8) ACPI_OFFSET (struct acpi_pci_routing_table,f) -#define ACPI_RSD_TABLE_SIZE(name) (sizeof(name) / sizeof (struct acpi_rsdump_info)) /******************************************************************************* * * Resource Descriptor info tables @@ -61,7 +61,7 @@ ACPI_MODULE_NAME("rsdumpinfo") * ******************************************************************************/ struct acpi_rsdump_info acpi_rs_dump_irq[7] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_irq), "IRQ", NULL}, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_irq), "IRQ", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(irq.descriptor_length), "Descriptor Length", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(irq.triggering), "Triggering", @@ -77,7 +77,7 @@ struct acpi_rsdump_info acpi_rs_dump_irq[7] = { }; struct acpi_rsdump_info acpi_rs_dump_dma[6] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_dma), "DMA", NULL}, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_dma), "DMA", NULL}, {ACPI_RSD_2BITFLAG, ACPI_RSD_OFFSET(dma.type), "Speed", acpi_gbl_typ_decode}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(dma.bus_master), "Mastering", @@ -91,7 +91,7 @@ struct acpi_rsdump_info acpi_rs_dump_dma[6] = { }; struct acpi_rsdump_info acpi_rs_dump_start_dpf[4] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_start_dpf), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_start_dpf), "Start-Dependent-Functions", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(start_dpf.descriptor_length), "Descriptor Length", NULL}, @@ -102,12 +102,12 @@ struct acpi_rsdump_info acpi_rs_dump_start_dpf[4] = { }; struct acpi_rsdump_info acpi_rs_dump_end_dpf[1] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_end_dpf), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_end_dpf), "End-Dependent-Functions", NULL} }; struct acpi_rsdump_info acpi_rs_dump_io[6] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_io), "I/O", NULL}, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_io), "I/O", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(io.io_decode), "Address Decoding", acpi_gbl_io_decode}, {ACPI_RSD_UINT16, ACPI_RSD_OFFSET(io.minimum), "Address Minimum", NULL}, @@ -118,7 +118,7 @@ struct acpi_rsdump_info acpi_rs_dump_io[6] = { }; struct acpi_rsdump_info acpi_rs_dump_fixed_io[3] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_fixed_io), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_fixed_io), "Fixed I/O", NULL}, {ACPI_RSD_UINT16, ACPI_RSD_OFFSET(fixed_io.address), "Address", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(fixed_io.address_length), @@ -126,7 +126,7 @@ struct acpi_rsdump_info acpi_rs_dump_fixed_io[3] = { }; struct acpi_rsdump_info acpi_rs_dump_vendor[3] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_vendor), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_vendor), "Vendor Specific", NULL}, {ACPI_RSD_UINT16, ACPI_RSD_OFFSET(vendor.byte_length), "Length", NULL}, {ACPI_RSD_LONGLIST, ACPI_RSD_OFFSET(vendor.byte_data[0]), "Vendor Data", @@ -134,12 +134,12 @@ struct acpi_rsdump_info acpi_rs_dump_vendor[3] = { }; struct acpi_rsdump_info acpi_rs_dump_end_tag[1] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_end_tag), "EndTag", + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_end_tag), "EndTag", NULL} }; struct acpi_rsdump_info acpi_rs_dump_memory24[6] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_memory24), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_memory24), "24-Bit Memory Range", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(memory24.write_protect), "Write Protect", acpi_gbl_rw_decode}, @@ -154,7 +154,7 @@ struct acpi_rsdump_info acpi_rs_dump_memory24[6] = { }; struct acpi_rsdump_info acpi_rs_dump_memory32[6] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_memory32), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_memory32), "32-Bit Memory Range", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(memory32.write_protect), "Write Protect", acpi_gbl_rw_decode}, @@ -169,7 +169,7 @@ struct acpi_rsdump_info acpi_rs_dump_memory32[6] = { }; struct acpi_rsdump_info acpi_rs_dump_fixed_memory32[4] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_fixed_memory32), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_fixed_memory32), "32-Bit Fixed Memory Range", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(fixed_memory32.write_protect), "Write Protect", acpi_gbl_rw_decode}, @@ -180,7 +180,7 @@ struct acpi_rsdump_info acpi_rs_dump_fixed_memory32[4] = { }; struct acpi_rsdump_info acpi_rs_dump_address16[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_address16), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_address16), "16-Bit WORD Address Space", NULL}, {ACPI_RSD_ADDRESS, 0, NULL, NULL}, {ACPI_RSD_UINT16, ACPI_RSD_OFFSET(address16.address.granularity), @@ -197,7 +197,7 @@ struct acpi_rsdump_info acpi_rs_dump_address16[8] = { }; struct acpi_rsdump_info acpi_rs_dump_address32[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_address32), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_address32), "32-Bit DWORD Address Space", NULL}, {ACPI_RSD_ADDRESS, 0, NULL, NULL}, {ACPI_RSD_UINT32, ACPI_RSD_OFFSET(address32.address.granularity), @@ -214,7 +214,7 @@ struct acpi_rsdump_info acpi_rs_dump_address32[8] = { }; struct acpi_rsdump_info acpi_rs_dump_address64[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_address64), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_address64), "64-Bit QWORD Address Space", NULL}, {ACPI_RSD_ADDRESS, 0, NULL, NULL}, {ACPI_RSD_UINT64, ACPI_RSD_OFFSET(address64.address.granularity), @@ -231,7 +231,7 @@ struct acpi_rsdump_info acpi_rs_dump_address64[8] = { }; struct acpi_rsdump_info acpi_rs_dump_ext_address64[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_ext_address64), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_ext_address64), "64-Bit Extended Address Space", NULL}, {ACPI_RSD_ADDRESS, 0, NULL, NULL}, {ACPI_RSD_UINT64, ACPI_RSD_OFFSET(ext_address64.address.granularity), @@ -250,7 +250,7 @@ struct acpi_rsdump_info acpi_rs_dump_ext_address64[8] = { }; struct acpi_rsdump_info acpi_rs_dump_ext_irq[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_ext_irq), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_ext_irq), "Extended IRQ", NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(extended_irq.producer_consumer), "Type", acpi_gbl_consume_decode}, @@ -269,7 +269,7 @@ struct acpi_rsdump_info acpi_rs_dump_ext_irq[8] = { }; struct acpi_rsdump_info acpi_rs_dump_generic_reg[6] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_generic_reg), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_generic_reg), "Generic Register", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(generic_reg.space_id), "Space ID", NULL}, @@ -283,7 +283,7 @@ struct acpi_rsdump_info acpi_rs_dump_generic_reg[6] = { }; struct acpi_rsdump_info acpi_rs_dump_gpio[16] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_gpio), "GPIO", NULL}, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_gpio), "GPIO", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(gpio.revision_id), "RevisionId", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(gpio.connection_type), "ConnectionType", acpi_gbl_ct_decode}, @@ -315,7 +315,7 @@ struct acpi_rsdump_info acpi_rs_dump_gpio[16] = { }; struct acpi_rsdump_info acpi_rs_dump_pin_function[10] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_pin_function), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_pin_function), "PinFunction", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(pin_function.revision_id), "RevisionId", NULL}, @@ -338,7 +338,7 @@ struct acpi_rsdump_info acpi_rs_dump_pin_function[10] = { }; struct acpi_rsdump_info acpi_rs_dump_pin_config[11] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_pin_config), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_pin_config), "PinConfig", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(pin_config.revision_id), "RevisionId", NULL}, @@ -363,7 +363,7 @@ struct acpi_rsdump_info acpi_rs_dump_pin_config[11] = { }; struct acpi_rsdump_info acpi_rs_dump_pin_group[8] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_pin_group), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_pin_group), "PinGroup", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(pin_group.revision_id), "RevisionId", NULL}, @@ -382,7 +382,7 @@ struct acpi_rsdump_info acpi_rs_dump_pin_group[8] = { }; struct acpi_rsdump_info acpi_rs_dump_pin_group_function[9] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_pin_group_function), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_pin_group_function), "PinGroupFunction", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(pin_group_function.revision_id), "RevisionId", NULL}, @@ -405,7 +405,7 @@ struct acpi_rsdump_info acpi_rs_dump_pin_group_function[9] = { }; struct acpi_rsdump_info acpi_rs_dump_pin_group_config[10] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_pin_group_config), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_pin_group_config), "PinGroupConfig", NULL}, {ACPI_RSD_UINT8, ACPI_RSD_OFFSET(pin_group_config.revision_id), "RevisionId", NULL}, @@ -429,7 +429,7 @@ struct acpi_rsdump_info acpi_rs_dump_pin_group_config[10] = { }; struct acpi_rsdump_info acpi_rs_dump_fixed_dma[4] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_fixed_dma), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_fixed_dma), "FixedDma", NULL}, {ACPI_RSD_UINT16, ACPI_RSD_OFFSET(fixed_dma.request_lines), "RequestLines", NULL}, @@ -452,13 +452,13 @@ struct acpi_rsdump_info acpi_rs_dump_fixed_dma[4] = { {ACPI_RSD_SHORTLISTX,ACPI_RSD_OFFSET (common_serial_bus.vendor_data), "VendorData", NULL}, struct acpi_rsdump_info acpi_rs_dump_common_serial_bus[11] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_common_serial_bus), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_common_serial_bus), "Common Serial Bus", NULL}, ACPI_RS_DUMP_COMMON_SERIAL_BUS }; struct acpi_rsdump_info acpi_rs_dump_i2c_serial_bus[14] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_i2c_serial_bus), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_i2c_serial_bus), "I2C Serial Bus", NULL}, ACPI_RS_DUMP_COMMON_SERIAL_BUS {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(i2c_serial_bus. @@ -471,7 +471,7 @@ struct acpi_rsdump_info acpi_rs_dump_i2c_serial_bus[14] = { }; struct acpi_rsdump_info acpi_rs_dump_spi_serial_bus[18] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_spi_serial_bus), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_spi_serial_bus), "Spi Serial Bus", NULL}, ACPI_RS_DUMP_COMMON_SERIAL_BUS {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(spi_serial_bus. @@ -492,7 +492,7 @@ struct acpi_rsdump_info acpi_rs_dump_spi_serial_bus[18] = { }; struct acpi_rsdump_info acpi_rs_dump_uart_serial_bus[20] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_uart_serial_bus), + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_uart_serial_bus), "Uart Serial Bus", NULL}, ACPI_RS_DUMP_COMMON_SERIAL_BUS {ACPI_RSD_2BITFLAG, ACPI_RSD_OFFSET(uart_serial_bus. @@ -520,7 +520,7 @@ struct acpi_rsdump_info acpi_rs_dump_uart_serial_bus[20] = { * Tables used for common address descriptor flag fields */ struct acpi_rsdump_info acpi_rs_dump_general_flags[5] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_general_flags), NULL, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_general_flags), NULL, NULL}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(address.producer_consumer), "Consumer/Producer", acpi_gbl_consume_decode}, @@ -533,7 +533,7 @@ struct acpi_rsdump_info acpi_rs_dump_general_flags[5] = { }; struct acpi_rsdump_info acpi_rs_dump_memory_flags[5] = { - {ACPI_RSD_LITERAL, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_memory_flags), + {ACPI_RSD_LITERAL, ARRAY_SIZE(acpi_rs_dump_memory_flags), "Resource Type", (void *)"Memory Range"}, {ACPI_RSD_1BITFLAG, ACPI_RSD_OFFSET(address.info.mem.write_protect), "Write Protect", acpi_gbl_rw_decode}, @@ -546,7 +546,7 @@ struct acpi_rsdump_info acpi_rs_dump_memory_flags[5] = { }; struct acpi_rsdump_info acpi_rs_dump_io_flags[4] = { - {ACPI_RSD_LITERAL, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_io_flags), + {ACPI_RSD_LITERAL, ARRAY_SIZE(acpi_rs_dump_io_flags), "Resource Type", (void *)"I/O Range"}, {ACPI_RSD_2BITFLAG, ACPI_RSD_OFFSET(address.info.io.range_type), "Range Type", acpi_gbl_rng_decode}, @@ -560,7 +560,7 @@ struct acpi_rsdump_info acpi_rs_dump_io_flags[4] = { * Table used to dump _PRT contents */ struct acpi_rsdump_info acpi_rs_dump_prt[5] = { - {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_prt), NULL, NULL}, + {ACPI_RSD_TITLE, ARRAY_SIZE(acpi_rs_dump_prt), NULL, NULL}, {ACPI_RSD_UINT64, ACPI_PRT_OFFSET(address), "Address", NULL}, {ACPI_RSD_UINT32, ACPI_PRT_OFFSET(pin), "Pin", NULL}, {ACPI_RSD_STRING, ACPI_PRT_OFFSET(source[0]), "Source", NULL}, diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c index 5f051d82188d..d8322e62bb22 100644 --- a/drivers/acpi/acpica/tbfadt.c +++ b/drivers/acpi/acpica/tbfadt.c @@ -44,6 +44,7 @@ #include <acpi/acpi.h> #include "accommon.h" #include "actables.h" +#include <linux/kernel.h> #define _COMPONENT ACPI_TABLES ACPI_MODULE_NAME("tbfadt") @@ -137,9 +138,6 @@ static struct acpi_fadt_info fadt_info_table[] = { ACPI_FADT_SEPARATE_LENGTH | ACPI_FADT_GPE_REGISTER} }; -#define ACPI_FADT_INFO_ENTRIES \ - (sizeof (fadt_info_table) / sizeof (struct acpi_fadt_info)) - /* Table used to split Event Blocks into separate status/enable registers */ typedef struct acpi_fadt_pm_info { @@ -167,9 +165,6 @@ static struct acpi_fadt_pm_info fadt_pm_info_table[] = { 1} }; -#define ACPI_FADT_PM_INFO_ENTRIES \ - (sizeof (fadt_pm_info_table) / sizeof (struct acpi_fadt_pm_info)) - /******************************************************************************* * * FUNCTION: acpi_tb_init_generic_address @@ -520,7 +515,7 @@ static void acpi_tb_convert_fadt(void) /* Examine all of the 64-bit extended address fields (X fields) */ - for (i = 0; i < ACPI_FADT_INFO_ENTRIES; i++) { + for (i = 0; i < ARRAY_SIZE(fadt_info_table); i++) { /* * Get the 32-bit and 64-bit addresses, as well as the register * length and register name. @@ -686,7 +681,7 @@ static void acpi_tb_setup_fadt_registers(void) * update them if they are incorrect. */ if (acpi_gbl_use_default_register_widths) { - for (i = 0; i < ACPI_FADT_INFO_ENTRIES; i++) { + for (i = 0; i < ARRAY_SIZE(fadt_info_table); i++) { target64 = ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT, @@ -737,7 +732,7 @@ static void acpi_tb_setup_fadt_registers(void) * used. */ - for (i = 0; i < ACPI_FADT_PM_INFO_ENTRIES; i++) { + for (i = 0; i < ARRAY_SIZE(fadt_pm_info_table); i++) { source64 = ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT, fadt_pm_info_table[i].source); -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure @ 2017-10-02 12:27 ` Rafael J. Wysocki 2017-10-03 1:16 ` Jérémy Lefaure 0 siblings, 1 reply; 51+ messages in thread From: Rafael J. Wysocki @ 2017-10-02 12:27 UTC (permalink / raw) To: Jérémy Lefaure Cc: Robert Moore, Lv Zheng, Rafael J. Wysocki, Len Brown, linux-acpi, devel, linux-kernel On Sunday, October 1, 2017 9:30:53 PM CEST Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. It is > useless to re-invent the ARRAY_SIZE macro so let's use it. > > It is useless to re-invent the ARRAY_SIZE macro so let's use it. ACPICA is soewhat special code, though and I'm not taking or ACKing patches for it directly as a rule. For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. Thanks, Rafael ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-02 12:27 ` Rafael J. Wysocki @ 2017-10-03 1:16 ` Jérémy Lefaure 2017-10-03 11:39 ` Rafael J. Wysocki 0 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-03 1:16 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Robert Moore, Lv Zheng, Rafael J. Wysocki, Len Brown, linux-acpi, devel, linux-kernel On Mon, 02 Oct 2017 14:27:52 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > ACPICA is soewhat special code, though and I'm not taking or ACKing patches > for it directly as a rule. > > For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. Why is it special code that can't use ARRAY_SIZE ? Is it because this macro is defined in linux/kernel.h ? Thank you, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-03 1:16 ` Jérémy Lefaure @ 2017-10-03 11:39 ` Rafael J. Wysocki 2017-10-03 12:34 ` [Devel] " Colin Ian King 0 siblings, 1 reply; 51+ messages in thread From: Rafael J. Wysocki @ 2017-10-03 11:39 UTC (permalink / raw) To: Jérémy Lefaure Cc: Robert Moore, Lv Zheng, Rafael J. Wysocki, Len Brown, linux-acpi, devel, linux-kernel On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: > On Mon, 02 Oct 2017 14:27:52 +0200 > "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > > > ACPICA is soewhat special code, though and I'm not taking or ACKing patches > > for it directly as a rule. > > > > For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. > Why is it special code that can't use ARRAY_SIZE ? Is it because this > macro is defined in linux/kernel.h ? Basically, yes. ACPICA is a separate project and the kernel acquires its source code from the upstream (which is used by other OSes too). That is not the case for any other code in the kernel I know about. We strive to keep the ACPICA code in the kernel as close to the upstream as reasonably possible for maintenance reasons, so we avoid doing Linux-specific things in it. As a rule of thumb, if you do cleanups like this one, better avoid the ACPICA code. :-) Thanks, Rafael ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-03 11:39 ` Rafael J. Wysocki @ 2017-10-03 12:34 ` Colin Ian King 2017-10-03 16:04 ` Rafael J. Wysocki 0 siblings, 1 reply; 51+ messages in thread From: Colin Ian King @ 2017-10-03 12:34 UTC (permalink / raw) To: Rafael J. Wysocki, Jérémy Lefaure Cc: Rafael J. Wysocki, linux-kernel, linux-acpi, devel On 03/10/17 12:39, Rafael J. Wysocki wrote: > On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: >> On Mon, 02 Oct 2017 14:27:52 +0200 >> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: >> >>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches >>> for it directly as a rule. >>> >>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. >> Why is it special code that can't use ARRAY_SIZE ? Is it because this >> macro is defined in linux/kernel.h ? However, ACPICA does have ACPI_ARRAY_LENGTH(x), see source/include/actypes.h > > Basically, yes. > > ACPICA is a separate project and the kernel acquires its source code from > the upstream (which is used by other OSes too). That is not the case for > any other code in the kernel I know about. > > > We strive to keep the ACPICA code in the kernel as close to the upstream as > reasonably possible for maintenance reasons, so we avoid doing Linux-specific > things in it. > > As a rule of thumb, if you do cleanups like this one, better avoid the ACPICA > code. :-) > > Thanks, > Rafael > > _______________________________________________ > Devel mailing list > Devel@acpica.org > https://lists.acpica.org/mailman/listinfo/devel > ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-03 12:34 ` [Devel] " Colin Ian King @ 2017-10-03 16:04 ` Rafael J. Wysocki 2017-10-03 16:38 ` Moore, Robert 0 siblings, 1 reply; 51+ messages in thread From: Rafael J. Wysocki @ 2017-10-03 16:04 UTC (permalink / raw) To: Colin Ian King Cc: Rafael J. Wysocki, Jérémy Lefaure, Rafael J. Wysocki, Linux Kernel Mailing List, ACPI Devel Maling List, devel@acpica.org On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King <colin.king@canonical.com> wrote: > On 03/10/17 12:39, Rafael J. Wysocki wrote: >> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: >>> On Mon, 02 Oct 2017 14:27:52 +0200 >>> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: >>> >>>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches >>>> for it directly as a rule. >>>> >>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. >>> Why is it special code that can't use ARRAY_SIZE ? Is it because this >>> macro is defined in linux/kernel.h ? > > However, ACPICA does have ACPI_ARRAY_LENGTH(x), see source/include/actypes.h Fair enough, but that cleanup should go in via ACPICA upstream anyway. Thanks, Rafael ^ permalink raw reply [flat|nested] 51+ messages in thread
* RE: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE 2017-10-03 16:04 ` Rafael J. Wysocki @ 2017-10-03 16:38 ` Moore, Robert 0 siblings, 0 replies; 51+ messages in thread From: Moore, Robert @ 2017-10-03 16:38 UTC (permalink / raw) To: Rafael J. Wysocki, Colin Ian King Cc: Wysocki, Rafael J, Rafael J. Wysocki, Linux Kernel Mailing List, ACPI Devel Maling List, Jérémy Lefaure, devel@acpica.org > -----Original Message----- > From: Devel [mailto:devel-bounces@acpica.org] On Behalf Of Rafael J. > Wysocki > Sent: Tuesday, October 3, 2017 9:05 AM > To: Colin Ian King <colin.king@canonical.com> > Cc: Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Rafael J. Wysocki > <rjw@rjwysocki.net>; Linux Kernel Mailing List <linux- > kernel@vger.kernel.org>; ACPI Devel Maling List <linux- > acpi@vger.kernel.org>; Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>; > devel@acpica.org > Subject: Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE > > On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King > <colin.king@canonical.com> wrote: > > On 03/10/17 12:39, Rafael J. Wysocki wrote: > >> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: > >>> On Mon, 02 Oct 2017 14:27:52 +0200 > >>> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > >>> > >>>> ACPICA is soewhat special code, though and I'm not taking or ACKing > >>>> patches for it directly as a rule. > >>>> > >>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. > >>> Why is it special code that can't use ARRAY_SIZE ? Is it because > >>> this macro is defined in linux/kernel.h ? > > > > However, ACPICA does have ACPI_ARRAY_LENGTH(x), see > > source/include/actypes.h > > Fair enough, but that cleanup should go in via ACPICA upstream anyway. [Moore, Robert] This would be acceptable, as long as it will work properly in the cases that were presented earlier (using ARRAY_SIZE). > > Thanks, > Rafael > _______________________________________________ > Devel mailing list > Devel@acpica.org > https://lists.acpica.org/mailman/listinfo/devel ^ permalink raw reply [flat|nested] 51+ messages in thread
* [PATCH 16/18] media: staging: atomisp: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (14 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 17/18] staging: rtl8723bs: " Jérémy Lefaure ` (2 subsequent siblings) 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Mauro Carvalho Chehab, Greg Kroah-Hartman Cc: Jérémy Lefaure, linux-media, devel, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Also, it is useless to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- .../pci/atomisp2/css2400/camera/pipe/src/pipe_binarydesc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/camera/pipe/src/pipe_binarydesc.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/camera/pipe/src/pipe_binarydesc.c index 17d3b7de93ba..98a2a3e9b3e6 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/camera/pipe/src/pipe_binarydesc.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/camera/pipe/src/pipe_binarydesc.c @@ -22,6 +22,7 @@ #include <assert_support.h> /* HRT_GDC_N */ #include "gdc_device.h" +#include <linux/kernel.h> /* This module provides a binary descriptions to used to find a binary. Since, * every stage is associated with a binary, it implicity helps stage @@ -147,11 +148,9 @@ enum ia_css_err sh_css_bds_factor_get_numerator_denominator( unsigned int *bds_factor_denominator) { unsigned int i; - unsigned int bds_list_size = sizeof(bds_factors_list) / - sizeof(struct sh_css_bds_factor); /* Loop over all bds factors until a match is found */ - for (i = 0; i < bds_list_size; i++) { + for (i = 0; i < ARRAY_SIZE(bds_factors_list); i++) { if (bds_factors_list[i].bds_factor == bds_factor) { *bds_factor_numerator = bds_factors_list[i].numerator; *bds_factor_denominator = bds_factors_list[i].denominator; @@ -170,8 +169,6 @@ enum ia_css_err binarydesc_calculate_bds_factor( unsigned int *bds_factor) { unsigned int i; - unsigned int bds_list_size = sizeof(bds_factors_list) / - sizeof(struct sh_css_bds_factor); unsigned int in_w = input_res.width, in_h = input_res.height, out_w = output_res.width, out_h = output_res.height; @@ -186,7 +183,7 @@ enum ia_css_err binarydesc_calculate_bds_factor( assert(out_w != 0 && out_h != 0); /* Loop over all bds factors until a match is found */ - for (i = 0; i < bds_list_size; i++) { + for (i = 0; i < ARRAY_SIZE(bds_factors_list); i++) { unsigned num = bds_factors_list[i].numerator; unsigned den = bds_factors_list[i].denominator; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 17/18] staging: rtl8723bs: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (15 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 16/18] media: staging: atomisp: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 18/18] staging: rtlwifi: " Jérémy Lefaure 2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Jérémy Lefaure, devel, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 +- drivers/staging/rtl8723bs/core/rtw_rf.c | 7 +-- drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 9 ++- drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 4 +- drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 7 +-- drivers/staging/rtl8723bs/hal/hal_com.c | 4 +- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 69 +++++++++++++++-------- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 11 ++-- 8 files changed, 68 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 6c59fafeb769..d74159673b5e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -17,6 +17,7 @@ #include <drv_types.h> #include <rtw_debug.h> #include <rtw_wifi_regd.h> +#include <linux/kernel.h> static struct mlme_handler mlme_sta_tbl[] = { @@ -562,7 +563,7 @@ void mgt_dispatcher(struct adapter *padapter, union recv_frame *precv_frame) index = GetFrameSubType(pframe) >> 4; - if (index >= (sizeof(mlme_sta_tbl) / sizeof(struct mlme_handler))) { + if (index >= ARRAY_SIZE(mlme_sta_tbl)) { RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("Currently we do not support reserved sub-fr-type =%d\n", index)); return; } @@ -2227,7 +2228,7 @@ unsigned int OnAction(struct adapter *padapter, union recv_frame *precv_frame) category = frame_body[0]; - for (i = 0; i < sizeof(OnAction_tbl)/sizeof(struct action_handler); i++) { + for (i = 0; i < ARRAY_SIZE(OnAction_tbl); i++) { ptable = &OnAction_tbl[i]; if (category == ptable->num) diff --git a/drivers/staging/rtl8723bs/core/rtw_rf.c b/drivers/staging/rtl8723bs/core/rtw_rf.c index b87ea4e388c0..07f5577cc073 100644 --- a/drivers/staging/rtl8723bs/core/rtw_rf.c +++ b/drivers/staging/rtl8723bs/core/rtw_rf.c @@ -15,6 +15,7 @@ #define _RTW_RF_C_ #include <drv_types.h> +#include <linux/kernel.h> struct ch_freq { @@ -44,20 +45,18 @@ static struct ch_freq ch_freq_map[] = { {216, 5080},/* Japan, means J16 */ }; -static int ch_freq_map_num = (sizeof(ch_freq_map) / sizeof(struct ch_freq)); - u32 rtw_ch2freq(u32 channel) { u8 i; u32 freq = 0; - for (i = 0; i < ch_freq_map_num; i++) { + for (i = 0; i < ARRAY_SIZE(ch_freq_map); i++) { if (channel == ch_freq_map[i].channel) { freq = ch_freq_map[i].frequency; break; } } - if (i == ch_freq_map_num) + if (i == ARRAY_SIZE(ch_freq_map)) freq = 2412; return freq; diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c index 51d4219177d3..951585467ab1 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c @@ -13,7 +13,7 @@ * ******************************************************************************/ - +#include <linux/kernel.h> #include "odm_precomp.h" static bool CheckPositive( @@ -268,7 +268,7 @@ static u32 Array_MP_8723B_AGC_TAB[] = { void ODM_ReadAndConfig_MP_8723B_AGC_TAB(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_AGC_TAB)/sizeof(u32); + u32 ArrayLen = ARRAY_SIZE(Array_MP_8723B_AGC_TAB); u32 *Array = Array_MP_8723B_AGC_TAB; ODM_RT_TRACE( @@ -537,7 +537,7 @@ static u32 Array_MP_8723B_PHY_REG[] = { void ODM_ReadAndConfig_MP_8723B_PHY_REG(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_PHY_REG)/sizeof(u32); + u32 ArrayLen = ARRAY_SIZE(Array_MP_8723B_PHY_REG); u32 *Array = Array_MP_8723B_PHY_REG; ODM_RT_TRACE( @@ -617,7 +617,6 @@ static u32 Array_MP_8723B_PHY_REG_PG[] = { void ODM_ReadAndConfig_MP_8723B_PHY_REG_PG(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_PHY_REG_PG)/sizeof(u32); u32 *Array = Array_MP_8723B_PHY_REG_PG; ODM_RT_TRACE( @@ -630,7 +629,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG_PG(PDM_ODM_T pDM_Odm) pDM_Odm->PhyRegPgVersion = 1; pDM_Odm->PhyRegPgValueType = PHY_REG_PG_EXACT_VALUE; - for (i = 0; i < ArrayLen; i += 6) { + for (i = 0; i < ARRAY_SIZE(Array_MP_8723B_PHY_REG_PG); i += 6) { u32 v1 = Array[i]; u32 v2 = Array[i+1]; u32 v3 = Array[i+2]; diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c index b868e26f20ac..7f8afa1be1ca 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -13,7 +13,7 @@ * ******************************************************************************/ - +#include <linux/kernel.h> #include "odm_precomp.h" static bool CheckPositive( @@ -239,7 +239,7 @@ static u32 Array_MP_8723B_MAC_REG[] = { void ODM_ReadAndConfig_MP_8723B_MAC_REG(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_MAC_REG)/sizeof(u32); + u32 ArrayLen = ARRAY_SIZE(Array_MP_8723B_MAC_REG); u32 *Array = Array_MP_8723B_MAC_REG; ODM_RT_TRACE( diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c index 84a0be7ba697..fadfcbd91858 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c @@ -13,7 +13,7 @@ * ******************************************************************************/ - +#include <linux/kernel.h> #include "odm_precomp.h" static bool CheckPositive( @@ -270,7 +270,7 @@ static u32 Array_MP_8723B_RadioA[] = { void ODM_ReadAndConfig_MP_8723B_RadioA(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_RadioA)/sizeof(u32); + u32 ArrayLen = ARRAY_SIZE(Array_MP_8723B_RadioA); u32 *Array = Array_MP_8723B_RadioA; ODM_RT_TRACE( @@ -766,7 +766,6 @@ static u8 *Array_MP_8723B_TXPWR_LMT[] = { void ODM_ReadAndConfig_MP_8723B_TXPWR_LMT(PDM_ODM_T pDM_Odm) { u32 i = 0; - u32 ArrayLen = sizeof(Array_MP_8723B_TXPWR_LMT)/sizeof(u8 *); u8 **Array = Array_MP_8723B_TXPWR_LMT; ODM_RT_TRACE( @@ -776,7 +775,7 @@ void ODM_ReadAndConfig_MP_8723B_TXPWR_LMT(PDM_ODM_T pDM_Odm) ("===> ODM_ReadAndConfig_MP_8723B_TXPWR_LMT\n") ); - for (i = 0; i < ArrayLen; i += 7) { + for (i = 0; i < ARRAY_SIZE(Array_MP_8723B_TXPWR_LMT); i += 7) { u8 *regulation = Array[i]; u8 *band = Array[i+1]; u8 *bandwidth = Array[i+2]; diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index 3e63b6d9c097..03554a4156d9 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -14,6 +14,7 @@ ******************************************************************************/ #define _HAL_COM_C_ +#include <linux/kernel.h> #include <drv_types.h> #include <rtw_debug.h> #include "hal_com_h2c.h" @@ -1716,7 +1717,6 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter) { u8 value = padapter->eeprompriv.EEPROMRFGainOffset; u32 res, i = 0; - u32 ArrayLen = sizeof(Array_kfreemap)/sizeof(u32); u32 *Array = Array_kfreemap; u32 v1 = 0, v2 = 0, target = 0; /* DBG_871X("+%s value: 0x%02x+\n", __func__, value); */ @@ -1729,7 +1729,7 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter) res &= 0xfff87fff; DBG_871X("Offset RF Gain. before reg 0x7f = 0x%08x\n", res); /* res &= 0xfff87fff; */ - for (i = 0; i < ArrayLen; i += 2) { + for (i = 0; i < ARRAY_SIZE(Array_kfreemap); i += 2) { v1 = Array[i]; v2 = Array[i+1]; if (v1 == padapter->eeprompriv.EEPROMRFGainVal) { diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index 566b6f0997da..e6787c22e00b 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -17,6 +17,7 @@ #include <drv_types.h> #include <rtw_debug.h> #include <hal_data.h> +#include <linux/kernel.h> u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 Band, u8 RfPath, u8 TxNum, enum RATE_SECTION RateSection) @@ -860,7 +861,7 @@ struct adapter *padapter for (txNum = RF_1TX; txNum < RF_MAX_TX_NUM; ++txNum) { /* CCK */ base = PHY_GetTxPowerByRate(padapter, band, path, txNum, MGN_11M); - for (i = 0; i < sizeof(cckRates); ++i) { + for (i = 0; i < ARRAY_SIZE(cckRates); ++i) { value = PHY_GetTxPowerByRate(padapter, band, path, txNum, cckRates[i]); PHY_SetTxPowerByRate(padapter, band, path, txNum, cckRates[i], value - base); } @@ -939,58 +940,78 @@ void PHY_SetTxPowerIndexByRateSection( if (RateSection == CCK) { u8 cckRates[] = {MGN_1M, MGN_2M, MGN_5_5M, MGN_11M}; if (pHalData->CurrentBandType == BAND_ON_2_4G) - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - cckRates, sizeof(cckRates)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, cckRates, + ARRAY_SIZE(cckRates)); } else if (RateSection == OFDM) { u8 ofdmRates[] = {MGN_6M, MGN_9M, MGN_12M, MGN_18M, MGN_24M, MGN_36M, MGN_48M, MGN_54M}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - ofdmRates, sizeof(ofdmRates)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, ofdmRates, + ARRAY_SIZE(ofdmRates)); } else if (RateSection == HT_MCS0_MCS7) { u8 htRates1T[] = {MGN_MCS0, MGN_MCS1, MGN_MCS2, MGN_MCS3, MGN_MCS4, MGN_MCS5, MGN_MCS6, MGN_MCS7}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - htRates1T, sizeof(htRates1T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, htRates1T, + ARRAY_SIZE(htRates1T)); } else if (RateSection == HT_MCS8_MCS15) { u8 htRates2T[] = {MGN_MCS8, MGN_MCS9, MGN_MCS10, MGN_MCS11, MGN_MCS12, MGN_MCS13, MGN_MCS14, MGN_MCS15}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - htRates2T, sizeof(htRates2T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, htRates2T, + ARRAY_SIZE(htRates2T)); } else if (RateSection == HT_MCS16_MCS23) { u8 htRates3T[] = {MGN_MCS16, MGN_MCS17, MGN_MCS18, MGN_MCS19, MGN_MCS20, MGN_MCS21, MGN_MCS22, MGN_MCS23}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - htRates3T, sizeof(htRates3T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, htRates3T, + ARRAY_SIZE(htRates3T)); } else if (RateSection == HT_MCS24_MCS31) { u8 htRates4T[] = {MGN_MCS24, MGN_MCS25, MGN_MCS26, MGN_MCS27, MGN_MCS28, MGN_MCS29, MGN_MCS30, MGN_MCS31}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - htRates4T, sizeof(htRates4T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, htRates4T, + ARRAY_SIZE(htRates4T)); } else if (RateSection == VHT_1SSMCS0_1SSMCS9) { u8 vhtRates1T[] = {MGN_VHT1SS_MCS0, MGN_VHT1SS_MCS1, MGN_VHT1SS_MCS2, MGN_VHT1SS_MCS3, MGN_VHT1SS_MCS4, MGN_VHT1SS_MCS5, MGN_VHT1SS_MCS6, MGN_VHT1SS_MCS7, MGN_VHT1SS_MCS8, MGN_VHT1SS_MCS9}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - vhtRates1T, sizeof(vhtRates1T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, vhtRates1T, + ARRAY_SIZE(vhtRates1T)); } else if (RateSection == VHT_2SSMCS0_2SSMCS9) { u8 vhtRates2T[] = {MGN_VHT2SS_MCS0, MGN_VHT2SS_MCS1, MGN_VHT2SS_MCS2, MGN_VHT2SS_MCS3, MGN_VHT2SS_MCS4, MGN_VHT2SS_MCS5, MGN_VHT2SS_MCS6, MGN_VHT2SS_MCS7, MGN_VHT2SS_MCS8, MGN_VHT2SS_MCS9}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - vhtRates2T, sizeof(vhtRates2T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, vhtRates2T, + ARRAY_SIZE(vhtRates2T)); } else if (RateSection == VHT_3SSMCS0_3SSMCS9) { u8 vhtRates3T[] = {MGN_VHT3SS_MCS0, MGN_VHT3SS_MCS1, MGN_VHT3SS_MCS2, MGN_VHT3SS_MCS3, MGN_VHT3SS_MCS4, MGN_VHT3SS_MCS5, MGN_VHT3SS_MCS6, MGN_VHT3SS_MCS7, MGN_VHT3SS_MCS8, MGN_VHT3SS_MCS9}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - vhtRates3T, sizeof(vhtRates3T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, vhtRates3T, + ARRAY_SIZE(vhtRates3T)); } else if (RateSection == VHT_4SSMCS0_4SSMCS9) { u8 vhtRates4T[] = {MGN_VHT4SS_MCS0, MGN_VHT4SS_MCS1, MGN_VHT4SS_MCS2, MGN_VHT4SS_MCS3, MGN_VHT4SS_MCS4, MGN_VHT4SS_MCS5, MGN_VHT4SS_MCS6, MGN_VHT4SS_MCS7, MGN_VHT4SS_MCS8, MGN_VHT4SS_MCS9}; - PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, - vhtRates4T, sizeof(vhtRates4T)/sizeof(u8)); + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, + pHalData->CurrentChannelBW, + Channel, vhtRates4T, + ARRAY_SIZE(vhtRates4T)); } else DBG_871X("Invalid RateSection %d in %s", RateSection, __func__); } @@ -1012,7 +1033,7 @@ static bool phy_GetChnlIndex(u8 Channel, u8 *ChannelIdx) } else { bIn24G = false; - for (i = 0; i < sizeof(channel5G)/sizeof(u8); ++i) { + for (i = 0; i < ARRAY_SIZE(channel5G); ++i) { if (channel5G[i] == Channel) { *ChannelIdx = i; return bIn24G; @@ -1149,7 +1170,7 @@ u8 PHY_GetTxPowerIndexBase( } else if (BandWidth == CHANNEL_WIDTH_80) { /* BW80-1S, BW80-2S */ /* <20121220, Kordan> Get the index of array "Index5G_BW80_Base". */ u8 channel5G_80M[CHANNEL_MAX_NUMBER_5G_80M] = {42, 58, 106, 122, 138, 155, 171}; - for (i = 0; i < sizeof(channel5G_80M)/sizeof(u8); ++i) + for (i = 0; i < ARRAY_SIZE(channel5G_80M); ++i) if (channel5G_80M[i] == Channel) chnlIdx = i; @@ -1588,7 +1609,7 @@ static s8 phy_GetChannelIndexOfTxPowerLimit(u8 Band, u8 Channel) if (Band == BAND_ON_2_4G) channelIndex = Channel - 1; else if (Band == BAND_ON_5G) { - for (i = 0; i < sizeof(channel5G)/sizeof(u8); ++i) { + for (i = 0; i < ARRAY_SIZE(channel5G); ++i) { if (channel5G[i] == Channel) channelIndex = i; } diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 6a8f805c0b28..3fca0c2d4c8d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -18,6 +18,7 @@ #include <rtw_debug.h> #include <rtw_mp.h> #include <linux/jiffies.h> +#include <linux/kernel.h> #define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30) @@ -5017,12 +5018,12 @@ static struct iw_statistics *rtw_get_wireless_stats(struct net_device *dev) struct iw_handler_def rtw_handlers_def = { .standard = rtw_handlers, - .num_standard = sizeof(rtw_handlers) / sizeof(iw_handler), + .num_standard = ARRAY_SIZE(rtw_handlers), #if defined(CONFIG_WEXT_PRIV) .private = rtw_private_handler, .private_args = (struct iw_priv_args *)rtw_private_args, - .num_private = sizeof(rtw_private_handler) / sizeof(iw_handler), - .num_private_args = sizeof(rtw_private_args) / sizeof(struct iw_priv_args), + .num_private = ARRAY_SIZE(rtw_private_handler), + .num_private_args = ARRAY_SIZE(rtw_private_args), #endif .get_wireless_stats = rtw_get_wireless_stats, }; @@ -5109,8 +5110,8 @@ static int rtw_ioctl_wext_private(struct net_device *dev, union iwreq_data *wrq_ priv = rtw_private_handler; priv_args = rtw_private_args; - num_priv = sizeof(rtw_private_handler) / sizeof(iw_handler); - num_priv_args = sizeof(rtw_private_args) / sizeof(struct iw_priv_args); + num_priv = ARRAY_SIZE(rtw_private_handler); + num_priv_args = ARRAY_SIZE(rtw_private_args); if (num_priv_args == 0) { err = -EOPNOTSUPP; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* [PATCH 18/18] staging: rtlwifi: use ARRAY_SIZE 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (16 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 17/18] staging: rtl8723bs: " Jérémy Lefaure @ 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding 18 siblings, 0 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-01 19:30 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Jérémy Lefaure, devel, linux-kernel Using the ARRAY_SIZE macro improves the readability of the code. Also, it is useless to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/staging/rtlwifi/phydm/phydm_debug.c | 4 ++-- drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_bb.c | 10 ++++------ drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_mac.c | 4 ++-- drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c | 13 +++++-------- 4 files changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtlwifi/phydm/phydm_debug.c b/drivers/staging/rtlwifi/phydm/phydm_debug.c index a5f90afdae9b..d4dd0fd3d1c7 100644 --- a/drivers/staging/rtlwifi/phydm/phydm_debug.c +++ b/drivers/staging/rtlwifi/phydm/phydm_debug.c @@ -29,6 +29,7 @@ #include "mp_precomp.h" #include "phydm_precomp.h" +#include <linux/kernel.h> bool phydm_api_set_txagc(struct phy_dm_struct *, u32, enum odm_rf_radio_path, u8, bool); @@ -2107,8 +2108,7 @@ void phydm_cmd_parser(struct phy_dm_struct *dm, char input[][MAX_ARGV], /* Parsing Cmd ID */ if (input_num) { - phydm_ary_size = - sizeof(phy_dm_ary) / sizeof(struct phydm_command); + phydm_ary_size = ARRAY_SIZE(phy_dm_ary); for (i = 0; i < phydm_ary_size; i++) { if (strcmp(phy_dm_ary[i].name, input[0]) == 0) { id = phy_dm_ary[i].id; diff --git a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_bb.c b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_bb.c index 4e7946019fcb..29d19f2b300e 100644 --- a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_bb.c +++ b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_bb.c @@ -26,6 +26,7 @@ /*Image2HeaderVersion: 3.2*/ #include "../mp_precomp.h" #include "../phydm_precomp.h" +#include <linux/kernel.h> static bool check_positive(struct phy_dm_struct *dm, const u32 condition1, const u32 condition2, const u32 condition3, @@ -1350,7 +1351,6 @@ void odm_read_and_config_mp_8822b_agc_tab(struct phy_dm_struct *dm) u32 i = 0; u8 c_cond; bool is_matched = true, is_skipped = false; - u32 array_len = sizeof(array_mp_8822b_agc_tab) / sizeof(u32); u32 *array = array_mp_8822b_agc_tab; u32 v1 = 0, v2 = 0, pre_v1 = 0, pre_v2 = 0; @@ -1358,7 +1358,7 @@ void odm_read_and_config_mp_8822b_agc_tab(struct phy_dm_struct *dm) ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (; (i + 1) < array_len; i = i + 2) { + for (; (i + 1) < ARRAY_SIZE(array_mp_8822b_agc_tab); i = i + 2) { v1 = array[i]; v2 = array[i + 1]; @@ -1843,7 +1843,6 @@ void odm_read_and_config_mp_8822b_phy_reg(struct phy_dm_struct *dm) u32 i = 0; u8 c_cond; bool is_matched = true, is_skipped = false; - u32 array_len = sizeof(array_mp_8822b_phy_reg) / sizeof(u32); u32 *array = array_mp_8822b_phy_reg; u32 v1 = 0, v2 = 0, pre_v1 = 0, pre_v2 = 0; @@ -1851,7 +1850,7 @@ void odm_read_and_config_mp_8822b_phy_reg(struct phy_dm_struct *dm) ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (; (i + 1) < array_len; i = i + 2) { + for (; (i + 1) < ARRAY_SIZE(array_mp_8822b_phy_reg); i = i + 2) { v1 = array[i]; v2 = array[i + 1]; @@ -1947,7 +1946,6 @@ static u32 array_mp_8822b_phy_reg_pg[] = { void odm_read_and_config_mp_8822b_phy_reg_pg(struct phy_dm_struct *dm) { u32 i = 0; - u32 array_len = sizeof(array_mp_8822b_phy_reg_pg) / sizeof(u32); u32 *array = array_mp_8822b_phy_reg_pg; ODM_RT_TRACE(dm, ODM_COMP_INIT, @@ -1956,7 +1954,7 @@ void odm_read_and_config_mp_8822b_phy_reg_pg(struct phy_dm_struct *dm) dm->phy_reg_pg_version = 1; dm->phy_reg_pg_value_type = PHY_REG_PG_EXACT_VALUE; - for (i = 0; i < array_len; i += 6) { + for (i = 0; i < ARRAY_SIZE(array_mp_8822b_phy_reg_pg); i += 6) { u32 v1 = array[i]; u32 v2 = array[i + 1]; u32 v3 = array[i + 2]; diff --git a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_mac.c b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_mac.c index 1a9daed2e609..70924f002541 100644 --- a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_mac.c +++ b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_mac.c @@ -26,6 +26,7 @@ /*Image2HeaderVersion: 3.2*/ #include "../mp_precomp.h" #include "../phydm_precomp.h" +#include <linux/kernel.h> static bool check_positive(struct phy_dm_struct *dm, const u32 condition1, const u32 condition2, const u32 condition3, @@ -173,7 +174,6 @@ void odm_read_and_config_mp_8822b_mac_reg(struct phy_dm_struct *dm) u32 i = 0; u8 c_cond; bool is_matched = true, is_skipped = false; - u32 array_len = sizeof(array_mp_8822b_mac_reg) / sizeof(u32); u32 *array = array_mp_8822b_mac_reg; u32 v1 = 0, v2 = 0, pre_v1 = 0, pre_v2 = 0; @@ -181,7 +181,7 @@ void odm_read_and_config_mp_8822b_mac_reg(struct phy_dm_struct *dm) ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (; (i + 1) < array_len; i = i + 2) { + for (; (i + 1) < ARRAY_SIZE(array_mp_8822b_mac_reg); i = i + 2) { v1 = array[i]; v2 = array[i + 1]; diff --git a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c index 84cdc0644207..0ff3a9a712d6 100644 --- a/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c +++ b/drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c @@ -26,6 +26,7 @@ /*Image2HeaderVersion: 3.2*/ #include "../mp_precomp.h" #include "../phydm_precomp.h" +#include <linux/kernel.h> static bool check_positive(struct phy_dm_struct *dm, const u32 condition1, const u32 condition2, const u32 condition3, @@ -1346,7 +1347,6 @@ void odm_read_and_config_mp_8822b_radioa(struct phy_dm_struct *dm) u32 i = 0; u8 c_cond; bool is_matched = true, is_skipped = false; - u32 array_len = sizeof(array_mp_8822b_radioa) / sizeof(u32); u32 *array = array_mp_8822b_radioa; u32 v1 = 0, v2 = 0, pre_v1 = 0, pre_v2 = 0; @@ -1354,7 +1354,7 @@ void odm_read_and_config_mp_8822b_radioa(struct phy_dm_struct *dm) ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (; (i + 1) < array_len; i = i + 2) { + for (; (i + 1) < ARRAY_SIZE(array_mp_8822b_radioa); i = i + 2) { v1 = array[i]; v2 = array[i + 1]; @@ -2506,7 +2506,6 @@ void odm_read_and_config_mp_8822b_radiob(struct phy_dm_struct *dm) u32 i = 0; u8 c_cond; bool is_matched = true, is_skipped = false; - u32 array_len = sizeof(array_mp_8822b_radiob) / sizeof(u32); u32 *array = array_mp_8822b_radiob; u32 v1 = 0, v2 = 0, pre_v1 = 0, pre_v2 = 0; @@ -2514,7 +2513,7 @@ void odm_read_and_config_mp_8822b_radiob(struct phy_dm_struct *dm) ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (; (i + 1) < array_len; i = i + 2) { + for (; (i + 1) < ARRAY_SIZE(array_mp_8822b_radiob); i = i + 2) { v1 = array[i]; v2 = array[i + 1]; @@ -4239,13 +4238,12 @@ static const char *const array_mp_8822b_txpwr_lmt[] = { void odm_read_and_config_mp_8822b_txpwr_lmt(struct phy_dm_struct *dm) { u32 i = 0; - u32 array_len = sizeof(array_mp_8822b_txpwr_lmt) / sizeof(u8 *); u8 **array = (u8 **)array_mp_8822b_txpwr_lmt; ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> %s\n", __func__); - for (i = 0; i < array_len; i += 7) { + for (i = 0; i < ARRAY_SIZE(array_mp_8822b_txpwr_lmt); i += 7) { u8 *regulation = array[i]; u8 *band = array[i + 1]; u8 *bandwidth = array[i + 2]; @@ -4723,13 +4721,12 @@ static const char *const array_mp_8822b_txpwr_lmt_type5[] = { void odm_read_and_config_mp_8822b_txpwr_lmt_type5(struct phy_dm_struct *dm) { u32 i = 0; - u32 array_len = sizeof(array_mp_8822b_txpwr_lmt_type5) / sizeof(u8 *); u8 **array = (u8 **)array_mp_8822b_txpwr_lmt_type5; ODM_RT_TRACE(dm, ODM_COMP_INIT, "===> odm_read_and_config_mp_8822b_txpwr_lmt_type5\n"); - for (i = 0; i < array_len; i += 7) { + for (i = 0; i < ARRAY_SIZE(array_mp_8822b_txpwr_lmt_type5); i += 7) { u8 *regulation = array[i]; u8 *band = array[i + 1]; u8 *bandwidth = array[i + 2]; -- 2.14.1 ^ permalink raw reply related [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure ` (17 preceding siblings ...) 2017-10-01 19:30 ` [PATCH 18/18] staging: rtlwifi: " Jérémy Lefaure @ 2017-10-01 22:01 ` Tobin C. Harding 2017-10-02 0:52 ` Jérémy Lefaure 18 siblings, 1 reply; 51+ messages in thread From: Tobin C. Harding @ 2017-10-01 22:01 UTC (permalink / raw) To: Jérémy Lefaure Cc: alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity On Sun, Oct 01, 2017 at 03:30:38PM -0400, Jérémy Lefaure wrote: > Hi everyone, > Using ARRAY_SIZE improves the code readability. I used coccinelle (I > made a change to the array_size.cocci file [1]) to find several places > where ARRAY_SIZE could be used instead of other macros or sizeof > division. > > I tried to divide the changes into a patch per subsystem (excepted for > staging). If one of the patch should be split into several patches, let > me know. > > In order to reduce the size of the To: and Cc: lines, each patch of the > series is sent only to the maintainers and lists concerned by the patch. > This cover letter is sent to every list concerned by this series. Why don't you just send individual patches for each subsystem? I'm not a maintainer but I don't see how any one person is going to be able to apply this whole series, it is making it hard for maintainers if they have to pick patches out from among the series (if indeed any will bother doing that). I get that this will be more work for you but AFAIK we are optimizing for maintainers. Good luck, Tobin. ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding @ 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 5:35 ` Greg KH 2017-10-02 16:37 ` Mauro Carvalho Chehab 0 siblings, 2 replies; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-02 0:52 UTC (permalink / raw) To: Tobin C. Harding Cc: alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity On Mon, 2 Oct 2017 09:01:31 +1100 "Tobin C. Harding" <me@tobin.cc> wrote: > > In order to reduce the size of the To: and Cc: lines, each patch of the > > series is sent only to the maintainers and lists concerned by the patch. > > This cover letter is sent to every list concerned by this series. > > Why don't you just send individual patches for each subsystem? I'm not a maintainer but I don't see > how any one person is going to be able to apply this whole series, it is making it hard for > maintainers if they have to pick patches out from among the series (if indeed any will bother > doing that). Yeah, maybe it would have been better to send individual patches. >From my point of view it's a series because the patches are related (I did a git format-patch from my local branch). But for the maintainers point of view, they are individual patches. As each patch in this series is standalone, the maintainers can pick the patches they want and apply them individually. So yeah, maybe I should have sent individual patches. But I also wanted to tie all patches together as it's the same change. Anyway, I can tell to each maintainer that they can apply the patches they're concerned about and next time I may send individual patches. Thank you for your answer, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-02 0:52 ` Jérémy Lefaure @ 2017-10-02 5:35 ` Greg KH 2017-10-02 19:22 ` J. Bruce Fields 2017-10-02 16:37 ` Mauro Carvalho Chehab 1 sibling, 1 reply; 51+ messages in thread From: Greg KH @ 2017-10-02 5:35 UTC (permalink / raw) To: Jérémy Lefaure Cc: Tobin C. Harding, alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" <me@tobin.cc> wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the patch. > > > This cover letter is sent to every list concerned by this series. > > > > Why don't you just send individual patches for each subsystem? I'm not a maintainer but I don't see > > how any one person is going to be able to apply this whole series, it is making it hard for > > maintainers if they have to pick patches out from among the series (if indeed any will bother > > doing that). > Yeah, maybe it would have been better to send individual patches. > > From my point of view it's a series because the patches are related (I > did a git format-patch from my local branch). But for the maintainers > point of view, they are individual patches. And the maintainers view is what matters here, if you wish to get your patches reviewed and accepted... thanks, greg k-h ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-02 5:35 ` Greg KH @ 2017-10-02 19:22 ` J. Bruce Fields 2017-10-03 1:33 ` Jérémy Lefaure 0 siblings, 1 reply; 51+ messages in thread From: J. Bruce Fields @ 2017-10-02 19:22 UTC (permalink / raw) To: Greg KH Cc: Jérémy Lefaure, Tobin C. Harding, alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity On Mon, Oct 02, 2017 at 07:35:54AM +0200, Greg KH wrote: > On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > > On Mon, 2 Oct 2017 09:01:31 +1100 > > "Tobin C. Harding" <me@tobin.cc> wrote: > > > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > > series is sent only to the maintainers and lists concerned by the patch. > > > > This cover letter is sent to every list concerned by this series. > > > > > > Why don't you just send individual patches for each subsystem? I'm not a maintainer but I don't see > > > how any one person is going to be able to apply this whole series, it is making it hard for > > > maintainers if they have to pick patches out from among the series (if indeed any will bother > > > doing that). > > Yeah, maybe it would have been better to send individual patches. > > > > From my point of view it's a series because the patches are related (I > > did a git format-patch from my local branch). But for the maintainers > > point of view, they are individual patches. > > And the maintainers view is what matters here, if you wish to get your > patches reviewed and accepted... Mainly I'd just like to know which you're asking for. Do you want me to apply this, or to ACK it so someone else can? If it's sent as a series I tend to assume the latter. But in this case I'm assuming it's the former, so I'll pick up the nfsd one.... --b. ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-02 19:22 ` J. Bruce Fields @ 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-05 17:57 ` J. Bruce Fields 0 siblings, 1 reply; 51+ messages in thread From: Jérémy Lefaure @ 2017-10-03 1:33 UTC (permalink / raw) To: J. Bruce Fields Cc: Greg KH, Tobin C. Harding, alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity, jlayton On Mon, 2 Oct 2017 15:22:24 -0400 bfields@fieldses.org (J. Bruce Fields) wrote: > Mainly I'd just like to know which you're asking for. Do you want me to > apply this, or to ACK it so someone else can? If it's sent as a series > I tend to assume the latter. > > But in this case I'm assuming it's the former, so I'll pick up the nfsd > one.... Could you to apply the NFSD patch ("nfsd: use ARRAY_SIZE") with the Reviewed-by: Jeff Layton <jlayton@redhat.com>) tag please ? This patch is an individual patch and it should not have been sent in a series (sorry about that). Thank you, Jérémy ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-03 1:33 ` Jérémy Lefaure @ 2017-10-05 17:57 ` J. Bruce Fields 0 siblings, 0 replies; 51+ messages in thread From: J. Bruce Fields @ 2017-10-05 17:57 UTC (permalink / raw) To: Jérémy Lefaure Cc: Greg KH, Tobin C. Harding, alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity, jlayton On Mon, Oct 02, 2017 at 09:33:12PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 15:22:24 -0400 > bfields@fieldses.org (J. Bruce Fields) wrote: > > > Mainly I'd just like to know which you're asking for. Do you want me to > > apply this, or to ACK it so someone else can? If it's sent as a series > > I tend to assume the latter. > > > > But in this case I'm assuming it's the former, so I'll pick up the nfsd > > one.... > Could you to apply the NFSD patch ("nfsd: use ARRAY_SIZE") with the > Reviewed-by: Jeff Layton <jlayton@redhat.com>) tag please ? > > This patch is an individual patch and it should not have been sent in a > series (sorry about that). Applying for 4.15, thanks.--b. ^ permalink raw reply [flat|nested] 51+ messages in thread
* Re: [PATCH 00/18] use ARRAY_SIZE macro 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 5:35 ` Greg KH @ 2017-10-02 16:37 ` Mauro Carvalho Chehab 1 sibling, 0 replies; 51+ messages in thread From: Mauro Carvalho Chehab @ 2017-10-02 16:37 UTC (permalink / raw) To: Jérémy Lefaure Cc: Tobin C. Harding, alsa-devel, nouveau, dri-devel, dm-devel, brcm80211-dev-list, devel, linux-scsi, linux-rdma, amd-gfx, Jason Gunthorpe, linux-acpi, linux-video, intel-wired-lan, linux-media, intel-gfx, ecryptfs, linux-nfs, linux-raid, openipmi-developer, intel-gvt-dev, devel, brcm80211-dev-list.pdl, netdev, linux-usb, linux-wireless, linux-kernel, linux-integrity Em Sun, 1 Oct 2017 20:52:20 -0400 Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> escreveu: > Anyway, I can tell to each maintainer that they can apply the patches > they're concerned about and next time I may send individual patches. In the case of media, we'll handle it as if they were individual ones. Thanks, Mauro ^ permalink raw reply [flat|nested] 51+ messages in thread
end of thread, other threads:[~2017-10-19 14:21 UTC | newest] Thread overview: 51+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure 2017-10-02 4:16 ` Joe Perches 2017-10-03 1:12 ` Jérémy Lefaure 2017-10-03 7:03 ` Takashi Iwai 2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure 2017-10-04 1:05 ` Steven Rostedt 2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure 2017-10-02 10:34 ` Michael Ira Krufky 2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure 2017-10-02 4:38 ` Leon Romanovsky 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure 2017-10-02 13:07 ` Andy Shevchenko 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-03 8:09 ` Andy Shevchenko 2017-10-02 13:46 ` Kalle Valo 2017-10-03 1:23 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure 2017-10-02 7:43 ` Jani Nikula 2017-10-02 8:27 ` Thierry Reding 2017-10-01 19:30 ` [PATCH 07/18] scsi: bfa: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure 2017-10-14 1:31 ` Tyler Hicks 2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure 2017-10-02 11:03 ` Jeff Layton 2017-10-01 19:30 ` [PATCH 10/18] orangefs: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 11/18] dm space map metadata: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure 2017-10-19 14:18 ` [tip:x86/cleanups] x86: Use ARRAY_SIZE tip-bot for Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure 2017-10-04 12:14 ` Jarkko Sakkinen 2017-10-10 20:30 ` Jérémy Lefaure 2017-10-11 11:48 ` Jarkko Sakkinen 2017-10-01 19:30 ` [PATCH 14/18] ipmi: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure 2017-10-02 12:27 ` Rafael J. Wysocki 2017-10-03 1:16 ` Jérémy Lefaure 2017-10-03 11:39 ` Rafael J. Wysocki 2017-10-03 12:34 ` [Devel] " Colin Ian King 2017-10-03 16:04 ` Rafael J. Wysocki 2017-10-03 16:38 ` Moore, Robert 2017-10-01 19:30 ` [PATCH 16/18] media: staging: atomisp: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 17/18] staging: rtl8723bs: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 18/18] staging: rtlwifi: " Jérémy Lefaure 2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 5:35 ` Greg KH 2017-10-02 19:22 ` J. Bruce Fields 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-05 17:57 ` J. Bruce Fields 2017-10-02 16:37 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).