From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbdJBNBB (ORCPT ); Mon, 2 Oct 2017 09:01:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdJBNBA (ORCPT ); Mon, 2 Oct 2017 09:01:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CCF2A5277E Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 2 Oct 2017 15:00:57 +0200 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v3 1/6] perf header: Record first sample time and last sample time in perf file header Message-ID: <20171002130057.GA22359@krava> References: <1506602721-3784-1-git-send-email-yao.jin@linux.intel.com> <1506602721-3784-2-git-send-email-yao.jin@linux.intel.com> <20171002115057.GA16128@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 02 Oct 2017 13:01:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2017 at 08:52:59PM +0800, Jin, Yao wrote: > > > On 10/2/2017 7:50 PM, Jiri Olsa wrote: > > On Thu, Sep 28, 2017 at 08:45:16PM +0800, Jin Yao wrote: > > > > SNIP > > > >> + return ret; > >> + > >> + return do_write(ff, &evlist->last_sample_time, > >> + sizeof(evlist->last_sample_time)); > >> +} > >> + > >> static void print_hostname(struct feat_fd *ff, FILE *fp) > >> { > >> fprintf(fp, "# hostname : %s\n", ff->ph->env.hostname); > >> @@ -1506,6 +1520,19 @@ static void print_group_desc(struct feat_fd *ff, FILE *fp) > >> } > >> } > >> > >> +static void print_sample_time(struct feat_fd *ff, FILE *fp) > >> +{ > >> + struct perf_session *session; > >> + > >> + session = container_of(ff->ph, struct perf_session, header); > >> + > >> + fprintf(fp, "# time of first sample : %" PRIu64 "\n", > >> + session->evlist->first_sample_time); > >> + > >> + fprintf(fp, "# time of last sample : %" PRIu64 "\n", > >> + session->evlist->last_sample_time); > > > > this could be done in some follow up patch, but could we > > display this in some human readable way.. > > > > # time of first sample : 218077073264620 > > # time of last sample : 218077073395488 > > > > jirka > > > > Could I add the printing of duration? For example, > > duration = (double)(last_sample_time - first_sample_time) / NSEC_PER_MSEC; > fprintf(fp, "# sample duration: %10.3f (ms)\n", duration); > > fprintf(fp, "# time of first sample : %" PRIu64 "\n", > first_sample_time); > > fprintf(fp, "# time of last sample : %" PRIu64 "\n", > last_sample_time); could be, but mainly please display the time same way the perf script does: 218482.819815 jirka