From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com
Subject: Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events
Date: Mon, 2 Oct 2017 15:37:56 -0400 [thread overview]
Message-ID: <20171002153756.485fa6a9@gandalf.local.home> (raw)
In-Reply-To: <CAJWu+oqbc+Axwe=v4yaVj4EZ+kGuQSVdfygRqB_3+M9MWp4tKQ@mail.gmail.com>
On Mon, 2 Oct 2017 12:33:30 -0700
Joel Fernandes <joelaf@google.com> wrote:
> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
> index 5dd1272d1ab2..2a1af0dd9cc4 100644
> --- a/include/linux/irqflags.h
> +++ b/include/linux/irqflags.h
> @@ -93,7 +93,9 @@
> #define local_irq_save(flags) \
> do { \
> raw_local_irq_save(flags); \
> - trace_hardirqs_off(); \
> + if (!raw_irqs_disabled_flags(flags)) { \
> + trace_hardirqs_off(); \
> + } \
> } while (0)
>
>
> @@ -101,7 +103,6 @@
> do { \
> if (raw_irqs_disabled_flags(flags)) { \
> raw_local_irq_restore(flags); \
> - trace_hardirqs_off(); \
> } else { \
> trace_hardirqs_on(); \
> raw_local_irq_restore(flags); \
I rather have the protection in trace_hardirqs_on/off(). Let's keep the
ugliness from spreading.
-- Steve
next prev parent reply other threads:[~2017-10-02 19:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 1:50 [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable Joel Fernandes
2017-09-22 1:50 ` [PATCH v6 1/2] tracing: Prepare to add preempt and irq trace events Joel Fernandes
2017-09-22 1:50 ` [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events Joel Fernandes
2017-09-22 9:02 ` Peter Zijlstra
2017-09-22 18:28 ` Joel Fernandes
2017-09-25 8:34 ` Peter Zijlstra
2017-09-25 10:15 ` Steven Rostedt
2017-09-25 10:32 ` Peter Zijlstra
2017-09-25 10:52 ` Steven Rostedt
2017-09-25 22:57 ` Joel Fernandes
2017-09-26 2:47 ` Steven Rostedt
2017-09-29 2:15 ` Joel Fernandes
2017-09-26 0:23 ` Joel Fernandes
2017-09-30 9:08 ` Steven Rostedt
2017-10-02 19:23 ` Joel Fernandes
2017-10-02 19:33 ` Joel Fernandes
2017-10-02 19:37 ` Steven Rostedt [this message]
2017-10-02 21:31 ` Joel Fernandes
2017-09-22 3:11 ` [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002153756.485fa6a9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox