From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751677AbdJCJT0 (ORCPT ); Tue, 3 Oct 2017 05:19:26 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:49393 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdJCJTX (ORCPT ); Tue, 3 Oct 2017 05:19:23 -0400 Date: Tue, 3 Oct 2017 02:19:22 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, Bart Van Assche , Laurence Oberman , Paolo Valente , Oleksandr Natalenko , Tom Nguyen , linux-kernel@vger.kernel.org, Omar Sandoval Subject: Re: [PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx Message-ID: <20171003091922.GD2771@infradead.org> References: <20170930112655.31451-1-ming.lei@redhat.com> <20170930112655.31451-7-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170930112655.31451-7-ming.lei@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +enum elv_merge elv_merge_ctx(struct request_queue *q, struct request **req, > + struct bio *bio, struct blk_mq_ctx *ctx) > +{ > + WARN_ON_ONCE(!q->mq_ops); > + return __elv_merge(q, req, bio, ctx->hash, ctx->last_merge); > +} This function only has a single caller, just open code it.