From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbdJCKIy (ORCPT ); Tue, 3 Oct 2017 06:08:54 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46430 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdJCKIu (ORCPT ); Tue, 3 Oct 2017 06:08:50 -0400 Date: Tue, 3 Oct 2017 11:07:20 +0100 From: Mark Rutland To: SF Markus Elfring Cc: linux-arm-kernel@lists.infradead.org, Russell King , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ARM: cache-l2x0-pmu: Delete an error message for a failed memory allocation in l2x0_pmu_init() Message-ID: <20171003100719.GB4931@leverpostej> References: <672554ba-b476-8852-3c37-9e8716f1eec4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <672554ba-b476-8852-3c37-9e8716f1eec4@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 11:23:23AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 3 Oct 2017 11:16:56 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring FWIW: Acked-by: Mark Rutland I assume you'll drop this in Russell's patch system. Thanks, Mark. > --- > arch/arm/mm/cache-l2x0-pmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c > index 0a1e2280141f..b3734da93010 100644 > --- a/arch/arm/mm/cache-l2x0-pmu.c > +++ b/arch/arm/mm/cache-l2x0-pmu.c > @@ -528,10 +528,8 @@ static __init int l2x0_pmu_init(void) > return 0; > > l2x0_pmu = kzalloc(sizeof(*l2x0_pmu), GFP_KERNEL); > - if (!l2x0_pmu) { > - pr_warn("Unable to allocate L2x0 PMU\n"); > + if (!l2x0_pmu) > return -ENOMEM; > - } > > *l2x0_pmu = (struct pmu) { > .task_ctx_nr = perf_invalid_context, > -- > 2.14.2 >