From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbdJCKqP (ORCPT ); Tue, 3 Oct 2017 06:46:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbdJCKna (ORCPT ); Tue, 3 Oct 2017 06:43:30 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 21564C04AC76 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Tue, 3 Oct 2017 12:43:27 +0200 From: Jiri Olsa To: yuzhoujian Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com, arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] Make all print functions receive the fp argument, and opens a dump file in process_event. Message-ID: <20171003104327.GB13755@krava> References: <1506408797-23657-1-git-send-email-yuzhoujian@didichuxing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506408797-23657-1-git-send-email-yuzhoujian@didichuxing.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 03 Oct 2017 10:43:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 26, 2017 at 02:53:17PM +0800, yuzhoujian wrote: SNIP > + fprintf(fp, "%16" PRIx64, sample->phys_addr); > + fprintf(fp, "\n"); > + if (script->tool.per_event_dump) > + fclose(fp); > } > > static struct scripting_ops *scripting_ops; > @@ -1574,6 +1589,7 @@ static int process_sample_event(struct perf_tool *tool, > { > struct perf_script *scr = container_of(tool, struct perf_script, tool); > struct addr_location al; > + FILE *fp; > > if (perf_time__skip_sample(&scr->ptime, sample->time)) > return 0; > @@ -1601,10 +1617,11 @@ static int process_sample_event(struct perf_tool *tool, > if (cpu_list && !test_bit(sample->cpu, cpu_bitmap)) > goto out_put; > > + fp = tool->per_event_dump ? per_event_dump_file : stdout; I know you explained this already, but I still can't see this one being set: [jolsa@krava perf]$ grep -r per_event_dump_file builtin-script.c static FILE *per_event_dump_file; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; fp = tool->per_event_dump ? per_event_dump_file : stdout; I think we should use per evsel FILE pointers jirka