From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbdJCMuN (ORCPT ); Tue, 3 Oct 2017 08:50:13 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:36668 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbdJCMuI (ORCPT ); Tue, 3 Oct 2017 08:50:08 -0400 Date: Tue, 3 Oct 2017 13:49:36 +0100 From: Roman Gushchin To: Michal Hocko CC: , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , , , , Subject: Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer Message-ID: <20171003124936.GA28904@castle.DHCP.thefacebook.com> References: <20170927130936.8601-1-guro@fb.com> <20170927130936.8601-5-guro@fb.com> <20171003115036.3zzydsiiz7hbx4jg@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171003115036.3zzydsiiz7hbx4jg@dhcp22.suse.cz> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [2620:10d:c092:200::1:8d4] X-ClientProxiedBy: AM0PR0202CA0008.eurprd02.prod.outlook.com (2603:10a6:208:1::21) To BL2PR15MB1073.namprd15.prod.outlook.com (2603:10b6:201:17::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7bef84a-cbb9-4a38-a343-08d50a5d3c48 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BL2PR15MB1073; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;3:jClOgWUR/UeTO6E6WaA5Wq16i6Vako1pqU2pDrDZpxijo1bkFvLavdW9g0v5oDoQ9v/gPulgRNEuCGiQ2mRXEx6+8XvwPnSlrCyE6ELibtfkr6ey3/U8VsasWMb1mvFAyPuieBDvX6E7IGkZje6dbHS0uBCUWm9d52SPA7sIorkNDtv0DysBb+gAbhdyJq4+K9JxBHng5W2gvk0Ga0WG8GbZIeF4ADkKifK0ZX1bRmIOr4ZOufkXnqA+ZWFWcP70;25:U4dSMZAKnQSbO4MqI+kPseAtSljcCswCPMmUGZHo4YfntFKDmYgf7aHLRLeXid91mKJtYcyFZOhh1IsBWSfQeHg1xuSTrZ8zymuYRkPqKmT9/l/kbMFSae9lXG5q50BsQ1jkoU3E9pyvKE2BKN7cWqCN1wRGIuWa/uFp66+DkeB+xXyb8Q0Xgm9Lwwhr8lq7Rvg0y04YULVJBeCPYo9gvJyDqo1bH6BEbBC7eCeRV0xnx9Gs13hC1FnxIPGIdrXqygHtauDb6gDAEttkkckev+J3qQNqjp1A/7x85xJFkEHSJyJ2ZjJpExtfG9w+x1hDLCD+ZjBgv27AgGI6quOUWg==;31:d4cIKFFhzxFt49rdbriRhorbMBjns0vOxn/Md35U0vCuC1hC7tmPhZjaBePv1b6NJ7z5F3f7H0Egq5H3OmARE5U8xBSTV5H5SFvZ6+Jpa4s2X18vcbvBoq2dV2TDweqIcsyQVHUyuN1+b3uk3ghIdzxXMrepaOpa0NWonpPLmiANyqMzbQYAwboKxCZehf8x15Gw9rJg9OiBwU1YahG78xyWOBKiLJNPZ969nsIKYOA= X-MS-TrafficTypeDiagnostic: BL2PR15MB1073: X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;20:NGbEF8VzwcUap+XPSLvQGIbSRmh38E+uZCA3PdONeHYYybF0fbihe0I9PGOo57ko4AzvA3U05amGRJ3z9goY87dFn00ZgXuVu82exhCLqy4K3e1NsheL4t0w//SK9SFkWjD8CW8KkeIHLSVXwrfnniZ0Q4OD6ZCJgLKhPnrNVveo95Do1eKxpku93mPXwI7rUceIuFPBQjzd6yhdlapx47o7Rpq5PAD46zrFCafx7xT53EgDB9DhKAJmwd2mFvpocIxS34SpJJy3EMEoyqwJCibqzElTg2XoTlHHl29CdQ0rTwmjtpeyrtPpg+VRBuTT3bPNmUm0GVlorQ3ePOmCpbdfp9ABBjZK0iMrwRKrVR9lPR2N3qG8YT35KyrMwPEkCLFH+fEWoubIC2SY9C3iQLxGMySIJZScC1FCHBPC1RvLklmkJlOnB1g2JIzaUK8tH+tWYVV6nViPUabEW9FJRh9xXQF4Cme9HOE1h/u9l5xY+sT1X2Z0++snFs/70UKY;4:KL2rj+WHkyE586GUeTok6MMGmsjIhNPo/7sV2IgMKf8Bde52Yba2kBvJhVSNBBO21Fxo8WjGowA1ymqe3E9p6FoSk44PQ9ptKaTXhg1c01S6ijlkrOrtLKMS8M0YjQVBuucG4k8aIDDQKPaCVwmyz8NtYcLlgmMukH5ZaQ2WSuv9znV9W++Eh6faA8RPt18smgt2B9hk9hittA/wTxzqpTsTfAS5TAzarAvcQZwBqwEeYJI0M55zOysRCUG+XVDW X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BL2PR15MB1073;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BL2PR15MB1073; X-Forefront-PRVS: 044968D9E1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(377424004)(189002)(24454002)(199003)(54906003)(7416002)(16586007)(7736002)(6916009)(5660300001)(39060400002)(2950100002)(1076002)(23726003)(316002)(81156014)(58126008)(25786009)(6246003)(47776003)(86362001)(81166006)(6116002)(55016002)(2906002)(97736004)(33656002)(4326008)(83506001)(8676002)(6666003)(106356001)(50986999)(76176999)(6506006)(50466002)(9686003)(68736007)(229853002)(305945005)(189998001)(53936002)(105586002)(101416001)(478600001)(54356999)(8936002)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB1073;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1073;23:3q6G80UDxxJ9esRf3amjUA4lg+bxfd55YmHQrMxH0?= =?us-ascii?Q?0vkN9ejAS+q4L22XMp5oZO+IwH72yDlyMZu/sezV9dK6r0yc2bzLd6akgHak?= =?us-ascii?Q?Et+SrX5Uv3091ZrkogYvXMyM+y/SoXtQo+9SB8XXZQ9LZyLEi0gkdofw7P2x?= =?us-ascii?Q?j7D5YqJl6EPQwH42joH5NdNXAynsZZLlXCsf1pSEbAQ2dAr9CXFhb4BdaMRs?= =?us-ascii?Q?x92B5Qt1P6LXxDny4pQUi5C1dac03s7mxbQGDEoVIxFo3vk3wiuUx7eagiHd?= =?us-ascii?Q?TGn6CzyNeVb6IrC3zU+YEeN2hy4T2Kw2aVOYh8KfZlU4AKfnlfGjNZLhVCee?= =?us-ascii?Q?azXRX03eXIx/vWZoQPM1QC5P8Xc0XR0ockRsYOhLaLJsQDrMUuAkoRC4fOcS?= =?us-ascii?Q?KEShTc6Cz+sdjb90uSRIS4+jaQohCKSPm8Y/qEt9Q7RbPnT3puU5ztH7W7+D?= =?us-ascii?Q?RmOk2hSxjWm+Q5fYVppIxjZryqiSkpij59/8EpIV7sbaDtBWJpIK2dPnKyJu?= =?us-ascii?Q?jNVKChcqvgdU4YQ7jzqYT5BZht9GHg2xu5Uzm+p0R6Q2ziA0okaud81iw4CC?= =?us-ascii?Q?ptCUtuLgF5uEsDgCp/jzZUDOjDv41oP7z8B/GcBQCrHq+LTW3x/0bF3QjLIh?= =?us-ascii?Q?/K3ehSvTh4GgzkqQ7fqpob1sryvoPcC7097pnng9frfYQ+aaXqAA22GtuWnT?= =?us-ascii?Q?88wvS70qMasRV8tYswdbmvzt9fMXL0jO57uyG+b1SxTSDLvQ/girh1lFM5O+?= =?us-ascii?Q?nWPO7DnRxPqyJr8J/TyKUhjAdfFPt+Q3vR7qohieH8LayKsMqrJCWP+fpfhO?= =?us-ascii?Q?4WFoSsq6jzyHCA8zxNf33brbxPoqLAjjHUAzSVQnhwUvgC5i3dADFDs7YhAi?= =?us-ascii?Q?rDuR0UCuX6yPDFVJpLtSLkW2p1qDoPdSC7Y7KRq79lcEppmeUfstK3gUW9ld?= =?us-ascii?Q?NZYVBA7uzPlyE4ZbsenRHis1n3UdYUGgZs7/FEOTjbZMtIiGg+pjqn2qnE+7?= =?us-ascii?Q?A/uycenSA1eg/SWEsZEFK6XCBWyfH8AnweDCBPfBq92uV+kBvwv3iod0E/a/?= =?us-ascii?Q?n3Gl6Be+uEfTPac+cvA3NSjR5t8NLAPA0ZboeD29mJ9GpEC4XnS6iEwe9Nyg?= =?us-ascii?Q?ofAttqrHg1Trw1yeMK7L7FuEU43kNPW/OoZ2bP2B/APyGUl/u4OyYPcev0Zr?= =?us-ascii?Q?k06vhd5xiizLJqYMPfiJdpBHF6GK1LLD/zU?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;6:p4vjyLi34aJP+QZjDtWqOQ3SKKrQIHyw2DlyYk+oejrCH45kPySSbwjvX02cq0i4YBC2L6g6IfO9g73pBNIfm0GyRwgjR6lQMEoYeyje6lx+HPcbPjn3lcyY0HosrhTEbg950kQSQi0TqqLh8tCvGZXjKFINAGA579TMUfVbKJ/7lMTiU005nBABxkdJBkQ80iLPN87Ls/3d4rQK2UE7+fwOJr/tMaQnewzQBVkLh7pJLS1Sjwhuxamlm+zxszTwQxyn9YuRfFJ40lcwLvwqSuK5TrJ24PiS+oIouE0yPPQGHeSJp4qC5zX64hceS+joi8EF2X/Rn/L4F8na4dsNlA==;5:cUwu0qslHknrHf43q/9dDnfQWx1uaPdgTo5doZ/y0W2SzexRPV0qbEUZECbCfv61N3EVHmDfGMDyCbC7fHxBcyh78zprZ7vCrC22L6bu54BwJ6JfCr0WtD4Y36/jOWerFp5HxcAp++XjaYTekqLA3A==;24:tT9B/AGYkswdnuWcGqOhR0o7UuAtuOofK1hqft/K8mn4fmahkRhIuTE2mdJTOQDXyg1PBunAJMDJxaC12QVkzU+9fzOifWVr+mWz1s6f0zc=;7:riK393aeFL8Gk1TU6n1/9P93l8DL7avK2K7hiygcRG9ZKagVOXhyiHigxOVOhSMmWslDYmQwTUF6GxoWN4i1xgN6php9d7Kf8mbOIBrN77qFqhlO0Duj5/7j7MZlK0oEITsEMEeA6Gmsghyz4vIjvNampIVa/gvYFWaKGRZ47RFp/nW01IA3xyvkhm1jrg9Lo3yXEvF4qAGh1ELGxl0Z6vq9+H/WuVU10dFPo9l+by0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;20:aEXZ1/TKQQV0GvXV/acx5+c1bTgOic/Y0ARxe4jZcFZwXuPPXtbFOTlJN/eVuM4caAn8hhN7KMiSCFTJ6WeNMgwwA6ZUQX6EA81db6WwacdLnGg1UcWAP9qZ9HaSBQD8ohREqvTLRqyvTeZFAmzmfwVU/cymHUNTvlDQMjGyTOM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2017 12:49:48.7578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB1073 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-03_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 01:50:36PM +0200, Michal Hocko wrote: > On Wed 27-09-17 14:09:35, Roman Gushchin wrote: > > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > > OOM killer. If not set, the OOM selection is performed in > > a "traditional" per-process way. > > > > The behavior can be changed dynamically by remounting the cgroupfs. > > I do not have a strong preference about this. I would just be worried > that it is usually systemd which tries to own the whole hierarchy I actually like this fact. It gives us the opportunity to change the default behavior for most users at the point when we'll be sure that new behavior is better; but at the same time we'll save full compatibility on the kernel level. With growing popularity of memory cgroups, I don't think that hiding this functionality with a boot option makes any sense. It's just not this type of feature, that should be hidden.