From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752313AbdJCMUP (ORCPT ); Tue, 3 Oct 2017 08:20:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:41080 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752288AbdJCMUO (ORCPT ); Tue, 3 Oct 2017 08:20:14 -0400 Date: Tue, 3 Oct 2017 14:20:11 +0200 From: Jean Delvare To: Colin King Cc: Mike Waychison , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: google: make structure gsmi_dev static Message-ID: <20171003142011.4bd5a033@endymion> In-Reply-To: <20171003084048.24375-1-colin.king@canonical.com> References: <20171003084048.24375-1-colin.king@canonical.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Oct 2017 09:40:48 +0100, Colin King wrote: > From: Colin Ian King > > The structure gsmi_dev is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > symbol 'gsmi_dev' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/firmware/google/gsmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c > index c8f169bf2e27..734146eec1b9 100644 > --- a/drivers/firmware/google/gsmi.c > +++ b/drivers/firmware/google/gsmi.c > @@ -84,7 +84,7 @@ struct gsmi_buf { > u32 address; /* physical address of buffer */ > }; > > -struct gsmi_device { > +static struct gsmi_device { > struct platform_device *pdev; /* platform device */ > struct gsmi_buf *name_buf; /* variable name buffer */ > struct gsmi_buf *data_buf; /* generic data buffer */ Acked-by: Jean Delvare Thanks, -- Jean Delvare SUSE L3 Support