From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdJCUjU (ORCPT ); Tue, 3 Oct 2017 16:39:20 -0400 Received: from ms.lwn.net ([45.79.88.28]:51968 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdJCUjS (ORCPT ); Tue, 3 Oct 2017 16:39:18 -0400 Date: Tue, 3 Oct 2017 14:39:17 -0600 From: Jonathan Corbet To: Borislav Petkov Cc: LKML , linux-doc@vger.kernel.org Subject: Re: [PATCH] Documentation: Improve softlockup_panic= description text Message-ID: <20171003143917.521c0649@lwn.net> In-Reply-To: <20171003155407.25471-1-bp@alien8.de> References: <20171003155407.25471-1-bp@alien8.de> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Oct 2017 17:54:07 +0200 Borislav Petkov wrote: > It should say what that range is and what that integer value > means. I had to look at the code... > > Signed-off-by: Borislav Petkov > Cc: Jonathan Corbet > Cc: linux-doc@vger.kernel.org > --- > Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 9a84483db403..c14cd2645c1f 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -3887,6 +3887,12 @@ > [KNL] Should the soft-lockup detector generate panics. > Format: > > + A non-null value "instructs" the soft-lockup detector > + to panic the machine when a soft-lockup occurs. This > + is also controlled by CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC > + which is the respective build-time switch to that > + functionality. So I hate to be fussy. (OK, perhaps I like it, but I'll act reluctant anyway...:) If it's an integer value, how can it be null? Can we say "a non-zero value" instead? I'd take out the quotes too, but that's extra credit... Thanks, jon