From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbdJCOng (ORCPT ); Tue, 3 Oct 2017 10:43:36 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58641 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbdJCOnc (ORCPT ); Tue, 3 Oct 2017 10:43:32 -0400 Date: Tue, 3 Oct 2017 16:43:28 +0200 From: Maxime Ripard To: Russell King - ARM Linux Cc: Chen-Yu Tsai , Quentin Schulz , Linus Walleij , Rob Herring , Mark Rutland , Lee Jones , "linux-gpio@vger.kernel.org" , devicetree , linux-kernel , linux-arm-kernel , Thomas Petazzoni , linux-sunxi Subject: Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs Message-ID: <20171003144328.wgk57lmda52djcl5@flea> References: <20171002120854.5212-1-quentin.schulz@free-electrons.com> <20171002120854.5212-13-quentin.schulz@free-electrons.com> <20171002204235.25d4437a2p5qzrrj@flea> <20171003091837.GK20805@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b25ylnst75befymh" Content-Disposition: inline In-Reply-To: <20171003091837.GK20805@n2100.armlinux.org.uk> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --b25ylnst75befymh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 03, 2017 at 09:18:37AM +0000, Russell King - ARM Linux wrote: > On Tue, Oct 03, 2017 at 10:06:29AM +0800, Chen-Yu Tsai wrote: > > On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard > > wrote: > > > On Mon, Oct 02, 2017 at 12:08:54PM +0000, Quentin Schulz wrote: > > >> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > > >> ldo_io0 and ldo_io1. > > >> > > >> Let's add the pinctrl properties to the said regulators. > > >> > > >> Signed-off-by: Quentin Schulz > > >> --- > > >> arch/arm/boot/dts/axp81x.dtsi | 14 ++++++++++++++ > > >> 1 file changed, 14 insertions(+) > > >> > > >> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81= x.dtsi > > >> index f90f257130d5..099b0ddc1bbb 100644 > > >> --- a/arch/arm/boot/dts/axp81x.dtsi > > >> +++ b/arch/arm/boot/dts/axp81x.dtsi > > >> @@ -52,6 +52,16 @@ > > >> compatible =3D "x-powers,axp813-gpio"; > > >> gpio-controller; > > >> #gpio-cells =3D <2>; > > >> + > > >> + gpio0_ldo: gpio0_ldo { > > >> + pins =3D "GPIO0"; > > >> + function =3D "ldo"; > > >> + }; > > >> + > > >> + gpio1_ldo: gpio1_ldo { > > >> + pins =3D "GPIO1"; > > >> + function =3D "ldo"; > > >> + }; > > > > > > The node names are not supposed to contain any hyphens. > >=20 > > Hmm, I was under the impression that hyphens were preferred in > > node names, and a warning would be added to dtc later on. > > I might be wrong though. >=20 > I think there's a terminology issue here. >=20 > "-" is a hyphen or minus sign. > "_" is an underscore. >=20 > Underscores are not supposed to be used for node names, instead hyphens > are preferred. I think Maxime means "underscore". >=20 > Here's the list from dtc/checks.c: >=20 > #define LOWERCASE "abcdefghijklmnopqrstuvwxyz" > #define UPPERCASE "ABCDEFGHIJKLMNOPQRSTUVWXYZ" > #define DIGITS "0123456789" > #define PROPNODECHARS LOWERCASE UPPERCASE DIGITS ",._+*#?-" > #define PROPNODECHARSSTRICT LOWERCASE UPPERCASE DIGITS ",-" >=20 > If strict mode is enabled, use of any of "._+#?" in the node name will > produce a warning. Right, sorry, I meant underscores.. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --b25ylnst75befymh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ06IQAAoJEBx+YmzsjxAgyXIQALWoJHZULJI/DWTK/snRtiX8 ChCEcfbt3y4hHkC+5+ucdCwaFFRG3TbiQ94UhFu5bi5foYBl2J3Q7ZfLd5gdwuUj ib/TA/IDRrCk1L3yy1NqYDgghL2RZQ8q5Xa56jeiIXNbxGh0ls4v3KQsBWkFP7JL NfuKSCtWciWuBSz9aK1XeM9atpLSRLK6Xv2Z73Xb2L+8ZtqDOpqX2BGgu+TDenKv eSAa63xDC3Or9wkhfy2vLB5nEb0si8iriXgxASuKvTrCW7ivq+Dceef+s0Rvp4O8 OPL2JVTh7i/2DoPuH1SMsUT+VuhEUS7braLiwRrHTftuMpuc6QZDpx72kqeD4rhe f66AGaI8K0vrcokYtP2/jd3n+UTm3kHSIr3T3yiflMhQBH00ZgBox8oGIN1kw//2 QWY+1cIxDLmeqj+2TqpguQr+CGzyxJc1VnFDTRXQvzkINp99G9c0yd5IVmh45+EP AfKp5HWGt0SQID5byPAhIkT/eeb0v0ZdMne3wx80NtOb5F2Gb6GLnT1NWLNBIJy3 QVg6OZKifsnWsO6T/MjDvqYElE/7kJSlPS/5Ppc99S/m8eFIIhWU4O9Cazl1FOPa yEjG6IP7Yph0yDZiHzloiHD0SZS4tTgwM1l2Q++8C+xFY+PiiF/WarNgZQRYjnWL aBD6cV32qIsJrcm3ENtV =b8x+ -----END PGP SIGNATURE----- --b25ylnst75befymh--