From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244AbdJCPCK (ORCPT ); Tue, 3 Oct 2017 11:02:10 -0400 Received: from mga09.intel.com ([134.134.136.24]:9416 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbdJCPCI (ORCPT ); Tue, 3 Oct 2017 11:02:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,474,1500966000"; d="scan'208";a="142191875" Date: Tue, 3 Oct 2017 09:06:49 -0600 From: Keith Busch To: Abhishek Shah Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, open list , BCM Kernel Feedback , stable@vger.kernel.org Subject: Re: [PATCH] nvme-pci: Use PCI bus address for data/queues in CMB Message-ID: <20171003150649.GA2195@localhost.localdomain> References: <1506662966-10865-1-git-send-email-abhishek.shah@broadcom.com> <20170929144242.GN8463@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 30, 2017 at 02:30:16PM +0530, Abhishek Shah wrote: > > On a similar note, we also break CMB usage in virutalization with direct > > assigned devices: the guest doesn't know the host physical bus address, > > so it sets the CMB queue address incorrectly there, too. I don't know of > > a way to fix that other than disabling CMB. > > I don't have much idea on CMB usage in virtualization... will let > someone else comment on this. It's okay, I think it's a gap in the NVMe specification that would allow such usage.