The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: kbuild test robot <lkp@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	kbuild-all@01.org, devel@linuxdriverproject.org,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/16] hyper-v: trace vmbus_on_msg_dpc()
Date: Tue, 3 Oct 2017 20:08:28 -0400	[thread overview]
Message-ID: <20171003200828.2da2e421@gandalf.local.home> (raw)
In-Reply-To: <201710020747.zjeQXiwt%fengguang.wu@intel.com>

On Mon, 2 Oct 2017 08:18:50 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi Vitaly,
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.14-rc3 next-20170929]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Vitaly-Kuznetsov/hyper-v-trace-vmbus_on_msg_dpc/20171002-062040
> config: i386-randconfig-x017-201740 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/trace/define_trace.h:95:0,
>                     from drivers/hv/hv_trace.h:29,
>                     from drivers/hv/hv_trace.c:4:
>    include/trace/trace_events.h:759:13: warning: 'print_fmt_vmbus_hdr_msg' defined but not used [-Wunused-variable]
>     static char print_fmt_##call[] = print;     \
>                 ^
> >> drivers/hv/./hv_trace.h:9:1: note: in expansion of macro 'DECLARE_EVENT_CLASS'  

Interesting. I'm wondering if this happens because the class "print" is
not used.

Actually, I think the default print should be used by one event, and
if other events need to be made that change the print, it should use
the DEFINE_EVENT_PRINT()

But this may be moot because I think Stephen Hemminger made it back to
DEFINE_EVENT()s.

-- Steve


>     DECLARE_EVENT_CLASS(vmbus_hdr_msg,
>     ^~~~~~~~~~~~~~~~~~~
>    In file included from include/trace/define_trace.h:95:0,
>                     from drivers/hv/hv_trace.h:29,
>                     from drivers/hv/hv_trace.c:4:
>    include/trace/trace_events.h:363:37: warning: 'trace_event_type_funcs_vmbus_hdr_msg' defined but not used [-Wunused-variable]
>     static struct trace_event_functions trace_event_type_funcs_##call = { \
>                                         ^
> >> drivers/hv/./hv_trace.h:9:1: note: in expansion of macro 'DECLARE_EVENT_CLASS'  
>     DECLARE_EVENT_CLASS(vmbus_hdr_msg,
>     ^~~~~~~~~~~~~~~~~~~
> 
> vim +/DECLARE_EVENT_CLASS +9 drivers/hv/./hv_trace.h
> 
>      8	
>    > 9	DECLARE_EVENT_CLASS(vmbus_hdr_msg,  
>     10		TP_PROTO(const struct vmbus_channel_message_header *hdr),
>     11		TP_ARGS(hdr),
>     12		TP_STRUCT__entry(__field(unsigned int, msgtype)),
>     13		TP_fast_assign(__entry->msgtype = hdr->msgtype;),
>     14		TP_printk("msgtype=%d", __entry->msgtype)
>     15	);
>     16	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

  reply	other threads:[~2017-10-04  0:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 13:25 [PATCH v2 00/16] Hyper-V: add tracing to VMBus module and trace all messages Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 01/16] hyper-v: trace vmbus_on_msg_dpc() Vitaly Kuznetsov
2017-10-02  0:18   ` kbuild test robot
2017-10-04  0:08     ` Steven Rostedt [this message]
2017-09-29 13:25 ` [PATCH v2 02/16] hyper-v: trace vmbus_on_message() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 03/16] hyper-v: trace vmbus_onoffer() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 04/16] hyper-v: trace vmbus_onoffer_rescind() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 05/16] hyper-v: trace vmbus_onopen_result() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 06/16] hyper-v: trace vmbus_ongpadl_created() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 07/16] hyper-v: trace vmbus_ongpadl_torndown() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 08/16] hyper-v: trace vmbus_onversion_response() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 09/16] hyper-v: trace vmbus_request_offers() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 10/16] hyper-v: trace vmbus_open() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 11/16] hyper-v: trace vmbus_close_internal() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 12/16] hyper-v: trace vmbus_establish_gpadl() Vitaly Kuznetsov
2017-09-29 13:25 ` [PATCH v2 13/16] hyper-v: trace vmbus_teardown_gpadl() Vitaly Kuznetsov
2017-09-29 13:26 ` [PATCH v2 14/16] hyper-v: trace vmbus_negotiate_version() Vitaly Kuznetsov
2017-09-29 13:26 ` [PATCH v2 15/16] hyper-v: trace vmbus_release_relid() Vitaly Kuznetsov
2017-09-29 13:26 ` [PATCH v2 16/16] hyper-v: trace vmbus_send_tl_connect_request() Vitaly Kuznetsov
2017-10-03 17:10   ` Stephen Hemminger
2017-10-04 14:10     ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003200828.2da2e421@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox