From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbdJDJCO (ORCPT ); Wed, 4 Oct 2017 05:02:14 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35370 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbdJDJB7 (ORCPT ); Wed, 4 Oct 2017 05:01:59 -0400 X-Google-Smtp-Source: AOwi7QChYmwcGloRWpNewzTBdUbTW9d2OnRT/VCqTi1u5DJReZyEyB8CQ/8A9CaZcZHoZ38Z6k5Y0A== From: Johan Hovold To: linux-usb@vger.kernel.org Cc: Andrey Konovalov , linux-kernel@vger.kernel.org, Johan Hovold , stable Subject: [PATCH 2/2] USB: serial: console: fix use-after-free after failed setup Date: Wed, 4 Oct 2017 11:01:13 +0200 Message-Id: <20171004090113.24218-3-johan@kernel.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171004090113.24218-1-johan@kernel.org> References: <20171004090113.24218-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure to reset the USB-console port pointer when console setup fails in order to avoid having the struct usb_serial be prematurely freed by the console code when the device is later disconnected. Fixes: 73e487fdb75f ("[PATCH] USB console: fix disconnection issues") Cc: stable # 2.6.18 Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c index ed8ba3ef5c79..43a862a90a77 100644 --- a/drivers/usb/serial/console.c +++ b/drivers/usb/serial/console.c @@ -186,6 +186,7 @@ static int usb_console_setup(struct console *co, char *options) tty_kref_put(tty); reset_open_count: port->port.count = 0; + info->port = NULL; usb_autopm_put_interface(serial->interface); error_get_interface: usb_serial_put(serial); -- 2.14.2