From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752064AbdJDJQT (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 05:16:19 -0400
Received: from mx2.suse.de ([195.135.220.15]:41015 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751891AbdJDJQS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 05:16:18 -0400
Date: Wed, 4 Oct 2017 11:15:53 +0200
From: Borislav Petkov <bp@suse.de>
To: P J P <ppandit@redhat.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Gary Hook <gary.hook@amd.com>, Tom Lendacky <thomas.lendacky@amd.com>,
        linux-crypto@vger.kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [Part2 Patch v4.2] crypto: ccp: Add Platform Security Processor
 (PSP) device support
Message-ID: <20171004091553.n4judraxqbravx6v@pd.tnic>
References: <20170919204627.3875-6-brijesh.singh@amd.com>
 <20171002164344.12750-1-brijesh.singh@amd.com>
 <nycvar.YSQ.7.76.1710041202020.19122@wniryva>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <nycvar.YSQ.7.76.1710041202020.19122@wniryva>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 04, 2017 at 12:06:42PM +0530, P J P wrote:
> Needs to kfree(sp->psp_data) before setting to NULL.

Not if it is allocated with devm_kzalloc().

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--