From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbdJDLPl (ORCPT ); Wed, 4 Oct 2017 07:15:41 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:49164 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdJDLPj (ORCPT ); Wed, 4 Oct 2017 07:15:39 -0400 X-Google-Smtp-Source: AOwi7QDe9JTMgW25XXkF2hMKxDxFU2CunRxhUdTxpC7F3Vs6bY/ajPuL2b1hg3DtlYT8qj8n2zQHKQ== Date: Wed, 4 Oct 2017 12:15:35 +0100 From: Lee Jones To: =?utf-8?B?5Yav6ZSQ?= Cc: Ulf Hansson , Greg KH , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , =?utf-8?B?5ZCz5piK5r6E?= Ricky Subject: Re: =?utf-8?B?562U5aSNOiDnrZTlpI0=?= =?utf-8?Q?=3A?= [PATCH] mfd: rtsx: Add support for RTS5260 Message-ID: <20171004111535.b7zhrcnduqnkrtwu@dell> References: <1506072984-32415-1-git-send-email-rui_feng@realsil.com.cn> <20170922095432.GA8112@kroah.com> <2A308283684ECD4B896628E09AF5361E01A7303B@RS-MBS01.realsil.com.cn> <20170922120216.cq5lvsseoyukgids@dell> <2A308283684ECD4B896628E09AF5361E01A734C6@RS-MBS01.realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2A308283684ECD4B896628E09AF5361E01A734C6@RS-MBS01.realsil.com.cn> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Sep 2017, 冯锐 wrote: > > On Fri, 22 Sep 2017, 冯锐 wrote: > > > > > > On Fri, Sep 22, 2017 at 05:36:24PM +0800, rui_feng@realsil.com.cn wrote: > > > > > From: rui_feng > > > > > > > > > > Add support for new chip rts5260. > > > > > In order to support rts5260，the definitions of some internal > > > > > registers and workflow have to be modified and are different from > > > > > its predecessors. So we need this patch to ensure RTS5260 can work. > > > > > > > > > > Signed-off-by: Rui Feng > > > > > > > > Nit, this name needs to match your "From:" line. It almost does :) > > > > > > > > Why is this a drivers/misc/ driver? > > > > > > > I want to put this driver in mfd because other drivers like > > > rts5249,rts5227 and so on are in mfd, but lee jones said " There is way too > > much code in this file to be an MFD driver. > > > > There's more to it than that. > > > > It's not an MFD driver because it's a card reader an nothing else. > > > > MFDs cross subsystem boundaries, whereas this is just a card reader. > > > > MFD isn't a dumping ground for devices which don't belong anywhere else. > > The functions in rts5260.c are called by drivers/mmc/host/rtsx_pci_sdmmc.c, it cross What subsystem boundary does it cross? MMC and ... ? > Because many other similar drivers are in mfd, if relocate rts5260 now will lead to a much bigger modification, Totally fine. > and customer is in need of this patch. I think put rts5260 in mfd is > better now. The upstream kernel is not customer focused. > If mfd is really not the right place, MFD is not the right place. > I will relocate it later not in this patch. > Greg, what do you think of putting rts5260 in mfd? Trying to leap-frog me will only seek to annoy and will not help your cause. > > > So I put it here. > > > > Without creating a new subsystem, I can't think of a better place for it either. > > > > > > > --- /dev/null > > > > > +++ b/drivers/misc/rts5260.c > > > > > @@ -0,0 +1,590 @@ > > > > > +/* Driver for Realtek PCI-Express card reader > > > > > + * > > > > > + * Copyright(c) 2016-2017 Realtek Semiconductor Corp. All rights > > reserved. > > > > > + * > > > > > + * This program is free software; you can redistribute it and/or > > > > > +modify it > > > > > + * under the terms of the GNU General Public License as published > > > > > +by the > > > > > + * Free Software Foundation; either version 2, or (at your > > > > > +option) any > > > > > + * later version. > > > > > > > > Do you really mean "any later version"? (I have to ask...) > > > > > > > > > + * > > > > > + * This program is distributed in the hope that it will be > > > > > + useful, but > > > > > + * WITHOUT ANY WARRANTY; without even the implied warranty of > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > > the > > > > GNU > > > > > + * General Public License for more details. > > > > > + * > > > > > + * You should have received a copy of the GNU General Public > > > > > + License along > > > > > + * with this program; if not, see . > > > > > + * > > > > > + * Author: > > > > > + * Steven FENG > > > > > + * Rui FENG > > > > > + * Wei WANG > > > > > + */ > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#include "../mfd/rtsx_pcr.h" > > > > > > > > That looks "odd" :( > > > > This is odd. > > > > You should move that file into include/. > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog