From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbdJDPF2 (ORCPT ); Wed, 4 Oct 2017 11:05:28 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44664 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbdJDPFZ (ORCPT ); Wed, 4 Oct 2017 11:05:25 -0400 Date: Wed, 4 Oct 2017 16:04:52 +0100 From: Roman Gushchin To: Michal Hocko CC: , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , , , , Subject: Re: [v9 3/5] mm, oom: cgroup-aware OOM killer Message-ID: <20171004150452.GA23299@castle> References: <20170927130936.8601-1-guro@fb.com> <20170927130936.8601-4-guro@fb.com> <20171003114848.gstdawonla2gmfio@dhcp22.suse.cz> <20171003123721.GA27919@castle.dhcp.TheFacebook.com> <20171003133623.hoskmd3fsh4t2phf@dhcp22.suse.cz> <20171003140841.GA29624@castle.DHCP.thefacebook.com> <20171003142246.xactdt7xddqdhvtu@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171003142246.xactdt7xddqdhvtu@dhcp22.suse.cz> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [2620:10d:c092:180::1:88b5] X-ClientProxiedBy: DB6PR0202CA0033.eurprd02.prod.outlook.com (2603:10a6:4:a5::19) To DM3PR15MB1084.namprd15.prod.outlook.com (2603:10b6:0:12::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0db9ca9c-a1b7-4ea0-809e-08d50b394be0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM3PR15MB1084; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;3:WauCwdIvYfOHYmoz/D6vz+s0HRwK5KiA/TE1djuFYHh8alCfnr/WcR2ne7HZca3Ybb8jXvtJTkmiZee3HmJ91PNpPqstVOI7vf1y0zqJfafas9SDoq/Y6F/qTwdyNwC/TnIelxNOt9QmS1sAChwRIjI9TZjUj6NFey67XnFTlmtpW1vD52mdqJRjNIcSePuzb5DafQTVig7XD4XIwFIXE0MVeVPzds80wWxOxlq8lKlnVUJU9Q/htzRjj7dokYDz;25:OYeHGdF/6C55R13iz+9f2cWmbQpk6UYiWBbYM4F7rLDyLKpO5I5fGB2aS0cmBcBsB5PhXyTJnC736N2qvGKA1/gioIObtkg7X45cxMkExFBvCrAPvPLyuahxvixK0o6WPHZdrkmxKdfBdjMu03H8CbfpvkWf6ARiChjpL+3iLvemrFn3ctxMDOM+7zFO6EJIURqnYEVlA/2ADzvNtYzWykXilZtMhcdklfuYOB8e0VzLesKVRorsdx2Ld38JiWRtMeTA49Br7lkuyXFTpj/Q6znV9TjOX2dXbI199BmlURTkSXS5EqcUDCTy+NLFCHeNQxZjeuipCOQfl2vRbPDQ/g==;31:GwNKKJmdbRq0kTwfiFxT5nGe4YZtnvBUjHdCod6JSO4bsA2H1On/LQnzZphHj5arQhczgfF4A9A1lbvK1QGLjPNeiomnXbcqLxfyZuO2FyeVWXCEi6fIjSVAo/kYAtqxhkuPISh4ooGD6bLBeTkZFX6+ka98iNl7KVelx8Joxzzp/W8h5R11T9SswlVrwFEBsUy3CR49qoygRlL5pvqHA2ajuLBjQ9Dj0U1/08+LVgs= X-MS-TrafficTypeDiagnostic: DM3PR15MB1084: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:a7P3ZOzfFyYDx5RcXTWV4AjUw1r7uH+3RQdJZ7dBvkm+E6eU0Rzk2YRzn9+bb6F1minDPv3DCPJ0wb63NyMQcuo6Yom+FhJ1fuqYqKXLAjwQ1Qum+LwPeWmylVVyOL0b7R4zAbaZa1sZxcsFkmdyCsAHo4ZRlYZU/yq1CJPbiQa4dnt/T3BwDkHvSfcdM7hqhJa7fjNfcK1uOXolvn4caWSwv8VvRR0Rgb4A4Hz4hgaqSebgvmLVS2LDCPK+swC6ra5btebk1mlZWyxJ9RAfITI5lB+HBHk0YBtqdxzTO7MrLTDy9m0ZnA6O4WVAm4vOM9QmDLs8IMXonlPwB1AB5PeVzsVEiQ5WBSlm/uKoHnj/MWkAuUbCxUEbOHuFaznaSn69yi6xk/eKV+eqhQxzEZQ4giVcZBRbo85yo7ly2PCrHcJCZ2iF5XviV2YDd/HK/aIT7iuRi11Z3o32ytdSNY3yAqio97cTr210DrA8Nn3b7rSareo7qyseQGQh9OW1;4:ckaQfVTkEuD/WlO7nq70oiMLRJI84IVX8yg+4jgL619pU1IwsaMh1II4XoffOZDpZiBqTwELgavzW3hF52O5M1SGsxtonCWTgeMUxsjy7qeBpwj7Qkg5nohQmMdFZldCgP86famVTP/KVBmBx77wUoac3rAwDOiFLUw/Siy3uwwPPNmMXk0vkOvR7t7OOmR19RZIKGhhJsLd0baYMZi6/sQ4Hi4UA/ecH6KDdLNIMODok8dFgWnZGZLHAiKZQrJW X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM3PR15MB1084;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM3PR15MB1084; X-Forefront-PRVS: 0450A714CB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(24454002)(189002)(377424004)(199003)(23726003)(7416002)(7736002)(2950100002)(8676002)(5660300001)(6916009)(81156014)(81166006)(86362001)(97736004)(93886005)(68736007)(83506001)(2906002)(8936002)(305945005)(33716001)(105586002)(50466002)(54906003)(55016002)(33656002)(106356001)(229853002)(1076002)(76176999)(6116002)(58126008)(101416001)(9686003)(189998001)(316002)(6246003)(4326008)(50986999)(53936002)(6666003)(6496005)(39060400002)(25786009)(478600001)(16586007)(47776003)(54356999)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1084;H:castle;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1084;23:FXKwgftfARM5VH4hnbYYR5aAO/LuNyg6KGhLsRM93?= =?us-ascii?Q?2ahIV233q97J39fTRxfLohTMSKTjWNdfaHPfatOSiVYQVuskxiEwaH3u/wuZ?= =?us-ascii?Q?VCUTbS8QoFADTE62Fx+OhGy6OSJu9ENr5wKFR21uj5xt9RCQz5Z7YVaBq1ns?= =?us-ascii?Q?8TRJueZKJmS2eCCCDe4/TBNYQSJuRpkFhJ7htWhO4Fi/V0rlg/5Jwcyxn2f0?= =?us-ascii?Q?V58TBm6ZElouyfkjmoTOAjxHgKR2KjMsLRgdSILSqS/Plcu8RR/K08lwBt2I?= =?us-ascii?Q?0vC9PJtTaVckAmcybvoOWcc73HTwZFGbQ+3xrQPpCkfD4XsKDQCZGcVpcdT5?= =?us-ascii?Q?AYz5A5XGlzw3OK0lO8xPwGe0fMi9ITZuxCzz0YRsdCZs9G8Kbd4PPn0PyhVk?= =?us-ascii?Q?X4GCVB44Nj+0teO7Iq34/B2Jrmerx6Der1NBQCyDUVGuSkMQVHIVR09qtOg2?= =?us-ascii?Q?rJRBY9h3AsSSm1+KF0CUhdpQQRSjQNo+f4FDRradjImOL5UDrKftB4TO5hsS?= =?us-ascii?Q?1rZbNWjHY+KIt7lFO2Jkqd1TleqGrjb5p6jqtfyIUmbn92Yc+tnIA03HQq56?= =?us-ascii?Q?GVKfYdVgoW6vfDUtFrzxsOjwY1V8PEkfiwY7fMFpy+DuMcsvFW/ik/Gf/Dns?= =?us-ascii?Q?GaTP6dJ4vm3KF48MdPAqrIIRuSnxHziWd0kmTf1gzkQ6QhFHFPT3OkeMo7i6?= =?us-ascii?Q?5TAdKZ0l2agmvPMRPzl2Z5tHj4XXBHSpF8lH16cF49l3a3hjqGdHIYPvv9wf?= =?us-ascii?Q?TU9AEsYQ7h9ZZFD5nQkh0e6vJiSA3LR6gbN8lxcOeN6G7rg0AIjmgxnELSZE?= =?us-ascii?Q?fMwHCKy7IPFU0A2SGxFIQcBfKlw606er8XiXPaAjZcfZTNZ7JYS1SqG508Br?= =?us-ascii?Q?yVpGDpnbT+YMMbaabp0CJZ9U54piEsg2VCedp5ZnVPxoOGA0TymesKhe6ASU?= =?us-ascii?Q?XF+aNi0UqG3LTjik+0aicHT+aZ7LNuz/53bgXSsY2nDfuYmdiwDyBejfem/P?= =?us-ascii?Q?tvlqbDqO71zxDIhwcTPjtrWIf9lgZdyW89LboqWWXbPfhhs8ya3G5FXKNxYX?= =?us-ascii?Q?LscGnERGBM59+ZPSqAHQdgn1tHl/av6kp4+trq4CzLjHcBie52HolwbTEC3x?= =?us-ascii?Q?6hFzo06uzX2cxGWRG9H9/F65PQtgfv2zHdEVh74hrqihlPtODNDvx1BTgni5?= =?us-ascii?Q?3eBHylGPPda8RQV5hzgclBj9qOxmpoVFG2F1US1iwRzHs2+sfrv8VcvKdyMG?= =?us-ascii?Q?Kw0rnq1qYqgqDoXOIk=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;6:v5UEyefzprU1IdYOYFN2CRASBXUemHz+RJ9d0grQefCUPqkE1/IBOwiB03blfciUkqg++B4qIBYJgV53qfO+mF4IIHKDiiLSEtOWi1MsCz1PooY4UXDHMQo8Usg+P5J1DU5Po1hu6D8g7lEZ6+ke1BTTg+pB4IeC7E+CBo6W3ux/ceoTylqBFlw2NDK3KO6LcMnjHiMqUleWKvS/SOvsPpOGf57uiwI3Z6XpJV2DE+ZQMDGML9RroiLhwZatCmtOTofUegbMROWLxv1KHThDQlhCcLBwY0bcKdbLTJ/jZrDFaSoF7gH38ebVIshrpO+1v+etQIA8uprCJ4Rnnb9AOA==;5:8o6JFsMJcPdXZlIPmGnRuJECd/cvty059xcXuewGfrw+/NgoECGvg6F5tM8VVxKancTZrtrrVvi1shY1bc8+s5r51CJ3zQNnNWrLwhYtqZmg4RIfLzwPI97qgZVL/frzNH4Xqp6XU1kOJ2ufaJyPrw==;24:KPLl9AnkOD1XgfA743fQJgTbTYXIcTo5sPilf2FfK0B45d9TvryI3WA9bP4WKj2URn7NlZs/njeugK+PK0OfqoTHKvXhKrDGpdjmXMfhuxg=;7:oqVDLBBTKhn4zU39dyJEDS7BF17h6kbXvOxgdkcTWTYBJroO38E8oCkCQlgUAw6JZmCd5JB9LMMts22ANSFNlSfVE5vU7qozskR/VC5aWYS+xjGA6gHHVzIZIF+afLFnXdHxSkpIYyYP6hwXT173VnS1YXLAJ+ajLRy9NnJIsx+J7AaenYUMjBA5GQvYfhzUp0ZConh9Q434sVP8CMrVZizVAqg+jyP4rQ/zj5UuUdg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:uUcwlruENPx2UxjN4u81RWLGyMs0zXBdcEjm43Vbcfh2YsrNeCBB2E10Se+PzZFshehXybQ8AZ0eGFZx/9vO6JW8eWLcp5UwHILTzNMZ3Et6tqoWchdMONDxlTiH3nbeoHeLI5hR6LyFFyBPKujpM/G45Apnxv0g0M/bX+OSrv8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2017 15:05:03.4494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1084 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-04_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 04:22:46PM +0200, Michal Hocko wrote: > On Tue 03-10-17 15:08:41, Roman Gushchin wrote: > > On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: > [...] > > > I guess we want to inherit the value on the memcg creation but I agree > > > that enforcing parent setting is weird. I will think about it some more > > > but I agree that it is saner to only enforce per memcg value. > > > > I'm not against, but we should come up with a good explanation, why we're > > inheriting it; or not inherit. > > Inheriting sounds like a less surprising behavior. Once you opt in for > oom_group you can expect that descendants are going to assume the same > unless they explicitly state otherwise. Not sure I understand why. Setting memory.oom_group on a child memcg has absolutely no meaning until memory.max is also set. In case of OOM scoped to the parent memcg or above, parent's value defines the behavior. If a user decides to create a separate OOM domain (be setting the hard memory limit), he/she can also make a decision on how OOM event should be handled. Thanks!