Re: [v10 3/6] mm, oom: cgroup-aware OOM killer

Johannes Weiner
2017-10-05T10:27:31Z

On Thu, Oct 05, 2017 at 01:40:09AM -0700, David Rientjes wrote:
> On Wed, 4 Oct 2017, Johannes Weiner wrote:
>
> > > By only considering leaf memcgs, does this penalize users if their memcg
> > > becomes oc->chosen_memcg purely because it has aggregated all of its
> > > processes to be members of that memcg, which would otherwise be the
> > > standard behavior?
> > >
> > > What prevents me from spreading my memcg with N processes attached over N
> > > child memcgs instead so that memcg_oom_badness() becomes very small for
> > > each child memcg specifically to avoid being oom killed?
> >
> > It's no different from forking out multiple mm to avoid being the
> > biggest process.
> >
>
> It is, because it can quite clearly be a DoSand was prevented with
> Roman's earlier design of iterating usage up the hierarchy and comparing
> siblings based on that criteria. I know exactly why he chose that
> implementation detail early on, and it was to prevent cases such as this
> and to not let userspace hide from the oom killer.

This doesn't address how it's different from a single process
following the same pattern right now.

> > It's up to the parent to enforce limits on that group and prevent you
> > from being able to cause global OOM in the first place, in particular
> > if you delegate to untrusted and potentially malicious users.
> >
>
> Let's resolve that global oom is a real condition and getting into that
> situation is not a userspace problem. It's the result of overcommiting
> the system, and is used in the enterprise to address business goals. If
> the above is true, and its up to memcg to prevent global oom in the first
> place, then this entire patchset is absolutely pointless. Limit userspace
> to 95% of memory and when usage is approaching that limit, let userspace
> attached to the root memcg iterate the hierarchy itself and kill from the
> largest consumer.
>
> This patchset exists because overcommit is real, exactly the same as
> overcommit within memcg hierarchies is real. 99% of the time we don't run
> into global oom because people aren't using their limits so it just works
> out. 1% of the time we run into global oom and we need a decision to made
> based for forward progress. Using Michal's earlier example of admins and
> students, a student can easily use all of his limit and also, with v10 of
> this patchset, 99% of the time avoid being oom killed just by forking N
> processes over N cgroups. It's going to oom kill an admin every single
> time.

We overcommit too, but our workloads organize themselves based on
managing their resources, not based on evading the OOM killer. I'd
wager that's true for many if not most users.

Untrusted workloads can evade the OOM killer now, and they can after
these patches are in. Nothing changed. It's not what this work tries
to address at all.

The changelogs are pretty clear on what the goal and the scope of this
is. Just because it doesn't address your highly specialized usecase
doesn't make it pointless. I think we've established that in the past.

Thanks