From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbdJDUWq (ORCPT ); Wed, 4 Oct 2017 16:22:46 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:38834 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdJDUWn (ORCPT ); Wed, 4 Oct 2017 16:22:43 -0400 Date: Wed, 4 Oct 2017 21:22:07 +0100 From: Roman Gushchin To: David Rientjes CC: Johannes Weiner , , Michal Hocko , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Tejun Heo , , , , Subject: Re: [v10 3/6] mm, oom: cgroup-aware OOM killer Message-ID: <20171004202207.GB4174@castle> References: <20171004154638.710-1-guro@fb.com> <20171004154638.710-4-guro@fb.com> <20171004192720.GC1501@cmpxchg.org> <20171004195110.GA18900@castle> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [2620:10d:c092:180::1:34c0] X-ClientProxiedBy: AM5PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:206:1::27) To DM3PR15MB1081.namprd15.prod.outlook.com (2603:10b6:0:12::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f5b7ea0-a33d-45d7-dc22-08d50b65a0fc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM3PR15MB1081; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1081;3:JWNS3fxKDI447LnNLulG5Wl1lSu40ze8jQ/lJPGMK7R9mngCdX4RpIeUdfs9LobXbjPSRUYhFD1h8dG/EsZTCGfh0XpPR/x5tmxDf+peeAJ+OAv7N51i6UXl6gttsFQHxA27DraSz1yTdxHvAaQa6zGY2j5p/elIgiFwJ1nXrbc+9HpYW8qicadX9mbsliWm8rHIa2IQb5VPgxO1RU1Y7LahRikmqA30wEPUoAkt9vE72Qzl6eTev8eyelq6ks2n;25:apqkTnW9CV6PZ3oPmGBPm+KVbk5cRnhWZCPhysBFma8+K9R8Hbuk3Ud9yI1Eomqu0slzrHV+UzFGdEGJ7XPtn545pej7xKDmXOsjtbIVxDUvGc9oCNHgsfgye209qIlB/jeWUBpI/QiC5qON+g79/bOhDB5Hl3YHb3NsMQqczzaERi8h6eKE70MobdmqwrCu0gmXJuy38xl1399gzKHQhvSC5bK+F09+nCh+lLrmhoQFezy5LxpXW8nBV+eknH/NHpCZPRMfIIsW82FJQighsn+laXZ5tRaLRLP2/M0HkZ4DC2XVis+agIzEAAma8XXttiKXxEYhR7DICIy0hDOS3Q==;31:PAT4mMgimQo+X0mfCIP0Vly9Hf9O1br/tZX0A09XmY45Ga8Nk7/X73iUg5BCXRMNQj3dnkMJIE5koyCBjgiIHxT+E2jcN9r9/Lf4fmcVs9WqCRMTw1L9OSpLRN1g/tPb/AYKm6BFir5yMKsg6pWpIdH6uqOb6E3Se/FQsWDv+y/1SUfq4KKaRUQchOuXqfiUlMHE/DlW2x21ZKk3uk8oXp1xRHtPEy9QQyVNMuw5D6k= X-MS-TrafficTypeDiagnostic: DM3PR15MB1081: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1081;20:FmRCYgRjgn5ynH5Ef5gxak5w8GLldPyST930NUb8c9wM3ZPkXhJxodE60TC2rjTwZZKl1h86TqjPpMbJnax3GBkf5fKbQtJ+UDwpCm+Cxd3aJTM71Pyg8gexbKUFEHNV4ugyr5cwbmhBvEOvlk81vZeS3ApPV9fTUC9cN0xUNsYtS0BWuX4TpFcQfwHGVFpA4KmAl0AAIeAY16pmPEvF7Upx0ymyJC6evVjGHjO9hHUIUVMJulKA8yeAf4+x8ZhVh/FCh0pvZIpqBrEW8DpoddqwuhMLTFXnLlODeVwBh3X4uDXZfJpLQ9i+FVV6jBdZnSaokz7G9AMKXxSu1hwOYOl0nV2y6RwU5fmglRNlt64UXDsBgfim9oi1zFL/ldt79FHCnnlsxa8ZnZkd0ywRKPUD7d0PVxE8fZhS4U3a7KL26Xz/+qQ+O4j7i1WQR90MkVVYPiYgUbqINaY//rod3FKyycSlIw7ezOUKFJbYyHPgM5/AEATu9tFO7W1VG/6g;4:VMHpSlKeexLcOL0kdb1gqVXbtxMlBxLLt/FFpEKIYDGs+VhJwlKlmcmaA7tMUy7jx0sAE2xhfC+/1cHWv5J62+ulknXoPfPpG3OLb8EF1NYYOBLS35/beuqScmKQyGkWgidnP28n8hnCbcShMHfx1TFy+TcuWTIW8nBbbDta+iGUYtTu7yOckw+ZtogIXzBBqMTrGfCyvjlzAurjSs9puTBFAwB6JXVMb1R8NPKsMJRW1XZT7cRtF8J2/4wYo73Y X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM3PR15MB1081;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM3PR15MB1081; X-Forefront-PRVS: 0450A714CB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(24454002)(189002)(199003)(51884002)(50466002)(6116002)(5660300001)(1076002)(47776003)(9686003)(83506001)(54906003)(7416002)(229853002)(316002)(97736004)(33716001)(25786009)(53936002)(2906002)(6496005)(16586007)(86362001)(6246003)(58126008)(33656002)(6666003)(4326008)(478600001)(50986999)(76176999)(54356999)(2950100002)(39060400002)(81156014)(101416001)(81166006)(23726003)(93886005)(55016002)(6916009)(105586002)(8936002)(68736007)(189998001)(8676002)(7736002)(106356001)(305945005)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1081;H:castle;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1081;23:EU+nqxeCnTSxCEK6tU03wCQWLjSl4YReZrVLghJ2m?= =?us-ascii?Q?c4gh4f/6CIfvXoZCNvTps+pwpo+WYgkFEKqVMS2bauirTFx+whQsfsXZnWTo?= =?us-ascii?Q?J2Pnchw5FBWWWXedi9h4/j2iYcnA/hKkV8Ix6FRLfWLd+mwGZp2n7XKJphH+?= =?us-ascii?Q?9LOgaD3938YjgzvNtgcRijCIxQ2QxZw99USGVoEXE7RxMfdEEFffZklnaaOj?= =?us-ascii?Q?mGzkxLYxHm0oAF/6SS5e2FyuzQurrGdTsUSiqJ/fZ3wsQTLX9tARdkhfs0/6?= =?us-ascii?Q?jyRpVwTvXfYXw3z3AbklNBsj7C0fgOm9lYFY5GB3y30EbNm4SBkOsnSTvP6V?= =?us-ascii?Q?cE1lFid9+uCI5QrBFdyKU+3JghJ72lq6PZxKmxyhsmUEoR8NIHqVgs4mkkuu?= =?us-ascii?Q?SFuZivLMNXICN9AVFkDa61b6nupxIVJjJMj5AKBWgSqXP0oKh/1PmlgkWRL3?= =?us-ascii?Q?aRtvJHW2i5BUaRnLuCXkTLx1VNv9ZQ8Thh/lfTvnDPfBiCry6tUsa/2dlbyq?= =?us-ascii?Q?B26c/GO6i36n6bc+VnMGsEYxfddfHbQgpswVXf/Znt8m8F0kZZRhyCi+i+g/?= =?us-ascii?Q?kTxFp6D4puxWV+Xsi1Qnuq4oCf+x7mUpQS6BAuccb4xKUc+guTAIgDPFS+wn?= =?us-ascii?Q?r4N1/fgN9yHAJwLdCcZ5Hw5jB5Wcumy52z3D8UHBCkpoVnNoEGxgq6nU3/g4?= =?us-ascii?Q?A/BVKarTO91nDPgbbDd+Lgvdf8RrzNw4XWeTli0xcQ1Z+MD6RLC8RQBfvFpK?= =?us-ascii?Q?wEHR3pBUFPsjw4y0S7xuyZxIhv94n6QuJWowGOVJw9oaqc00let3mmA4nTAC?= =?us-ascii?Q?WmHlPFiJT6osEEnWslGICP9G7lfwuU+jVXd7KChPjNGscE4KqRvurIF+C4X2?= =?us-ascii?Q?MKGTkaaj2WsCwvjGPbRNLEx9PTTbg7DXdN/8+MLhMhfYQWLoGAGhxhAcbHLZ?= =?us-ascii?Q?unIlytxag5fEkSrCU+9GiDzceLmL7wZLbsFiAWUtCSv2hgEVBHtue/A88Cqi?= =?us-ascii?Q?EFPUe5CEMfzkPR2+HX6GCuJAwmP3+Y+2CMOgWTXUBHuwWSKDskwWg6W/2YoR?= =?us-ascii?Q?vkuWPcOFxuCm574Tnp1jDC2vdhOD0vHpjq8XJELiBiuWDNvyvYXZZqRMf5ao?= =?us-ascii?Q?2maKuatRwkUXgpyyi7spoSJWbw359x8gwezvexvlByyb6m+Mb4vxnU6FotET?= =?us-ascii?Q?4W7WlZ1EvIY/MBtHiNGdZZWx+b+4svsu0gVrgenQN/HLT3B5kJtSz+XhgI4r?= =?us-ascii?Q?ccIl9aNkErEklTufrI=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1081;6:XWgYPz92rI98WIfsZxt2qeKIAL98VL+hL1j4mrNoAl83aZ7TxSXrw9ysXcHqv5a3P18gNmYMICIHg2v2YW/8ibwUOxnhaVKjcMDd8seba8qKsKLuenhJPVypqudPv1o3+R3Wk68jgvNNnrqBRJdWAr1EIzth7jzBk7JqBhTTQQDE6ZE6UJfghPp78IwiMXMFI62rwuHXSSXjsC64U1YFp+c/6jzkLjnGIwfnSdmMNUdf57C3hfXpxa1PVA1oLOI8JmjJSznvvBUbvvjy1cRqtjgKYP5BGXX4Qq0kt5JM28w0tEvimEFFkN9Qdo3uq2GOPNPkil1TGmGU+bSLCPF6Zg==;5:FQZrBGaLgxmJanBTXdsbZzYYMgPf14VQSvey/55thOCJiMziYJO4gfFF5VakxQvD9nafJjO9lJqIsxjfhknbWBKIo5KyUVTlIpEnFqy5PqLvP4CWfMXC8e3ofnX1WBEqpNDUGiFkp1H8sJskJ1P5cw==;24:ikQdsl3W9qg0W80mCpmnjrB48NffSht8auuEtDPqH4ThOj9kCFrI3hO7EtkbbA5Btvu7FLfd0RPSIlFQhjzSmdt2u21vvj3lwIi5uvXQLs0=;7:HCMXqhqN5xMUk7i6ATH/ISr3BVfkoMneIz2MCOs9fYI/JbTLqm1fht9R8jM5RQykkk+7arDAifRDhQ6Ner9523ZGVbfRjbpWQSFpWPPAmtrd2Ux1ipsMEfAIjVyb8EQ12WfayLG3jBsm1gQI//itJWPLzONLkRxpyUROTrt9+KcjX+6M0TzyNUGjDXjB75yeprbJsh2gNG0iR1TlBO24n6V/qe3NcwIpTpKm6Cp67uM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1081;20:x7LDOFBO03/zzV2D8Q0brXsDXcC7h9q4zlaJiW/KP1BgQAIgAj4/+/Pe+vItoQtjqcxsb/hjO6WflCerkfKQpl4wPfi9qKxEBZ9ZRjsg/hpL0vJ9Dniy7NcmytMPq6fhX4bl9Fib+BTBOhHIBEFZ+WKybFNDfN4pmYjKRcDVMSc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2017 20:22:24.0820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1081 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-04_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 01:17:14PM -0700, David Rientjes wrote: > On Wed, 4 Oct 2017, Roman Gushchin wrote: > > > > > @@ -828,6 +828,12 @@ static void __oom_kill_process(struct task_struct *victim) > > > > struct mm_struct *mm; > > > > bool can_oom_reap = true; > > > > > > > > + if (is_global_init(victim) || (victim->flags & PF_KTHREAD) || > > > > + victim->signal->oom_score_adj == OOM_SCORE_ADJ_MIN) { > > > > + put_task_struct(victim); > > > > + return; > > > > + } > > > > + > > > > p = find_lock_task_mm(victim); > > > > if (!p) { > > > > put_task_struct(victim); > > > > > > Is this necessary? The callers of this function use oom_badness() to > > > find a victim, and that filters init, kthread, OOM_SCORE_ADJ_MIN. > > > > It is. __oom_kill_process() is used to kill all processes belonging > > to the selected memory cgroup, so we should perform these checks > > to avoid killing unkillable processes. > > > > That's only true after the next patch in the series which uses the > oom_kill_memcg_member() callback to kill processes for oom_group, correct? > Would it be possible to move this check to that patch so it's more > obvious? Sure, no problems.