From: Darren Hart <dvhart@infradead.org>
To: Mario.Limonciello@dell.com
Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, luto@kernel.org,
quasisec@google.com, pali.rohar@gmail.com
Subject: Re: [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI
Date: Wed, 4 Oct 2017 19:44:51 -0700 [thread overview]
Message-ID: <20171005024451.GI25018@fury> (raw)
In-Reply-To: <bff1f575d2d44b79ba9636433f19df9d@ausx13mpc120.AMER.DELL.COM>
On Sat, Sep 30, 2017 at 07:56:33PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@infradead.org]
> > Sent: Friday, September 29, 2017 9:17 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; LKML <linux-
> > kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; Andy Lutomirski
> > <luto@kernel.org>; quasisec@google.com; pali.rohar@gmail.com
> > Subject: Re: [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI
> >
> > On Wed, Sep 27, 2017 at 11:02:12PM -0500, Mario Limonciello wrote:
...
> > My other concern is the freeform structure around creating the file
> > operations in each driver for the chardev IOCTL. It seems like we need
> > some kind of defined mapping from METHOD index to IOCTL number, or else
> > some way to advertise what it is?
> >
>
> I was originally thinking it would be a good way to do this cleanly too, but my
> main concern is this one character device may handle multiple methods problem.
> If you map method instance (index) to ioctl number you will most likely run into
> clashes. So maybe it's worth not allowing that?
>
> So I've got another idea. How about instead of a variety of freeform ioctl per driver,
> provide three ioctl functions for all the character devices that come in through
> the WMI bus to use (say IOC 'W') with either read, write or write/read. The WMI bus
> should be able to know which driver to pass it on to by the character device used.
>
This is not something I have any experience with. I see you added it to v4, so
let's see what others have to say there.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-10-05 2:44 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 4:02 [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-09-28 4:02 ` [PATCH v3 1/8] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-09-28 4:02 ` [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Mario Limonciello
2017-09-28 6:53 ` Pali Rohár
2017-09-28 22:43 ` Mario.Limonciello
2017-09-29 7:35 ` Pali Rohár
2017-09-30 20:01 ` Mario.Limonciello
2017-09-30 21:06 ` Pali Rohár
2017-09-30 0:51 ` Darren Hart
2017-09-30 7:15 ` Pali Rohár
2017-09-30 19:56 ` Mario.Limonciello
2017-09-28 4:02 ` [PATCH v3 3/8] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check Mario Limonciello
2017-09-30 1:29 ` Darren Hart
2017-09-30 19:48 ` Mario.Limonciello
2017-09-30 20:01 ` Pali Rohár
2017-10-02 14:15 ` Mario.Limonciello
2017-10-02 14:37 ` Pali Rohár
2017-10-01 8:43 ` Andy Shevchenko
2017-09-28 4:02 ` [PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-09-30 1:52 ` Darren Hart
2017-09-30 8:12 ` Greg Kroah-Hartman
2017-09-30 19:26 ` Mario.Limonciello
2017-10-01 13:23 ` Greg KH
2017-10-01 14:25 ` Mario.Limonciello
2017-10-01 18:03 ` Greg KH
2017-10-02 0:57 ` Darren Hart
2017-10-02 9:24 ` Greg Kroah-Hartman
2017-10-02 14:33 ` Darren Hart
2017-10-03 9:23 ` Greg KH
2017-10-03 15:09 ` Mario.Limonciello
2017-10-03 15:10 ` Darren Hart
2017-10-03 16:48 ` Andy Lutomirski
2017-10-03 17:46 ` Greg KH
2017-10-03 18:38 ` Mario.Limonciello
2017-10-03 19:31 ` Andy Lutomirski
2017-10-03 9:23 ` Greg KH
2017-10-03 15:13 ` Mario.Limonciello
2017-09-28 4:02 ` [PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character device for userspace Mario Limonciello
2017-09-30 2:06 ` Darren Hart
2017-09-30 19:45 ` Mario.Limonciello
2017-10-03 9:26 ` Greg KH
2017-10-03 15:09 ` Mario.Limonciello
2017-10-03 15:20 ` Darren Hart
2017-10-03 15:49 ` Mario.Limonciello
2017-10-05 0:02 ` Darren Hart
2017-10-05 15:10 ` Mario.Limonciello
2017-09-28 4:02 ` [PATCH v3 6/8] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-09-30 2:10 ` Darren Hart
2017-10-01 8:51 ` Andy Shevchenko
2017-09-28 4:02 ` [PATCH v3 7/8] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios Mario Limonciello
2017-09-28 4:02 ` [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descriptor check Mario Limonciello
2017-10-02 13:15 ` Andy Shevchenko
2017-10-02 13:26 ` Mario.Limonciello
2017-09-30 2:16 ` [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI Darren Hart
2017-09-30 19:56 ` Mario.Limonciello
2017-10-05 2:44 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005024451.GI25018@fury \
--to=dvhart@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).