From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751817AbdJERkV convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Oct 2017 13:40:21 -0400
Received: from mx2.suse.de ([195.135.220.15]:37322 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751350AbdJERkT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Oct 2017 13:40:19 -0400
Date: Thu, 5 Oct 2017 10:40:04 -0700
From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <longman@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jeff Layton <jlayton@poochiereds.net>,
        "J. Bruce Fields" <bfields@fieldses.org>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <andi@firstfloor.org>, Dave Chinner <dchinner@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>, Waiman Long <Waiman.Long@hpe.com>
Subject: Re: [PATCH v6 4/6] lib/dlock-list: Make sibling CPUs share the same
 linked list
Message-ID: <20171005174004.GB5131@linux-80c1.suse>
References: <1507152007-28753-1-git-send-email-longman@redhat.com>
 <1507152007-28753-5-git-send-email-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <1507152007-28753-5-git-send-email-longman@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This is still spitting:

lib/dlock-list.c: In function ‘cpu2idx_init’:
lib/dlock-list.c:75:16: error: incompatible types when assigning to type ‘cpumask_var_t’ from type ‘struct cpumask *’
   sibling_mask = topology_sibling_cpumask(cpu);
                ^
lib/dlock-list.c:76:7: warning: the address of ‘sibling_mask’ will always evaluate as ‘true’ [-Waddress]
   if (sibling_mask) {
       ^