From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Alexander Pozdneev <pozdneyev@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
Krister Johansen <kjlx@templeofstupid.com>,
Milian Wolff <milian.wolff@kdab.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
Yao Jin <yao.jin@linux.intel.com>,
zhangmengting@huawei.com,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 0/1] perf callchain symbol resolving fix
Date: Thu, 5 Oct 2017 20:07:52 +0200 [thread overview]
Message-ID: <20171005180752.4rnwpo2bs2ryvwkw@gmail.com> (raw)
In-Reply-To: <20171005175913.16513-1-acme@kernel.org>
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 1addcd55bc54d669000221b41e379458ff3e6747:
>
> Merge tag 'perf-urgent-for-mingo-4.14-20170928' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-09-29 19:31:46 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171005
>
> for you to fetch changes up to c1fbc0cf81f1c464f5fda322c1104d4bb1da6711:
>
> perf callchain: Compare dsos (as well) for CCKEY_FUNCTION (2017-10-05 10:52:54 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fix:
>
> . Two functions from different binaries can have same start address. Thus,
> comparing only start address in match_chain() leads to inconsistent
> callchains. Fix this by adding a check for dsos as well (Ravi Bangoria)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Ravi Bangoria (1):
> perf callchain: Compare dsos (as well) for CCKEY_FUNCTION
>
> tools/perf/util/callchain.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Pulled, thanks a lot Arnaldo!
Ingo
prev parent reply other threads:[~2017-10-05 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 17:59 [GIT PULL 0/1] perf callchain symbol resolving fix Arnaldo Carvalho de Melo
2017-10-05 17:59 ` [PATCH 1/1] perf callchain: Compare dsos (as well) for CCKEY_FUNCTION Arnaldo Carvalho de Melo
2017-10-05 18:07 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005180752.4rnwpo2bs2ryvwkw@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pozdneyev@gmail.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=yao.jin@linux.intel.com \
--cc=zhangmengting@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox