From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbdJETqQ (ORCPT ); Thu, 5 Oct 2017 15:46:16 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36145 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbdJETo1 (ORCPT ); Thu, 5 Oct 2017 15:44:27 -0400 X-Google-Smtp-Source: AOwi7QBpOyJxzmtwBWQ9RySjvC/hAaYJwPXKtxSUuIRkyt7wyRKONrmDJA3M90EIhWkkPqHmcC5FFA== From: Rob Herring To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Nicolas Pitre , Frank Rowand , Grant Likely Subject: [PATCH 1/6] of: fix missing kobject init for !SYSFS && OF_DYNAMIC config Date: Thu, 5 Oct 2017 14:44:17 -0500 Message-Id: <20171005194422.26224-2-robh@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171005194422.26224-1-robh@kernel.org> References: <20171005194422.26224-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ref counting is broken for OF_DYNAMIC when sysfs is disabled because the kobject initialization is skipped. Only the properties add/remove/update should be skipped for !SYSFS config. Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/of/base.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 260d33c0f26c..9e9bd17121fb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -169,9 +169,6 @@ int __of_attach_node_sysfs(struct device_node *np) struct property *pp; int rc; - if (!IS_ENABLED(CONFIG_SYSFS)) - return 0; - if (!of_kset) return 0; -- 2.11.0