From: Andi Kleen <ak@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH v8 2/5] x86/cpuid: Add generic table for cpuid dependencies
Date: Thu, 5 Oct 2017 16:08:13 -0700 [thread overview]
Message-ID: <20171005230813.GA5109@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1710060031130.2398@nanos>
On Fri, Oct 06, 2017 at 12:41:56AM +0200, Thomas Gleixner wrote:
> On Thu, 5 Oct 2017, Andi Kleen wrote:
> > +/*
> > + * Table of CPUID features that depend on others.
> > + *
> > + * This only includes dependencies that can be usefully disabled, not
> > + * features part of the base set (like FPU).
> > + */
> > +const static struct cpuid_dep cpuid_deps[] = {
> > + { X86_FEATURE_XSAVEOPT, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_XSAVEC, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_XSAVES, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_AVX, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_AVX512F, X86_FEATURE_XSAVE },
>
> This looks redundant. AVX512F depends on AVX which itself depends on XSAVE.
True.
>
> > + { X86_FEATURE_PKU, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_MPX, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_XGETBV1, X86_FEATURE_XSAVE },
> > + { X86_FEATURE_XMM2, X86_FEATURE_XMM },
>
> XMM has no dependency?
Only FXSAVE, I'll add that.
Thanks,
-Andi
next prev parent reply other threads:[~2017-10-05 23:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 21:52 Support generic disabling of all XSAVE features Andi Kleen
2017-10-05 21:52 ` [PATCH v8 1/5] x86/xsave: Move xsave initialization to after parsing early parameters Andi Kleen
2017-10-05 21:52 ` [PATCH v8 2/5] x86/cpuid: Add generic table for cpuid dependencies Andi Kleen
2017-10-05 22:41 ` Thomas Gleixner
2017-10-05 23:08 ` Andi Kleen [this message]
2017-10-05 23:34 ` Andi Kleen
2017-10-05 21:52 ` [PATCH v8 3/5] x86/cpuid: Make clearcpuid an early param Andi Kleen
2017-10-05 21:52 ` [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling Andi Kleen
2017-11-11 23:15 ` [v8, " Guenter Roeck
2017-11-12 6:41 ` Andi Kleen
2017-11-14 1:28 ` Andi Kleen
2017-11-14 1:49 ` Guenter Roeck
2017-11-16 19:03 ` Andi Kleen
2017-11-16 22:13 ` Guenter Roeck
2017-11-14 2:33 ` Guenter Roeck
2019-06-29 15:22 ` [PATCH v8 " Vegard Nossum
2019-07-01 12:17 ` Sebastian Andrzej Siewior
2019-07-01 16:41 ` Andi Kleen
2019-07-01 16:39 ` Andi Kleen
2017-10-05 21:52 ` [PATCH v8 5/5] x86/xsave: Remove the explicit clearing of XSAVE dependend features Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005230813.GA5109@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox