From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751990AbdJEXIP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Oct 2017 19:08:15 -0400
Received: from mga14.intel.com ([192.55.52.115]:15623 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750965AbdJEXIO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Oct 2017 19:08:14 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,482,1500966000"; 
   d="scan'208";a="320110855"
Date: Thu, 5 Oct 2017 16:08:13 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>, x86@kernel.org, hpa@zytor.com,
        linux-kernel@vger.kernel.org, Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH v8 2/5] x86/cpuid: Add generic table for cpuid
 dependencies
Message-ID: <20171005230813.GA5109@tassilo.jf.intel.com>
References: <20171005215256.25659-1-andi@firstfloor.org>
 <20171005215256.25659-3-andi@firstfloor.org>
 <alpine.DEB.2.20.1710060031130.2398@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1710060031130.2398@nanos>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 06, 2017 at 12:41:56AM +0200, Thomas Gleixner wrote:
> On Thu, 5 Oct 2017, Andi Kleen wrote:
> > +/*
> > + * Table of CPUID features that depend on others.
> > + *
> > + * This only includes dependencies that can be usefully disabled, not
> > + * features part of the base set (like FPU).
> > + */
> > +const static struct cpuid_dep cpuid_deps[] = {
> > +	{ X86_FEATURE_XSAVEOPT,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_XSAVEC,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_XSAVES,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_AVX,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_AVX512F,		X86_FEATURE_XSAVE     },
> 
> This looks redundant. AVX512F depends on AVX which itself depends on XSAVE.

True.

> 
> > +	{ X86_FEATURE_PKU,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_MPX,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_XGETBV1,		X86_FEATURE_XSAVE     },
> > +	{ X86_FEATURE_XMM2,		X86_FEATURE_XMM       },
> 
> XMM has no dependency?

Only FXSAVE, I'll add that.

Thanks,

-Andi