From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbdJFIjg (ORCPT ); Fri, 6 Oct 2017 04:39:36 -0400 Received: from 8bytes.org ([81.169.241.247]:34106 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdJFIjf (ORCPT ); Fri, 6 Oct 2017 04:39:35 -0400 Date: Fri, 6 Oct 2017 10:39:31 +0200 From: Joerg Roedel To: Christoph Hellwig Cc: Jacob Pan , iommu@lists.linux-foundation.org, LKML , David Woodhouse , Greg Kroah-Hartman , Rafael Wysocki , Jean-Philippe Brucker , Lan Tianyu Subject: Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data Message-ID: <20171006083931.GY8398@8bytes.org> References: <1507244624-39189-1-git-send-email-jacob.jun.pan@linux.intel.com> <1507244624-39189-10-git-send-email-jacob.jun.pan@linux.intel.com> <20171006071145.GA24354@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171006071145.GA24354@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2017 at 12:11:45AM -0700, Christoph Hellwig wrote: > This is the 3rd iommu field, in addition to 8 dma-specific fields > that we carry around for each struct device. Agreed, consolidating the iommu-fields in 'struct device' into a single 'struct iommu_data' is on my todo-list. Jacob, can you add that 'struct iommu_data' to 'struct device' and put your fault-data into it? We can then move on and migrate the other fields into that struct too. Regards, Joerg