From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751811AbdJFIpc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Oct 2017 04:45:32 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:48085 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751430AbdJFIpb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Oct 2017 04:45:31 -0400
Date: Fri, 6 Oct 2017 10:45:27 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/20] ARM: dts: sun4i: Change pinctrl nodes to avoid
 warning
Message-ID: <20171006084526.h2ty25pajknlchue@flea>
References: <cover.f5f905a5434f2a540d6844d23369a04af9f5314c.1507198895.git-series.maxime.ripard@free-electrons.com>
 <5ed70f11299554e43f575aaf3b0bbe76991d8373.1507198895.git-series.maxime.ripard@free-electrons.com>
 <CAGb2v65wmkHvibm8pLBkrD3h_TySoiV605=6VW+pJN3xgoEbKw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="zlqbg3mf3nigzur3"
Content-Disposition: inline
In-Reply-To: <CAGb2v65wmkHvibm8pLBkrD3h_TySoiV605=6VW+pJN3xgoEbKw@mail.gmail.com>
User-Agent: NeoMutt/20170914 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--zlqbg3mf3nigzur3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Oct 05, 2017 at 03:29:56PM +0000, Chen-Yu Tsai wrote:
> > @@ -531,83 +531,83 @@
> >                                 bias-pull-up;
> >                         };
> >
> > -                       ps20_pins_a: ps20@0 {
> > -                               pins =3D "PI20", "PI21";
> > +                       ps2_ph_pins: ps2-ph-pins {
> > +                               pins =3D "PH12", "PH13";
> >                                 function =3D "ps2";
> >                         };
> >
> > -                       ps21_pins_a: ps21@0 {
> > -                               pins =3D "PH12", "PH13";
> > +                       ps2_pi_pins: ps2-pi-pins {
> > +                               pins =3D "PI20", "PI21";
> >                                 function =3D "ps2";
> >                         };
>=20
> This part is slightly incorrect. The PS/2 block has 2 inputs.
> The first channel, or ps2-0, has only one muxing option, on
> pins PI20 and PI21. The second channel has two options, either
> PH12 + PH13 or PI14 + PI15. The names should encode which channel
> the muxing option is for.

Would ps2_ch0_pins and ps2_ch1_pi_pins work for you then?

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--zlqbg3mf3nigzur3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJZ10KmAAoJEBx+YmzsjxAgnhMP/3+HuDWOSEtXTu0A4R1pEi78
n82Awib1GmY7GsxGHfjrMIL1OFmz9n1N6M+T9Pf/76Sdt+PZnu96yOPJrP+ruJnu
XAmMdixQdAmxiOB/K360VbgW6+xEYGnxh7Mdcch2HFo7Qfqe9hvY/Lvgbbt3Zs2n
mjCSo44qNr+32D/B5GaRL9kwiQJWB87XbcNO7taVPk/eFoHhF6lVwyluIAPeVhks
2TRESRgRg+g7JKxYkAZ/yGdXBoCectBglEBuOAcn9QBQmnVhAqK0RZQ07m0Xvxu7
mktthuGxq0i4RbSXu/B/PIgQ9wJF2ivUhB1xPS/RQFok10NwDi6VOIDsqOSp0EBW
1F+QYPpdt5oG+Tooi+OZEO6fPGJPKs/E3TZoKg4jXseCGDZXoskZaZSBUBCt4l3u
kfqa6Zp4SIGWdxksuFrw8Z5gSJW8LfQt8qK7o1JIqFz8c2OLKv//gpDW/KTWVLd8
xocPL9bQ7O0ta6BptXuMW4OVjHDDy646WJWy9zQtX9UZSfD/ZBgSTnEZpJR/W338
livL+n4OXLb5c0Np5CcGiC25AaY6V/BlGQSCMEmfiKRsD3zPEDNoz3861LKHvXV+
PGkJ/USe2oZ6n9OmKHcwc8wcSeIlrJROacdLiPMVlp+Q0RQCxgo+UMdZi7oVodrK
wIA8gTlvMKUeNvY1n84J
=uX+K
-----END PGP SIGNATURE-----

--zlqbg3mf3nigzur3--