From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbdJFIro (ORCPT ); Fri, 6 Oct 2017 04:47:44 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:48193 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbdJFIrn (ORCPT ); Fri, 6 Oct 2017 04:47:43 -0400 Date: Fri, 6 Oct 2017 10:47:40 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Rutland , Rob Herring , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 07/20] ARM: dts: sun4i: Remove skeleton and memory to avoid warnings Message-ID: <20171006084740.5g7tavojdghn7cma@flea> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="olksbkve3jmsoci5" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --olksbkve3jmsoci5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2017 at 03:43:53PM +0000, Chen-Yu Tsai wrote: > On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard > wrote: > > Using skeleton.dtsi will create a memory node that will generate a warn= ing > > in DTC. However, that node will be created by the bootloader, so we can > > just remove it entirely in order to remove that warning. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun4i-a10.dtsi | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i= -a10.dtsi > > index 1876abb62ec7..f64544f615ea 100644 > > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > > @@ -41,14 +41,14 @@ > > * OTHER DEALINGS IN THE SOFTWARE. > > */ > > > > -#include "skeleton.dtsi" > > - > > #include > > #include > > #include > > #include > > > > / { > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > interrupt-parent =3D <&intc>; > > > > aliases { > > @@ -160,10 +160,6 @@ > > }; > > }; > > > > - memory { > > - reg =3D <0x40000000 0x80000000>; > > - }; > > - >=20 > My only concern (I'm not sure if it's valid or not) is U-boot not being > able to add nodes or properties due to lack of space within the DT > blob. It seemed like a possibility in older versions. >=20 > Otherwise, >=20 > Acked-by: Chen-Yu Tsai I don't think we really have to worry about it. We've had a bunch of nodes (like the PSCI nodes) created in the same way for quite some time already without causing any issues. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --olksbkve3jmsoci5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ10MsAAoJEBx+YmzsjxAgoiUQAId4t3otwMDxnscWuvSavSwt hQFod+CE1AlLBvVCwJNRw9okrlWhitHJINEIdULFZEzNhOG6PCL8LrF3hKBB7jHS 1wPQVFtBdGIrXdmYPkvKcz+ONbc2x1sLgeV7AL2i/zzF275tGP/G8aT8sc6eTaZT OSXi2g/QJpb1G8AOVlszFAox/JBL6Y1y4ghZ3ycck/nEOTGTlb3lHvfe9HJDiGzT 6G/i1ShoRV5wcvurepa4+Y1WUpM8ij4Gn4usNgtiJFr3l3UJlEBMR4c7uJY36eKg 4j5UHJ7iP68hYnOHSA+Wr6g0p7dg4YjpLiiKDkK0dow9G3wOFgQrCq/uujCLuxwV gOZ8/rm69Ww1IFHws/4XHt/+RKDt3QmqQhADCXPyB/6TkBwldgpLrCcKllyY8z9S EsIQ/x509emIrGNDwj47d+xLQt4t1Wbc8bc3jpXKNcdB2e9OEPQugIibwZFmlPi/ Q5Ln/F1alPrbwX1w8KqO/5UncjMtU9fxDAtfWJU/JKO7ljVqM9hpywpLf+YhFogt nswe6hyHEu7J0wn25CBTF0lxr4Wbl5Jg9nXxtsk+opXM465p7eiuMacjmBov54hq t+0aoTWhCDw2tuJ3pb01oYiN2Us7dljaTIHcizj0dBMerVNrVGvt7wGfIODDN89v MTnsLFFWRZ3b9pfVUx88 =JwmU -----END PGP SIGNATURE----- --olksbkve3jmsoci5--