From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode
Date: Fri, 6 Oct 2017 11:15:50 +0200 [thread overview]
Message-ID: <20171006091550.GE7734@verge.net.au> (raw)
In-Reply-To: <1504233685-17947-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
On Fri, Sep 01, 2017 at 11:41:22AM +0900, Yoshihiro Shimoda wrote:
> The previous code assumed a channel has otg capability if a channel
> has interrupt property. But, it is not good because:
> - Battery charging feature also needs interrupt property.
> - Some R-Car Gen3 SoCs (e.g. R-Car D3) don't have OTG capability.
>
> So, this patch checks whether usb 2.0 host node has dr_mode property or
> not. If it has 'dr_mode = "otg";', this driver enables otg capability.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2017-10-06 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 2:41 [PATCH v3 0/4] phy: rcar-gen3-usb2: add support for r8a77995 Yoshihiro Shimoda
2017-09-01 2:41 ` [PATCH v3 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode Yoshihiro Shimoda
2017-10-06 9:15 ` Simon Horman [this message]
2017-09-01 2:41 ` [PATCH v3 2/4] phy: rcar-gen3-usb2: split the two meaning of "has_otg" Yoshihiro Shimoda
2017-10-06 9:15 ` Simon Horman
2017-10-09 10:06 ` Kishon Vijay Abraham I
2017-10-10 5:59 ` Yoshihiro Shimoda
2017-09-01 2:41 ` [PATCH v3 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins Yoshihiro Shimoda
2017-10-06 9:14 ` Simon Horman
2017-09-01 2:41 ` [PATCH v3 4/4] phy: rcar-gen3-usb2: add binding for r8a77995 Yoshihiro Shimoda
2017-10-06 9:14 ` Simon Horman
2017-10-06 2:13 ` [PATCH v3 0/4] phy: rcar-gen3-usb2: add support " Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006091550.GE7734@verge.net.au \
--to=horms@verge.net.au \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox