From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbdJFQUV (ORCPT ); Fri, 6 Oct 2017 12:20:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:5668 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbdJFQUU (ORCPT ); Fri, 6 Oct 2017 12:20:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,484,1500966000"; d="scan'208";a="135951745" Date: Fri, 6 Oct 2017 09:22:55 -0700 From: Jacob Pan To: Joerg Roedel Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, LKML , David Woodhouse , Greg Kroah-Hartman , Rafael Wysocki , Jean-Philippe Brucker , Lan Tianyu , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data Message-ID: <20171006092255.403d26a0@jacob-builder> In-Reply-To: <20171006083931.GY8398@8bytes.org> References: <1507244624-39189-1-git-send-email-jacob.jun.pan@linux.intel.com> <1507244624-39189-10-git-send-email-jacob.jun.pan@linux.intel.com> <20171006071145.GA24354@infradead.org> <20171006083931.GY8398@8bytes.org> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Oct 2017 10:39:31 +0200 Joerg Roedel wrote: > On Fri, Oct 06, 2017 at 12:11:45AM -0700, Christoph Hellwig wrote: > > This is the 3rd iommu field, in addition to 8 dma-specific fields > > that we carry around for each struct device. > > Agreed, consolidating the iommu-fields in 'struct device' into a > single 'struct iommu_data' is on my todo-list. > > Jacob, can you add that 'struct iommu_data' to 'struct device' and put > your fault-data into it? We can then move on and migrate the other > fields into that struct too. > sounds good.