From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbdJFJ0t (ORCPT ); Fri, 6 Oct 2017 05:26:49 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49231 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbdJFJ0o (ORCPT ); Fri, 6 Oct 2017 05:26:44 -0400 Date: Fri, 6 Oct 2017 11:26:35 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Rutland , Rob Herring , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 08/20] ARM: dts: sun4i: Change LRADC node names to avoid warnings Message-ID: <20171006092635.eeynkeoxgbj3c27f@flea> References: <14fb41e6a5648f99643629b1dc9df9ef04c01fbd.1507198895.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2b7veinnnuvnbyv6" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2b7veinnnuvnbyv6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2017 at 03:52:29PM +0000, Chen-Yu Tsai wrote: > On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard > wrote: > > One of the usage of the LRADC is to implement buttons. The bindings def= ine > > that we should have one subnode per button, with their associated volta= ge > > as a property. > > > > However, there was no reg property but we still used the voltage associ= ated > > to the button as the unit-address, which eventually generated warnings = in > > DTC. > > > > Rename the node names to avoid those warnings. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 6 +++--- > > arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 4 ++-- > > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 6 +++--- > > arch/arm/boot/dts/sun4i-a10-inet1.dts | 6 +++--- > > arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 10 +++++----- > > arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 10 +++++----- > > arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 4 ++-- > > 7 files changed, 23 insertions(+), 23 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts b/arch/arm= /boot/dts/sun4i-a10-chuwi-v7-cw0825.dts > > index 4978e46ca620..b2dbdac19c0f 100644 > > --- a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts > > +++ b/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts > > @@ -98,21 +98,21 @@ > > vref-supply =3D <®_vcc3v0>; > > status =3D "okay"; > > > > - button@800 { > > + button-800 { >=20 > I think 800mV-button would be better, i.e. have the "generic" > part of the name as a suffix. It would go against most of the convention that we have everywhere else for framebuffers, pin muxings, or even regular node names that start with the class, and then have the most specific part. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --2b7veinnnuvnbyv6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ10xLAAoJEBx+YmzsjxAgTsgQAJsrlDB3t+VFseVZ/4yrSvNx 8g7tJp5k5wOM2SJpWNmEv4x/A5lqgLNMyM2dyHVWP1BO+UKBbYCgeFvz1UvGsur5 3BD3Q7yxsuTkqk0lNZ6xaqoK9C731oORkRXAghijR5BMupj9o34S70mBNteH1koR 8BZ/8UPVImq70FU76/AxUww+3GpsRAnmKzkLolVSvSf3421ddHV6FjmbJEppMzap B8RrZRoVrvBnTbOKBFxPDxOuW/gJX5rXXp675avPwvyFaHkCPuuVa3pcCJhQBV2C sHxlW3pL1nBSBFylgK58JZIQ7QLb/kpSGMz7YJxnLaOVXQfGfRZWVFSHh8Lejmcv 8PwKxXr6G9NjC4VPFcfdPIzdnrfBdDBVNm7I3gkNsDbIpq0omjl44a7SoyyWOAtL GiCzGvbI4ayWk7El7hMJgVmN3sF6ny8ef76eB8k5f7CbymUbN475FdElXbw3uQNS k/poj7mnBdOpTRkB9yqm5TsAAkys8WQT1N4bcgc28Q91GJ3Gx/XS9OyxGbKDjtYu muabdTd4bmWxcBtd4ri9hnGWuXv8fgIWka/Y3zN76ZgS93/Pb27dhjDPUOUBnbm2 gzw0z+CZAj2+Xk66oAdtmHG0HTo5IwAdgph48d3Qod2iRKSTkBlmB8P5mEdOotlH 1mXaGk39JSKVF83tIsOB =x8p8 -----END PGP SIGNATURE----- --2b7veinnnuvnbyv6--