From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbdJFJ2C (ORCPT ); Fri, 6 Oct 2017 05:28:02 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49318 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbdJFJ2A (ORCPT ); Fri, 6 Oct 2017 05:28:00 -0400 Date: Fri, 6 Oct 2017 11:27:57 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Rutland , Rob Herring , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings Message-ID: <20171006092757.eexffejnralxlguf@flea> References: <247d527cb833713f487b97a2c95e30545273ac92.1507198895.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k5qfgfczp6eopwxd" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k5qfgfczp6eopwxd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2017 at 03:51:02PM +0000, Chen-Yu Tsai wrote: > On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard > wrote: > > Some gpio-keys definitions in our DTs were having buttons defined with a > > unit-address and that would generate a DTC warning. > > > > Change the buttons node names to remove the warnings. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++----------- > > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 6 +-- > > 2 files changed, 23 insertions(+), 23 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/bo= ot/dts/sun4i-a10-inet9f-rev03.dts > > index 7c7f12132ea3..13224f5ac166 100644 > > --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts > > +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts > > @@ -67,7 +67,7 @@ > > #size-cells =3D <0>; > > poll-interval =3D <20>; > > > > - button@0 { > > + left-joystick-left { >=20 > Does this fit the naming scheme? Should we have "-button" suffices? The example binding of gpio-keys just have the key name as node name, just like most of the DT out there I could find. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --k5qfgfczp6eopwxd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ10ydAAoJEBx+YmzsjxAgzUMQAJsuNG/9Vf2uhAYPiXDAbu5h WOebunC3zLh91Zyw8kogprKRQMflhGM1ZFawu1WJYlon5BMm0j0U1lIZJWmvkLdo ERpcUNcM1atFZG47/PuZwNampWFU58CzutIT0ykfmkh4btSe+9QlijtHInleu7AS YU2516KTPqEkwnhzNw1o4YwJxKmScG/Rk9UT1/mkKwE5IJPQRBmbY6/P/SifaYVo R8q/Jfr2D8jQVkrJ4qKSyq7ypFIoHp6z9vIMfAToh+cyQbwliUp8zRT5kca/XK20 YreStO0vQS1h1bAN89qlvrX3T1CsOUS78GAivadxbJIRQ/vHUZ11DLWXcBBkTPh9 m9BeQuIRzRI+BWbOmkLEsWMxsJRDgiemDcspFWCblJ/6bsGS3w6wHP0GIoRS2/Sk S+57iX8bSaLfSfdasAeHewYt79u1lFi0N06xZm4isMlMM47qf0SSSLb9eZeg9o4T SgfifeCY7HA1wsdt/WzYuzgOPz8eGxUdjjz4SwaDw2PzXZtZ3rxezlC+SLYz/68d Gg32a73IHiScU0H/gGQIVgpxNszNn5VPPT7uCdBePKbVgIFuaydMArRqA+O0ec6i pH8xWVr6F9ffMFbkXRXHmo+l7f+3wv4MW6bzke1wpq2l/Svo81MadAcWoQ71NZXd L+tyTDcFhDyWVfIaVwrF =Huzf -----END PGP SIGNATURE----- --k5qfgfczp6eopwxd--