From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbdJFJef (ORCPT ); Fri, 6 Oct 2017 05:34:35 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49649 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbdJFJeb (ORCPT ); Fri, 6 Oct 2017 05:34:31 -0400 Date: Fri, 6 Oct 2017 11:34:27 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Rutland , Rob Herring , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 19/20] ARM: dts: sun9i: Change node names to remove underscores Message-ID: <20171006093427.qpsjvwa376kt2x73@flea> References: <708449b45b1ef546a4c27d99bc68d6cc151e8ad3.1507198895.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="usupo7y7y5teujyu" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --usupo7y7y5teujyu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 05, 2017 at 03:56:29PM +0000, Chen-Yu Tsai wrote: > On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard > wrote: > > Some node names in the A80 DTSI still have underscores in them. Remove = them > > in favour of hyphens to remove DTC warnings. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun9i-a80.dtsi | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i= -a80.dtsi > > index f9cb701f29b0..70d79ef711b3 100644 > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi > > @@ -139,7 +139,7 @@ > > * would also throw all the PLL clock rates off, or jus= t the > > * downstream clocks in the PRCM. > > */ > > - osc24M: osc24M_clk { > > + osc24M: clk-24M { >=20 > Can we stick with the same style for all clks? Like "X-clk"? >=20 > > #clock-cells =3D <0>; > > compatible =3D "fixed-clock"; > > clock-frequency =3D <24000000>; > > @@ -151,7 +151,7 @@ > > * AC100 codec/RTC chip. This serves as a placeholder f= or > > * board dts files to specify the source. > > */ > > - osc32k: osc32k_clk { > > + osc32k: clk-32k { >=20 > And here. I guess that's the same argument for buttons. Most of the other nodes are starting with the device class, and have a suffix to make them generic. > > #clock-cells =3D <0>; > > compatible =3D "fixed-factor-clock"; > > clock-div =3D <1>; > > @@ -169,7 +169,7 @@ > > clock-output-names =3D "cpus"; > > }; > > > > - ahbs: ahbs_clk { > > + ahbs: ahbs-clk { > > compatible =3D "fixed-factor-clock"; > > #clock-cells =3D <0>; > > clock-div =3D <1>; > > @@ -708,12 +708,12 @@ > > #interrupt-cells =3D <3>; > > #gpio-cells =3D <3>; > > > > - r_ir_pins: r_ir { > > + r_ir_pins: r-ir { >=20 > "r-ir-pins". >=20 > > pins =3D "PL6"; > > function =3D "s_cir_rx"; > > }; > > > > - r_rsb_pins: r_rsb { > > + r_rsb_pins: r-rsb { >=20 > "r-rsb-pins". I'll address those comments, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --usupo7y7y5teujyu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZ104jAAoJEBx+YmzsjxAgMA0P/At9ukxvilZUvhmC4PBehYyv 8kqFRG6vzEKGrVMnpxTOiaLwuMZPmudMjowjhbaR5k9TyFTNEyRegKGHZmRx27Q1 pARBf41pmpt4WL1LZgWrvZ7yMCwiN6pcVwXmBU+iqyiEXLIBEiq2avjtOdaB6ne/ ws9/XVZ1I7wQPkc/Rm9+VjOIGULEY1HzRNMU4wvotU2luY/MS50l0fc47zs6V6Us H19eShoFy9JIX8B0aXusUbjBBZUDRSTMRBs49sdkIiKYvCMuh7AKqpB7hGaAkfTD UzDr4aJiUoD/qRvidUeclrt99IsVTwdzMzHVAsv9miAQ1xt+mCqmNUYMAAiPi9GJ KMvo6kyImSc0y8j/WKSYMibVmgKcvSvroB+/CtXM9mtrW70ywjONtnP9j0rQY0wB DQOEd5882XZvCz6BK1cu8VNoQRsG1M9FnyO3MbMUKRJdZk4BBEoci6fQKAjPwEvE 2fKjsnM3cukEdXg++U+ySYUWjLMJ7ZX+VFsoG+T4xbVQRjQWd5ltxDqGn8NlZrP4 jaZNRwJqwK6qk5ZjYBVGZYB8euVdVb1uX/KNK3KJWQSJh6P1SnCldEv6i1Y0QGOn m0M5L6JABClVb8a2B0R56ztvfmTWqkKABdFq9EYXKdQk0JnNF6b+Ur8+7U/aIHij ErAGHITJqhDZtdQWCsfU =iCfV -----END PGP SIGNATURE----- --usupo7y7y5teujyu--