From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbdJFMkl (ORCPT ); Fri, 6 Oct 2017 08:40:41 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:41657 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbdJFMkk (ORCPT ); Fri, 6 Oct 2017 08:40:40 -0400 Date: Fri, 6 Oct 2017 14:40:36 +0200 From: Pablo Neira Ayuso To: Harsha Sharma Cc: netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] INSTALL: Update dependency list and configure with libxtables support Message-ID: <20171006124036.GD4713@salvia> References: <20171005073109.19874-1-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171005073109.19874-1-harshasharmaiitr@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.7 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 05, 2017 at 01:01:09PM +0530, Harsha Sharma wrote: > Add configure with lixtables in INSTALL and required dependencies for > the same Applied, thanks. I have mangled this a bit. Applying: INSTALL: Update dependency list and configure with libxtables support patch:29: space before tab in indent. option in nft. There is a space before tab in indent, have a look at your editor, it's easy to spot them. And I have modified the libxtables part to explain a bit more the interaction between nft and the iptables-compat utility. Just follow up if you find anything that you can improve. Here I have enabled highlight of this and trailing whitespaces, please have a look. Thanks.