From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbdJFPOR (ORCPT ); Fri, 6 Oct 2017 11:14:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45703 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbdJFPOQ (ORCPT ); Fri, 6 Oct 2017 11:14:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 66EDEC04AC72 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Fri, 6 Oct 2017 10:14:08 -0500 From: Josh Poimboeuf To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Jiri Kosina , Miroslav Benes , Petr Mladek Subject: Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails Message-ID: <20171006151408.74cvtrs5xrnmwatt@treble> References: <1506959808-23838-1-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1506959808-23838-1-git-send-email-joe.lawrence@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 06 Oct 2017 15:14:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2017 at 11:56:48AM -0400, Joe Lawrence wrote: > When an incoming module is considered for livepatching by > klp_module_coming(), it iterates over multiple patches and multiple > kernel objects in this order: > > list_for_each_entry(patch, &klp_patches, list) { > klp_for_each_object(patch, obj) { > > which means that if one of the kernel objects fails to patch, > klp_module_coming()'s error path needs to unpatch and cleanup any kernel > objects that were already patched by a previous patch. > > Reported-by: Miroslav Benes > Suggested-by: Petr Mladek > Signed-off-by: Joe Lawrence > --- > v2: > > - cleanup comment describing the new function > - s/klp_cleanup_module_objects_limited/klp_cleanup_module_patches_limited > - added a suggested-by tag for Petr since he suggested both code and > commentary :) Any more comments on this patch? This is holding up the callbacks patch so it would be great if we could get this merged soon. -- Josh