From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752622AbdJFVIM (ORCPT ); Fri, 6 Oct 2017 17:08:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53710 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751618AbdJFVII (ORCPT ); Fri, 6 Oct 2017 17:08:08 -0400 Date: Fri, 6 Oct 2017 14:08:01 -0700 From: "Paul E. McKenney" To: Mathieu Desnoyers Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Boqun Feng , Andrew Hunter , Maged Michael , gromer@google.com, Avi Kivity , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Dave Watson , Alan Stern , Will Deacon , Andy Lutomirski , Ingo Molnar , Alexander Viro , linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org Subject: Re: [RFC PATCH for 4.14 1/2] membarrier: Remove unused code for architectures without membarrier hooks Reply-To: paulmck@linux.vnet.ibm.com References: <20171005223327.3500-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171005223327.3500-1-mathieu.desnoyers@efficios.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17100621-0008-0000-0000-0000028C3C13 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007852; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000235; SDB=6.00927424; UDB=6.00466664; IPR=6.00707682; BA=6.00005623; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017426; XFM=3.00000015; UTC=2017-10-06 21:08:05 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100621-0009-0000-0000-000036ED9D26 Message-Id: <20171006210801.GL3521@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710060291 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 05, 2017 at 06:33:26PM -0400, Mathieu Desnoyers wrote: > Architectures without membarrier hooks don't need to emit the > empty membarrier_arch_switch_mm() static inline when > CONFIG_MEMBARRIER=y. > > Adapt the CONFIG_MEMBARRIER=n counterpart to only emit the empty > membarrier_arch_switch_mm() for architectures with membarrier hooks. > > Reported-by: Nicholas Piggin > Signed-off-by: Mathieu Desnoyers Queued for further review and testing, targeting v4.15. Please let me know if you need it sooner. Thanx, Paul > CC: Peter Zijlstra > CC: Paul E. McKenney > CC: Boqun Feng > CC: Andrew Hunter > CC: Maged Michael > CC: gromer@google.com > CC: Avi Kivity > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Michael Ellerman > CC: Dave Watson > CC: Alan Stern > CC: Will Deacon > CC: Andy Lutomirski > CC: Ingo Molnar > CC: Alexander Viro > CC: linuxppc-dev@lists.ozlabs.org > CC: linux-arch@vger.kernel.org > --- > include/linux/sched/mm.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index d5a9ab8f3836..b2767ecb21a8 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -215,10 +215,6 @@ static inline void memalloc_noreclaim_restore(unsigned int flags) > #ifdef CONFIG_ARCH_HAS_MEMBARRIER_HOOKS > #include > #else > -static inline void membarrier_arch_switch_mm(struct mm_struct *prev, > - struct mm_struct *next, struct task_struct *tsk) > -{ > -} > static inline void membarrier_arch_fork(struct task_struct *t, > unsigned long clone_flags) > { > @@ -247,10 +243,12 @@ static inline void membarrier_execve(struct task_struct *t) > membarrier_arch_execve(t); > } > #else > +#ifdef CONFIG_ARCH_HAS_MEMBARRIER_HOOKS > static inline void membarrier_arch_switch_mm(struct mm_struct *prev, > struct mm_struct *next, struct task_struct *tsk) > { > } > +#endif > static inline void membarrier_fork(struct task_struct *t, > unsigned long clone_flags) > { > -- > 2.11.0 >