From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbdJFW0F (ORCPT ); Fri, 6 Oct 2017 18:26:05 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:55196 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbdJFW0D (ORCPT ); Fri, 6 Oct 2017 18:26:03 -0400 X-Google-Smtp-Source: AOwi7QDN3/l8z/i7MSrvkwKU8zIS5enhLrSMeIg+wUhOxqeTQS9pGkHa4NeIltPYhCE33gCjyyB4tQ== Date: Fri, 6 Oct 2017 18:26:57 -0400 From: Tim Hansen To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free() Message-ID: <20171006222629.GA30627@debian> References: <20171005180920.GA121296@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote: > On 10/05/2017 12:09 PM, Tim Hansen wrote: > > mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks. > > > > This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch). > > Applied, but I had to fix up your commit message. Please line wrap at > 72 chars, otherwise it turns into an unreadable mess when people > try to view them. > > -- > Jens Axboe > Noted! Thanks for the heads up on the char limit.