From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754048AbdJIKEV (ORCPT <rfc822;w@1wt.eu>);
        Mon, 9 Oct 2017 06:04:21 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56953 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754002AbdJIKET (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Oct 2017 06:04:19 -0400
X-ME-Sender: <xms:oknbWfqYyrOgqr5xQhxtVeMpEem2f-nUcu5Xw1dZ76XOLsl5-4FtLg>
X-Sasl-enc: e0XqwQrbX8+FBsNtE+jQSfDg6CIVoNCalE/BfDnEAmmi 1507543458
Date: Mon, 9 Oct 2017 21:04:15 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: rkrcmar@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: remove printing of token address
Message-ID: <20171009100415.GA12785@eros>
References: <1507530614-10504-1-git-send-email-me@tobin.cc>
 <1845029054.11118038.1507535378802.JavaMail.zimbra@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1845029054.11118038.1507535378802.JavaMail.zimbra@redhat.com>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 09, 2017 at 03:49:38AM -0400, Paolo Bonzini wrote:
> 
> 
> ----- Original Message -----
> > From: "Tobin C. Harding" <me@tobin.cc>
> > To: "Paolo Bonzini" <pbonzini@redhat.com>, rkrcmar@redhat.com
> > Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Tobin C. Harding" <me@tobin.cc>
> > Sent: Monday, October 9, 2017 8:30:14 AM
> > Subject: [PATCH] KVM: remove printing of token address
> > 
> > KVM currently prints the address of the consumer token. It is not
> > immediately clear what benefit it is to see this address. Printing
> > this address leaks kernel pointers into dmesg and is a security risk.
> > 
> > Remove the consumer token address from error message output.
> 
> It should use %pK instead.

Is there any other way we can identify a token? There is some push back against kpt_restrict (as
used by %pK) at the moment. If there is another sane way to do it perhaps we could consider that,
else I'll use %pK for v2.

> Also, please do the same change on the VFIO
> side (drivers/vfio/pci/vfio_pci_intrs.c, call to irq_bypass_register_producer).

Oh, cool. I was wondering where the other side was. Will send v2

thanks,
Tobin.