From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223AbdJIMhI (ORCPT ); Mon, 9 Oct 2017 08:37:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60930 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdJIMhH (ORCPT ); Mon, 9 Oct 2017 08:37:07 -0400 Date: Mon, 9 Oct 2017 14:37:06 +0200 From: Greg KH To: Martijn Coenen Cc: john.stultz@linaro.org, tkjos@google.com, arve@android.com, devel@driverdev.osuosl.org, malchev@google.com, maco@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ANDROID: binder: call poll_wait() unconditionally. Message-ID: <20171009123706.GA23581@kroah.com> References: <20171009122656.53189-1-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171009122656.53189-1-maco@android.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 02:26:56PM +0200, Martijn Coenen wrote: > Because we're not guaranteed that subsequent calls > to poll() will have a poll_table_struct parameter > with _qproc set. When _qproc is not set, poll_wait() > is a noop, and we won't be woken up correctly. > > Signed-off-by: Martijn Coenen > --- > drivers/android/binder.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) Does this need to get into 4.14-final, or is 4.15-rc1 ok? I'm a bit lost as to which patches I applied to what tree... thanks, greg "drowning in trees" k-h