From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbdJIOHc (ORCPT ); Mon, 9 Oct 2017 10:07:32 -0400 Received: from one.firstfloor.org ([193.170.194.197]:34910 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125AbdJIOHb (ORCPT ); Mon, 9 Oct 2017 10:07:31 -0400 Date: Mon, 9 Oct 2017 07:07:29 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , Arnaldo Carvalho de Melo , Jiri Olsa , Wang Nan , linux-kernel@vger.kernel.org, Andi Kleen , He Kuang , Alexei Starovoitov Subject: Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case Message-ID: <20171009140728.GG2482@two.firstfloor.org> References: <20170912195643.2611-1-andi@firstfloor.org> <20170912195643.2611-2-andi@firstfloor.org> <20171003160605.GC25388@kernel.org> <20171004103052.GC23759@krava> <20171004162711.GF2482@two.firstfloor.org> <20171009134151.GA15127@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171009134151.GA15127@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 03:41:51PM +0200, Jiri Olsa wrote: > On Wed, Oct 04, 2017 at 09:27:11AM -0700, Andi Kleen wrote: > > On Wed, Oct 04, 2017 at 12:30:52PM +0200, Jiri Olsa wrote: > > > On Tue, Oct 03, 2017 at 01:06:05PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Sep 12, 2017 at 12:56:43PM -0700, Andi Kleen escreveu: > > > > > From: Andi Kleen > > > > > > > > > > There are still problems with BPF misinterpreting some events > > > > > that include .c. An earlier fix made it work for stand alone > > > > > aliases, but it still fails for more complex constructs. > > > > > > > > Hi Wang, Jiri, > > > > > > > > Can you please take a look at this and see if there is something > > > > we can do to help Andi? > > > > > > > > - Arnaldo > > > > > > > > > REJECT keeps trying and trying a shorter string until > > > > > .c is matched and it appears like a valid BPF path. > > > > > > > > > > % perf stat -e cpu/uops_executed.core,cmask=1/ true > > > > > bpf: builtin compilation failed: -95, try external compiler > > > > > ERROR: problems with path cpu/uops_executed.c: No such file or directory > > > > > event syntax error: 'cpu/uops_executed.core,cmask=1/' > > > > > \___ Failed to load cpu/uops_executed.c from source: Error when compiling BPF scriptlet > > > > > > > > > > I tried to fix it, but it exceeds my flex knowledge, because > > > > > REJECT does not interact well with BEGIN states. > > > > > > > > > > The BPF syntax in its current form really causes an ambigious > > > > > grammar. > > > > > > right, it looks like we allow whole path (including / char) > > > for BPF file, which messes up with out pmu/.../ syntax > > > > > > do we need that? (Cc-ed some bpf folks) > > > > > > if not attached patch seems to fix things.. otherwise > > > we need to come up with another fix > > > > I tried similar patches, but I always ran into more complex > > situations where it still matched incorrectly. > > > > e.g. try it with cpu/uops_executed.core,... vs uops_executed.core > > hm, both works for me with the change: > > perf stat -e cpu/uops_executed.core/ ls > perf stat -e uops_executed.core ls Ok. If it works it's fine for me. > > > The only real fix would be probably to add some unique > > prefix for BPF, but that would break all existing users. > > > yea, there was no response from bpf folks, but it's probably not an optio > > how about checking if the file exist like below.. I presume that would interact badly with good error messages for typos for file names. -Andi