From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
He Kuang <hekuang@huawei.com>, Alexei Starovoitov <ast@fb.com>
Subject: Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case
Date: Mon, 9 Oct 2017 16:43:19 +0200 [thread overview]
Message-ID: <20171009144319.GC1561@krava> (raw)
In-Reply-To: <20171009140728.GG2482@two.firstfloor.org>
On Mon, Oct 09, 2017 at 07:07:29AM -0700, Andi Kleen wrote:
SNIP
> >
> > > The only real fix would be probably to add some unique
> > > prefix for BPF, but that would break all existing users.
> >
> >
> > yea, there was no response from bpf folks, but it's probably not an optio
> >
> > how about checking if the file exist like below..
>
> I presume that would interact badly with good error messages for typos
> for file names.
it'd misplaced them for event names.. maybe not big deal
jirka
next prev parent reply other threads:[~2017-10-09 14:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 19:56 [PATCH 1/2] perf, tools, json: Fix ILP metrics Andi Kleen
2017-09-12 19:56 ` [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case Andi Kleen
2017-10-03 16:06 ` Arnaldo Carvalho de Melo
2017-10-04 10:30 ` Jiri Olsa
2017-10-04 16:27 ` Andi Kleen
2017-10-09 13:41 ` Jiri Olsa
2017-10-09 14:07 ` Andi Kleen
2017-10-09 14:12 ` Arnaldo Carvalho de Melo
2017-10-09 14:39 ` Jiri Olsa
2017-10-09 14:51 ` Arnaldo Carvalho de Melo
2017-10-09 15:39 ` Andi Kleen
2017-10-12 15:31 ` Wangnan (F)
2017-10-12 15:59 ` Jiri Olsa
2017-10-12 16:07 ` Wangnan (F)
2017-10-09 14:43 ` Jiri Olsa [this message]
2017-10-09 14:09 ` Arnaldo Carvalho de Melo
2017-10-09 14:41 ` Jiri Olsa
2017-10-12 15:13 ` Jiri Olsa
2017-10-12 21:53 ` Andi Kleen
2017-10-28 23:10 ` [tip:perf/urgent] perf tools: Unwind properly location after REJECT tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009144319.GC1561@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=ast@fb.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox